issue_comments

Table actions

4 rows where issue = 1373210675

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1502543165 https://github.com/dogsheep/swarm-to-sqlite/issues/13#issuecomment-1502543165 https://api.github.com/repos/dogsheep/swarm-to-sqlite/issues/13 IC_kwDODD6af85Zjv09 simonw 9599 2023-04-11T01:10:36Z 2023-04-11T01:11:47Z MEMBER I just had that error myself on macOS while running the tests: ``` ERROR tests/test_save_checkin.py::test_tables - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_venue - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_event - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_sticker - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_likes - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_with_ - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_users - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_photos - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_posts - sqlite3.OperationalError: table sqlite_master may not be modified ERROR tests/test_save_checkin.py::test_view - sqlite3.OperationalError: table sqlite_master may not be modified ``` `pytest --pdb` shows it happening in the bit that adds foreign keys: ``` > /Users/simon/.local/share/virtualenvs/swarm-to-sqlite-daPW7yIJ/lib/python3.9/site-packages/sqlite_utils/db.py(1096)add_foreign_keys() -> cursor.execute( (Pdb) list 1096 >> cursor.execute( 1097 "UPDATE sqlite_master SET sql = ? WHERE name = ?", 1098 (new_sql, table_name), 1099 ) 1100 cursor.execute("PRAGMA schema_version = %d" % (schema_version + 1)) 1101 -> cursor.execute("PRAGMA writable_schema = 0") 1102 # Have to VACUUM outside the transaction to ensure .foreign_keys property 1103 # can see the newly created foreign key. 1104 self.vacuum() ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} fails before generating views. ERR: table sqlite_master may not be modified 1373210675  
1502546045 https://github.com/dogsheep/swarm-to-sqlite/issues/13#issuecomment-1502546045 https://api.github.com/repos/dogsheep/swarm-to-sqlite/issues/13 IC_kwDODD6af85Zjwh9 simonw 9599 2023-04-11T01:14:50Z 2023-04-11T01:14:50Z MEMBER Related: - https://github.com/simonw/sqlite-utils/issues/235 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} fails before generating views. ERR: table sqlite_master may not be modified 1373210675  
1502629219 https://github.com/dogsheep/swarm-to-sqlite/issues/13#issuecomment-1502629219 https://api.github.com/repos/dogsheep/swarm-to-sqlite/issues/13 IC_kwDODD6af85ZkE1j simonw 9599 2023-04-11T03:15:26Z 2023-04-11T03:15:26Z MEMBER OK, I figured this out. Unfortunately it's an error that occurs on Python versions that have defensive mode turned on, and it doesn't look like there's a way to turn that mode off. See notes above. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} fails before generating views. ERR: table sqlite_master may not be modified 1373210675  
1502629404 https://github.com/dogsheep/swarm-to-sqlite/issues/13#issuecomment-1502629404 https://api.github.com/repos/dogsheep/swarm-to-sqlite/issues/13 IC_kwDODD6af85ZkE4c simonw 9599 2023-04-11T03:15:47Z 2023-04-11T03:46:17Z MEMBER I think `swarm-to-sqlite` needs to avoid this error, maybe by setting up foreign keys in another way - or even by skipping foreign keys entirely on databases that don't support this kind of operation. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} fails before generating views. ERR: table sqlite_master may not be modified 1373210675  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);