issue_comments

Table actions

3 rows where issue = 1388631785

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, author_association, created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1260357583 https://github.com/simonw/datasette/issues/1826#issuecomment-1260357583 https://api.github.com/repos/simonw/datasette/issues/1826 IC_kwDOBm6k_c5LH4fP simonw 9599 2022-09-28T04:05:16Z 2022-09-28T04:05:16Z OWNER This is deliberate. The Datasette plugin system allows you to specify only a subset of the parameters for a hook - in this example, only the `value` is needed so the others can be omitted. There's a note about this at the very top of that documentation page: https://docs.datasette.io/en/stable/plugin_hooks.html#plugin-hooks > When you implement a plugin hook you can accept any or all of the parameters that are documented as being passed to that hook. > > For example, you can implement the `render_cell` plugin hook like this even though the full documented hook signature is `render_cell(value, column, table, database, datasette)`: > ```python > @hookimpl > def render_cell(value, column): > if column == "stars": > return "*" * int(value) > ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} render_cell documentation example doesn't match the method signature 1388631785  
1260357878 https://github.com/simonw/datasette/issues/1826#issuecomment-1260357878 https://api.github.com/repos/simonw/datasette/issues/1826 IC_kwDOBm6k_c5LH4j2 simonw 9599 2022-09-28T04:05:45Z 2022-09-28T04:05:45Z OWNER Though now I notice that the copy right there needs to be updated to reflect the new `row` parameter to `render_cell`! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} render_cell documentation example doesn't match the method signature 1388631785  
1260373403 https://github.com/simonw/datasette/issues/1826#issuecomment-1260373403 https://api.github.com/repos/simonw/datasette/issues/1826 IC_kwDOBm6k_c5LH8Wb pjamargh 66709385 2022-09-28T04:30:27Z 2022-09-28T04:30:27Z NONE I'm glad the bug report served some purpose. Frankly I just needed the method signature, that is why the documentation you mention wasn't read. On Tue, Sep 27, 2022, 9:05 PM Simon Willison ***@***.***> wrote: > Though now I notice that the copy right there needs to be updated to > reflect the new row parameter to render_cell! > > — > Reply to this email directly, view it on GitHub > <https://github.com/simonw/datasette/issues/1826#issuecomment-1260357878>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AP46PCLI6KVDQTFLWVZODRLWAO72JANCNFSM6AAAAAAQXKWIJA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} render_cell documentation example doesn't match the method signature 1388631785  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);