issue_comments
10 rows where issue = 1423000702
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
| id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| 1291071627 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291071627 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9DCL | simonw 9599 | 2022-10-25T20:02:18Z | 2022-10-25T20:02:18Z | OWNER | Passes on Windows with other Python versions for some reason. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291076031 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291076031 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9EG_ | simonw 9599 | 2022-10-25T20:06:28Z | 2022-10-25T20:06:28Z | OWNER | This is the failing test: https://github.com/simonw/sqlite-utils/blob/7b2d1c0ffd0b874e280292b926f328a61cb31e2c/tests/test_recreate.py#L21-L32 I'm going to try a different way of creating the temporary file: https://docs.pytest.org/en/7.1.x/how-to/tmp_path.html | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291083188 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291083188 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9F20 | simonw 9599 | 2022-10-25T20:12:52Z | 2022-10-25T20:12:52Z | OWNER | Failed again, but just noticed this: https://github.com/simonw/sqlite-utils/actions/runs/3323932266/jobs/5494890223 ``` > Database(filepath, recreate=True)["t2"].insert({"foo": "bar"}) tests\test_recreate.py:31: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <[AttributeError("'Database' object has no attribute 'conn'") raised in repr()] Database object at 0x29fc125aa90> ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291088108 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291088108 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9HDs | simonw 9599 | 2022-10-25T20:17:36Z | 2022-10-25T20:17:36Z | OWNER | Now `mypy` is failing: ``` sqlite_utils/db.py:474: error: Item "None" of "Optional[Any]" has no attribute "execute" sqlite_utils/db.py:476: error: Item "None" of "Optional[Any]" has no attribute "execute" sqlite_utils/db.py:486: error: Item "None" of "Optional[Any]" has no attribute "executescript" sqlite_utils/db.py:603: error: Item "None" of "Optional[Any]" has no attribute "__enter__" sqlite_utils/db.py:603: error: Item "None" of "Optional[Any]" has no attribute "__exit__" sqlite_utils/db.py:604: error: Item "None" of "Optional[Any]" has no attribute "execute" sqlite_utils/db.py:607: error: Item "None" of "Optional[Any]" has no attribute "execute" sqlite_utils/db.py:1082: error: Item "None" of "Optional[Any]" has no attribute "__enter__" sqlite_utils/db.py:1082: error: Item "None" of "Optional[Any]" has no attribute "__exit__" sqlite_utils/db.py:1083: error: Item "None" of "Optional[Any]" has no attribute "cursor" sqlite_utils/db.py:1155: error: Item "None" of "Optional[Any]" has no attribute "enable_load_extension" sqlite_utils/db.py:1156: error: Item "None" of "Optional[Any]" has no attribute "load_extension" Found 12 errors in 1 file (checked 51 source files) ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291093581 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291093581 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9IZN | simonw 9599 | 2022-10-25T20:23:00Z | 2022-10-25T20:23:00Z | OWNER | I'm not hugely happy with my fix there: https://github.com/simonw/sqlite-utils/blob/c5d7ec1dd71fa1dce829bc8bb82b639018befd63/sqlite_utils/db.py#L321-L328 The problem here was that in the case where the `os.remove()` failed the `self.conn` property was NOT being set to a valid connection - which caused `__repr__` to fail later on. So now I catch the `os.remove()` error, set `self.conn` to a memory connection, then raise the error again. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291103021 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291103021 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9Kst | simonw 9599 | 2022-10-25T20:32:01Z | 2022-10-25T20:32:01Z | OWNER | This test reliably fails on Windows with Python 3.11. I'm going to skip the test for the moment to get back to green CI... but I'll leave this issue open. This is definitely concerning, I just don't have the right local environment to solve this at the moment. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291111357 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291111357 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9Mu9 | simonw 9599 | 2022-10-25T20:36:06Z | 2022-10-25T20:36:06Z | OWNER | ... or maybe Windows doesn't like attempts to remove a file that the process has opened? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291115986 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291115986 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9N3S | simonw 9599 | 2022-10-25T20:39:24Z | 2022-10-25T20:39:24Z | OWNER | Used `psutil` to confirm that closing a SQLite connection closes the underlying file: https://til.simonwillison.net/python/too-many-open-files-psutil ```pycon >>> import psutil >>> import sqlite3 >>> for f in psutil.Process().open_files(): print(f) ... >>> sqlite3.connect("/tmp/blah.db") <sqlite3.Connection object at 0x1007264d0> >>> conn = _ >>> for f in psutil.Process().open_files(): print(f) ... popenfile(path='/private/tmp/blah.db', fd=3) >>> conn.close() >>> for f in psutil.Process().open_files(): print(f) ... >>> ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291122389 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291122389 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9PbV | simonw 9599 | 2022-10-25T20:45:43Z | 2022-10-25T20:45:43Z | OWNER | That fixed it. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 | |
| 1291124413 | https://github.com/simonw/sqlite-utils/issues/503#issuecomment-1291124413 | https://api.github.com/repos/simonw/sqlite-utils/issues/503 | IC_kwDOCGYnMM5M9P69 | simonw 9599 | 2022-10-25T20:47:34Z | 2022-10-25T20:47:34Z | OWNER | TIL about this: https://til.simonwillison.net/python/os-remove-windows | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | test_recreate failing on Windows Python 3.11 1423000702 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] (
[html_url] TEXT,
[issue_url] TEXT,
[id] INTEGER PRIMARY KEY,
[node_id] TEXT,
[user] INTEGER REFERENCES [users]([id]),
[created_at] TEXT,
[updated_at] TEXT,
[author_association] TEXT,
[body] TEXT,
[reactions] TEXT,
[issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
ON [issue_comments] ([user]);