issue_comments

Table actions

4 rows where issue = 1529707837

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1379492499 https://github.com/simonw/datasette/issues/1988#issuecomment-1379492499 https://api.github.com/repos/simonw/datasette/issues/1988 IC_kwDOBm6k_c5SOWKT simonw 9599 2023-01-11T21:15:01Z 2023-01-11T21:20:14Z OWNER This is tricky. `datasette-template-sql` registers a custom `sql()` function, but @cldellow spotted a situation where this would interfere with an existing `{{ sql }}` variable in a template context! https://github.com/simonw/datasette-template-sql/blob/70483fd94bb0349761830e37c9ab928e8966841a/datasette_template_sql/__init__.py ```python @hookimpl def extra_template_vars(datasette): async def execute_sql(sql, args=None, database=None): db = datasette.get_database(database) return (await db.execute(sql, args)).rows return {"sql": execute_sql} ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Reconsider pattern where plugins could break existing template context 1529707837  
1379495504 https://github.com/simonw/datasette/issues/1988#issuecomment-1379495504 https://api.github.com/repos/simonw/datasette/issues/1988 IC_kwDOBm6k_c5SOW5Q simonw 9599 2023-01-11T21:18:00Z 2023-01-11T21:18:25Z OWNER A few options: - Ensure that the explicit template context overrides anything that plugins might do - so in this case the `sql(...)` function would not be available on that page. This would break people who have custom templates that use that function though. - Encourage naming conventions where functions and variables from plugins are less likely to interfere with existing functionality. - Completely change how templates work, so you never have a variable called `{{ sql }}` - it is always accessed via some parent object instead, such as `{{ page.sql }}`. That last option actually fits quite well with my efforts to unify template rendering with JSON (and JSON extras) so it might be the best way to address this. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Reconsider pattern where plugins could break existing template context 1529707837  
1379500131 https://github.com/simonw/datasette/issues/1988#issuecomment-1379500131 https://api.github.com/repos/simonw/datasette/issues/1988 IC_kwDOBm6k_c5SOYBj simonw 9599 2023-01-11T21:22:31Z 2023-01-11T21:22:31Z OWNER Relevant code: https://github.com/simonw/datasette/blob/6a352e99ab988dbf8fd22a100049caa6ad33f1ec/datasette/app.py#L1138-L1149 https://github.com/simonw/datasette/blob/6a352e99ab988dbf8fd22a100049caa6ad33f1ec/datasette/app.py#L1193-L1195 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Reconsider pattern where plugins could break existing template context 1529707837  
1379502161 https://github.com/simonw/datasette/issues/1988#issuecomment-1379502161 https://api.github.com/repos/simonw/datasette/issues/1988 IC_kwDOBm6k_c5SOYhR simonw 9599 2023-01-11T21:24:24Z 2023-01-11T21:25:05Z OWNER Renaming `sql()` to `template_sql()` in https://github.com/simonw/datasette-template-sql and shipping a 2.0 release of that plugin (it is currently at 1.0.2) would be a sensible short-term fix too. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Reconsider pattern where plugins could break existing template context 1529707837  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);