issue_comments
9 rows where issue = 1907765514
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
| id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| 1730312128 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730312128 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nInfA | simonw 9599 | 2023-09-21T21:15:11Z | 2023-09-21T21:15:11Z | OWNER | As soon as `datasette publish cloudrun` has this I can re-enable this bit of the demo deploy: https://github.com/simonw/datasette/blob/2da1a6acec915b81a16127008fd739c7d6075681/.github/workflows/deploy-latest.yml#L91-L97 Which should fix this broken demo from https://simonwillison.net/2022/Dec/2/datasette-write-api/ https://todomvc.datasette.io/ | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730313565 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730313565 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nIn1d | simonw 9599 | 2023-09-21T21:16:31Z | 2023-09-21T21:16:31Z | OWNER | The `@add_common_publish_arguments_and_options` decorator described here is bad. If I update it to support a new `config` option all plugins that use it will break. https://github.com/simonw/datasette/blob/f130c7c0a88e50cea4121ea18d1f6db2431b6fab/docs/plugin_hooks.rst#L347-L355 I want to deprecate it and switch to a different, better design to address the same problem. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730437237 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730437237 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nJGB1 | simonw 9599 | 2023-09-21T22:36:22Z | 2023-09-21T22:36:22Z | OWNER | I think the actual design of this is pretty simple. Current help starts like this: ``` Usage: datasette publish cloudrun [OPTIONS] [FILES]... Publish databases to Datasette running on Cloud Run Options: -m, --metadata FILENAME Path to JSON/YAML file containing metadata to publish --extra-options TEXT Extra options to pass to datasette serve ``` The `-s` and `-c` short options are not being used. So I think `-c/--config` can point to a JSON or YAML `datasette.yaml` file, and `-s/--setting key value` can mirror the new `-s/--setting` option in `datasette serve` itself (a shortcut for populating the config file directly from the CLI). Here's the relevant help section from `datasette serve`: ``` -m, --metadata FILENAME Path to JSON/YAML file containing license/source metadata -c, --config FILENAME Path to JSON/YAML Datasette configuration file -s, --setting SETTING... nested.key, value setting to use in Datasette configuration ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730437934 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730437934 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nJGMu | simonw 9599 | 2023-09-21T22:37:22Z | 2023-09-21T22:37:22Z | OWNER | Here's the full help for Cloud Run at the moment: ```bash datasette publish cloudrun --help ``` ``` Usage: datasette publish cloudrun [OPTIONS] [FILES]... Publish databases to Datasette running on Cloud Run Options: -m, --metadata FILENAME Path to JSON/YAML file containing metadata to publish --extra-options TEXT Extra options to pass to datasette serve --branch TEXT Install datasette from a GitHub branch e.g. main --template-dir DIRECTORY Path to directory containing custom templates --plugins-dir DIRECTORY Path to directory containing custom plugins --static MOUNT:DIRECTORY Serve static files from this directory at /MOUNT/... --install TEXT Additional packages (e.g. plugins) to install --plugin-secret <TEXT TEXT TEXT>... Secrets to pass to plugins, e.g. --plugin- secret datasette-auth-github client_id xxx --version-note TEXT Additional note to show on /-/versions --secret TEXT Secret used for signing secure values, such as signed cookies --title TEXT Title for metadata --license TEXT License label for metadata --license_url TEXT License URL for metadata --source TEXT Source label for metadata --source_url TEXT Source URL for metadata --about TEXT About label for metadata --about_url TEXT About URL for metadata -n, --name TEXT Application name to use when building --service TEXT Cloud Run service to deploy (or over-write) --spatialite Enable SpatialLite extension --show-files … | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730438503 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730438503 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nJGVn | simonw 9599 | 2023-09-21T22:38:10Z | 2023-09-21T22:38:10Z | OWNER | I'd really like to remove `--extra-options`. I think the new design makes that completely obsolete? Maybe it doesn't. You still need `--extra-options` for the `--crossdb` option for example. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730441613 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730441613 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nJHGN | simonw 9599 | 2023-09-21T22:42:12Z | 2023-09-21T22:42:12Z | OWNER | https://github.com/search?q=datasette+publish+extra-options+language%3AShell&type=code&l=Shell shows 17 matches, I'll copy in illustrative examples here: ``` --extra-options="--setting sql_time_limit_ms 5000" --extra-options="--config default_cache_ttl:3600 --config hash_urls:1" --extra-options "--setting sql_time_limit_ms 3500 --setting default_page_size 20 --setting trace_debug 1" --extra-options="--config default_page_size:50 --config sql_time_limit_ms:30000 --config facet_time_limit_ms:10000" --extra-options="--setting sql_time_limit_ms 5000" --extra-options "--setting suggest_facets off --setting allow_download on --setting truncate_cells_html 0 --setting max_csv_mb 0 --setting sql_time_limit_ms 2000" ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730446937 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730446937 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nJIZZ | simonw 9599 | 2023-09-21T22:46:42Z | 2023-09-21T22:46:52Z | OWNER | Found more when I [searched for YAML](https://github.com/search?q=datasette+publish+extra-options++language%3AYAML&type=code). Here's the most interesting: https://github.com/labordata/warehouse/blob/0029a72fc1ceae9091932da6566f891167179012/.github/workflows/build.yml#L59 `--extra-options="--crossdb --setting sql_time_limit_ms 100000 --cors --setting facet_time_limit_ms 500 --setting allow_facet off --setting trace_debug 1"` Uses both `--cors` and `--crossdb`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730457374 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730457374 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nJK8e | simonw 9599 | 2023-09-21T22:56:18Z | 2023-09-21T22:56:18Z | OWNER | Maybe I should add `--cors` and `--crossdb` to `datasette publish cloudrun` as well? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 | |
| 1730458954 | https://github.com/simonw/datasette/issues/2195#issuecomment-1730458954 | https://api.github.com/repos/simonw/datasette/issues/2195 | IC_kwDOBm6k_c5nJLVK | simonw 9599 | 2023-09-21T22:57:39Z | 2023-09-21T22:57:48Z | OWNER | Worth noting that it already sets `--cors` automatically without you needing to specify it: https://github.com/simonw/datasette/blob/d97e82df3c8a3f2e97038d7080167be9bb74a68d/datasette/utils/__init__.py#L374-L374 I wonder if that's actually surprising behaviour that we should change before 1.0. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `datasette publish` needs support for the new config/metadata split 1907765514 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] (
[html_url] TEXT,
[issue_url] TEXT,
[id] INTEGER PRIMARY KEY,
[node_id] TEXT,
[user] INTEGER REFERENCES [users]([id]),
[created_at] TEXT,
[updated_at] TEXT,
[author_association] TEXT,
[body] TEXT,
[reactions] TEXT,
[issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
ON [issue_comments] ([user]);