issue_comments

Table actions

7 rows where issue = 432636432

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, author_association, created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
482628978 https://github.com/simonw/datasette/issues/429#issuecomment-482628978 https://api.github.com/repos/simonw/datasette/issues/429 MDEyOklzc3VlQ29tbWVudDQ4MjYyODk3OA== simonw 9599 2019-04-12T16:00:04Z 2019-04-12T16:00:04Z OWNER I originally thought of this as a plugin but then realized that it's 100% compatible with Datasette's existing arbitrary SQL clauses and would make some of my other projects (especially involving custom queries that still need faceting) a whole lot easier. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} ?_where=sql-fragment parameter for table views 432636432  
482638695 https://github.com/simonw/datasette/issues/429#issuecomment-482638695 https://api.github.com/repos/simonw/datasette/issues/429 MDEyOklzc3VlQ29tbWVudDQ4MjYzODY5NQ== simonw 9599 2019-04-12T16:29:25Z 2019-04-13T01:14:17Z OWNER Getting a prototype working was hardly any code at all: http://127.0.0.1:8001/fixtures/facetable?_where=city_id+in+(select+id+from+facet_cities+where+name+like+%22%25an%25%22) ``` diff --git a/datasette/views/table.py b/datasette/views/table.py index b7c9a4b..7ca9572 100644 --- a/datasette/views/table.py +++ b/datasette/views/table.py @@ -295,6 +295,10 @@ class TableView(RowTableShared): filters = Filters(sorted(other_args.items()), units, ureg) where_clauses, params = filters.build_where_clauses(table) + # Add _where= from querystring + if self.ds.config("allow_sql") and "_where" in request.args: + where_clauses.extend(request.args["_where"]) + # _search support: fts_table = special_args.get("_fts_table") fts_table = fts_table or table_metadata.get("fts_table") ``` Still needed: - [x] Unit tests - [x] Probably some kind of visual display on the table page so you know that extra clauses have been added (and maybe a UI for dropping them again) I'm going to leave the `:named` parameter support out of the first version of this feature. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} ?_where=sql-fragment parameter for table views 432636432  
482640079 https://github.com/simonw/datasette/issues/429#issuecomment-482640079 https://api.github.com/repos/simonw/datasette/issues/429 MDEyOklzc3VlQ29tbWVudDQ4MjY0MDA3OQ== simonw 9599 2019-04-12T16:34:01Z 2019-04-12T16:34:01Z OWNER UI concept: <img width="681" alt="fixtures__facetable__10_rows" src="https://user-images.githubusercontent.com/9599/56052339-ff3e3f80-5d05-11e9-89b2-8c37056c254f.png"> ``` <h3>1 extra where clause:</h3> <p><code>city_id in (select id from facet_cities where name like "%an%")</code> [<a href="#">remove</a>]</p> ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} ?_where=sql-fragment parameter for table views 432636432  
482640250 https://github.com/simonw/datasette/issues/429#issuecomment-482640250 https://api.github.com/repos/simonw/datasette/issues/429 MDEyOklzc3VlQ29tbWVudDQ4MjY0MDI1MA== simonw 9599 2019-04-12T16:34:32Z 2019-04-12T16:34:32Z OWNER Keeping track of these and building the "remove" links correctly is going to be a tiny bit fiddly. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} ?_where=sql-fragment parameter for table views 432636432  
482640383 https://github.com/simonw/datasette/issues/429#issuecomment-482640383 https://api.github.com/repos/simonw/datasette/issues/429 MDEyOklzc3VlQ29tbWVudDQ4MjY0MDM4Mw== simonw 9599 2019-04-12T16:34:56Z 2019-04-12T16:34:56Z OWNER Maybe put this section above the "view and edit SQL" link. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} ?_where=sql-fragment parameter for table views 432636432  
482766801 https://github.com/simonw/datasette/issues/429#issuecomment-482766801 https://api.github.com/repos/simonw/datasette/issues/429 MDEyOklzc3VlQ29tbWVudDQ4Mjc2NjgwMQ== simonw 9599 2019-04-13T01:56:19Z 2019-04-13T01:56:19Z OWNER Documentation is here: https://datasette.readthedocs.io/en/latest/json_api.html#special-table-arguments Demo: * https://latest.datasette.io/fixtures/facetable?_where=state=%22MI%22&_where=city_id=3 * https://latest.datasette.io/fixtures/facetable?_where=city_id%20in%20(select%20id%20from%20facet_cities%20where%20name%20!=%20%22Detroit%22) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} ?_where=sql-fragment parameter for table views 432636432  
483202658 https://github.com/simonw/datasette/issues/429#issuecomment-483202658 https://api.github.com/repos/simonw/datasette/issues/429 MDEyOklzc3VlQ29tbWVudDQ4MzIwMjY1OA== psychemedia 82988 2019-04-15T10:48:01Z 2019-04-15T10:48:01Z CONTRIBUTOR Minor UI observation: ![image](https://user-images.githubusercontent.com/82988/56127017-2bf78e80-5f74-11e9-9120-9393eb5d4988.png) `_where=` renders a `[remove]` link whereas `_facet=` gets a cross to remove it. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} ?_where=sql-fragment parameter for table views 432636432  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);