issue_comments

Table actions

8 rows where issue = 464449570

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
508769380 https://github.com/simonw/datasette/issues/540#issuecomment-508769380 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODc2OTM4MA== simonw 9599 2019-07-05T14:04:12Z 2019-07-05T14:04:12Z OWNER Need to figure out a sensible mobile version of this too. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  
508771246 https://github.com/simonw/datasette/issues/540#issuecomment-508771246 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODc3MTI0Ng== simonw 9599 2019-07-05T14:10:35Z 2019-07-05T14:10:35Z OWNER https://css-tricks.com/off-canvas-menu-with-css-target/ could be fun. See also https://medium.com/@heyoka/responsive-pure-css-off-canvas-hamburger-menu-aebc8d11d793 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  
508806571 https://github.com/simonw/datasette/issues/540#issuecomment-508806571 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODgwNjU3MQ== simonw 9599 2019-07-05T16:14:55Z 2019-07-05T16:14:55Z OWNER I think I'll start with something ridiculously simple along these lines: <img width="482" alt="fixtures__roadside_attraction_characteristics" src="https://user-images.githubusercontent.com/9599/60734589-4dc63900-9f05-11e9-8603-34ed50ad0005.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  
508819126 https://github.com/simonw/datasette/issues/540#issuecomment-508819126 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODgxOTEyNg== simonw 9599 2019-07-05T17:14:52Z 2019-07-05T17:14:52Z OWNER Having this be customized by a single plugin seems easy enough - define a named block region in the template, the plugin can then provide a template which extends the base template, over-rides the named block, adds some stuff, then calls [super](http://jinja.pocoo.org/docs/2.10/templates/#super-blocks) to include the default content. But... how would this work if there are multiple plugins that want to add to the menu area? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  
508827948 https://github.com/simonw/datasette/issues/540#issuecomment-508827948 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODgyNzk0OA== simonw 9599 2019-07-05T17:56:57Z 2019-07-05T17:56:57Z OWNER For the moment I'm going to ignore the multiple plugins case. I shall revisit that at some point in the future, once I actually have multiple plugins that want to be able to customize the navigation at the same time. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  
508858510 https://github.com/simonw/datasette/issues/540#issuecomment-508858510 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODg1ODUxMA== simonw 9599 2019-07-05T20:43:20Z 2019-07-05T20:43:20Z OWNER https://latest.datasette.io/fixtures/attraction_characteristic/1 now looks like this: <img width="790" alt="fixtures__attraction_characteristic" src="https://user-images.githubusercontent.com/9599/60744452-d60b0500-9f2a-11e9-8ac6-b35aaaf8120c.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  
508858729 https://github.com/simonw/datasette/issues/540#issuecomment-508858729 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODg1ODcyOQ== simonw 9599 2019-07-05T20:44:50Z 2019-07-05T20:44:50Z OWNER Here's an example custom `base.html` template that appears to have the desired effect: ```html+django {% extends "default:base.html" %} {% block extra_head %} <style type="text/css"> .hd .logout { float: right; text-align: right; padding-left: 1em; } </style> {% endblock %} {% block nav %} {{ super() }} <p class="logout"> <a href="/-/logout">Log out</a> </p> {% endblock %} ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  
508959470 https://github.com/simonw/datasette/issues/540#issuecomment-508959470 https://api.github.com/repos/simonw/datasette/issues/540 MDEyOklzc3VlQ29tbWVudDUwODk1OTQ3MA== simonw 9599 2019-07-06T23:11:35Z 2019-07-06T23:13:29Z OWNER This is now being used successfully by https://datasette-auth-demo.now.sh/ {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a universal navigation bar which can be modified by plugins 464449570  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);