issue_comments

Table actions

7 rows where issue = 577578306

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
596261835 https://github.com/simonw/datasette/issues/697#issuecomment-596261835 https://api.github.com/repos/simonw/datasette/issues/697 MDEyOklzc3VlQ29tbWVudDU5NjI2MTgzNQ== simonw 9599 2020-03-08T22:45:03Z 2020-03-08T22:45:03Z OWNER I think the bug is in this code: https://github.com/simonw/datasette/blob/7508477a96492caa1893c52411405656c50d30f9/datasette/app.py#L612-L623 I added some debug logging to it and found that the bit that returns the `plugin["templates_path"]` list is producing this: ``` plugin_template_paths: [ '/Users/simonw/Dropbox/Development/datasette/datasette/templates', '/Users/simonw/Dropbox/Development/datasette/datasette/templates', '/Users/simonw/Dropbox/Development/datasette-search-all/datasette_search_all/templates' ] ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} index.html is not reliably loaded from a plugin 577578306  
596261973 https://github.com/simonw/datasette/issues/697#issuecomment-596261973 https://api.github.com/repos/simonw/datasette/issues/697 MDEyOklzc3VlQ29tbWVudDU5NjI2MTk3Mw== simonw 9599 2020-03-08T22:46:47Z 2020-03-08T22:46:47Z OWNER More debugging code shows this: ``` [ ( { "name": "datasette.facets", "static_path": "/Users/simonw/Dropbox/Development/datasette/datasette/static", "templates_path": "/Users/simonw/Dropbox/Development/datasette/datasette/templates", }, "/Users/simonw/Dropbox/Development/datasette/datasette/templates", ), ( { "name": "datasette.sql_functions", "static_path": "/Users/simonw/Dropbox/Development/datasette/datasette/static", "templates_path": "/Users/simonw/Dropbox/Development/datasette/datasette/templates", }, "/Users/simonw/Dropbox/Development/datasette/datasette/templates", ), ( { "name": "datasette-search-all", "static_path": None, "templates_path": "/Users/simonw/Dropbox/Development/datasette-search-all/datasette_search_all/templates", "version": "0.1", }, "/Users/simonw/Dropbox/Development/datasette-search-all/datasette_search_all/templates", ), ] ``` So the problem is that the default plugins that ship with Datasette are adding a template path to the lookup list! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} index.html is not reliably loaded from a plugin 577578306  
596262118 https://github.com/simonw/datasette/issues/697#issuecomment-596262118 https://api.github.com/repos/simonw/datasette/issues/697 MDEyOklzc3VlQ29tbWVudDU5NjI2MjExOA== simonw 9599 2020-03-08T22:48:28Z 2020-03-08T22:48:28Z OWNER I think the bug is in this code: https://github.com/simonw/datasette/blob/7508477a96492caa1893c52411405656c50d30f9/datasette/utils/__init__.py#L619-L645 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} index.html is not reliably loaded from a plugin 577578306  
596262197 https://github.com/simonw/datasette/issues/697#issuecomment-596262197 https://api.github.com/repos/simonw/datasette/issues/697 MDEyOklzc3VlQ29tbWVudDU5NjI2MjE5Nw== simonw 9599 2020-03-08T22:49:15Z 2020-03-08T22:49:15Z OWNER I need that code to set `static_path` and `templates_path` to `None` for plugins that ship as part of Datasette. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} index.html is not reliably loaded from a plugin 577578306  
596264781 https://github.com/simonw/datasette/issues/697#issuecomment-596264781 https://api.github.com/repos/simonw/datasette/issues/697 MDEyOklzc3VlQ29tbWVudDU5NjI2NDc4MQ== simonw 9599 2020-03-08T23:17:01Z 2020-03-08T23:17:01Z OWNER I'm going to release this as 0.37.2. This is the first time I've released a version NOT from master (since I don't want to ship the `--memory` feature for Cloud Run until 0.38 - #694). So I've cut a `v0.37.2` release branch instead. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} index.html is not reliably loaded from a plugin 577578306  
596264937 https://github.com/simonw/datasette/issues/697#issuecomment-596264937 https://api.github.com/repos/simonw/datasette/issues/697 MDEyOklzc3VlQ29tbWVudDU5NjI2NDkzNw== simonw 9599 2020-03-08T23:18:48Z 2020-03-08T23:18:48Z OWNER Cancel that plan: I'm pretty sure the Travis configuration that publishes a demo to Zeit Now and builds a Docker image isn't designed to handle releases that don't correspond to current master. I guess I'll release 0.38 instead. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} index.html is not reliably loaded from a plugin 577578306  
596266233 https://github.com/simonw/datasette/issues/697#issuecomment-596266233 https://api.github.com/repos/simonw/datasette/issues/697 MDEyOklzc3VlQ29tbWVudDU5NjI2NjIzMw== simonw 9599 2020-03-08T23:33:28Z 2020-03-08T23:33:28Z OWNER Shipped in [Datasette 0.38](https://datasette.readthedocs.io/en/latest/changelog.html#v0-38). {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} index.html is not reliably loaded from a plugin 577578306  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);