issue_comments

Table actions

8 rows where issue = 603295970

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
629032425 https://github.com/simonw/datasette/issues/729#issuecomment-629032425 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYyOTAzMjQyNQ== simonw 9599 2020-05-15T05:17:09Z 2020-05-15T05:17:39Z OWNER Not sure the best way to do this. Here's an example using very subtle colour changes - but I'm worried it's not at all discoverable: <img width="673" alt="fixtures__sortable__201_rows" src="https://user-images.githubusercontent.com/9599/82014033-92942380-9630-11ea-846b-d117af7b3dde.png"> That's with `#4c0077` for floats and `#666666` for integers. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  
629032619 https://github.com/simonw/datasette/issues/729#issuecomment-629032619 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYyOTAzMjYxOQ== simonw 9599 2020-05-15T05:17:53Z 2020-05-15T05:18:29Z OWNER I like the gray. The purple is a bit confusing. I could have both integers and floats show up as gray? The floating point should help show which is which. Maybe I could default floating point columns with integer values in them to `11.0` just to make it clear that they are floats? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  
629033619 https://github.com/simonw/datasette/issues/729#issuecomment-629033619 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYyOTAzMzYxOQ== simonw 9599 2020-05-15T05:21:17Z 2020-05-15T05:21:30Z OWNER Turns out `1.0` and `2` stored in a float column already displays like that: ``` echo '[{"foo": 1.0, "bar": 1}, {"foo": 2, "bar": 2}]' | sqlite-utils insert /tmp/db.db t - ``` <img width="542" alt="db__t__2_rows" src="https://user-images.githubusercontent.com/9599/82014303-3382de80-9631-11ea-9d6b-9be1f178c8cb.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  
629033753 https://github.com/simonw/datasette/issues/729#issuecomment-629033753 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYyOTAzMzc1Mw== simonw 9599 2020-05-15T05:21:42Z 2020-05-15T05:21:51Z OWNER I'm going to make all integers AND floats show up as `#666666`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  
629042437 https://github.com/simonw/datasette/issues/729#issuecomment-629042437 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYyOTA0MjQzNw== simonw 9599 2020-05-15T05:52:39Z 2020-05-15T05:52:39Z OWNER `type-pk` is a more accurate name than `type-link` - since people might assume that `type-link` refers to columns containing a link or a URL or similar. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  
629043480 https://github.com/simonw/datasette/issues/729#issuecomment-629043480 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYyOTA0MzQ4MA== simonw 9599 2020-05-15T05:55:44Z 2020-05-15T05:55:44Z OWNER Live demo: https://latest.datasette.io/fixtures/sortable {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  
629050775 https://github.com/simonw/datasette/issues/729#issuecomment-629050775 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYyOTA1MDc3NQ== simonw 9599 2020-05-15T06:17:12Z 2020-05-15T06:17:12Z OWNER ![4F8D336A-ECEB-4C68-A859-C8A3DA546E9C](https://user-images.githubusercontent.com/9599/82017875-fae70300-9638-11ea-9cc2-3969299ae9a0.jpeg) I don't like how the column headers themselves are no longer black in mobile view. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  
630323870 https://github.com/simonw/datasette/issues/729#issuecomment-630323870 https://api.github.com/repos/simonw/datasette/issues/729 MDEyOklzc3VlQ29tbWVudDYzMDMyMzg3MA== simonw 9599 2020-05-18T17:20:02Z 2020-05-18T17:20:02Z OWNER Deployed here: https://covid-19.datasettes.com/covid/economist_excess_deaths - and it helped me spot a bug! The floating point numbers there were being treated as strings: <img width="818" alt="covid__economist_excess_deaths__2_559_rows" src="https://user-images.githubusercontent.com/9599/82241500-1f6d0480-98f1-11ea-9ce7-fa74bc449546.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Visually distinguish integer and text columns 603295970  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);