issue_comments

Table actions

6 rows where issue = 710506708

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
700313836 https://github.com/simonw/datasette/issues/978#issuecomment-700313836 https://api.github.com/repos/simonw/datasette/issues/978 MDEyOklzc3VlQ29tbWVudDcwMDMxMzgzNg== simonw 9599 2020-09-28T22:19:05Z 2020-09-28T22:19:05Z OWNER Looks like a bug in this function: https://github.com/simonw/datasette/blob/1f021c37110fc9019b0ef70062c28c335e568ae2/datasette/utils/__init__.py#L269-L274 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Rendering glitch with column headings on mobile 710506708  
700314509 https://github.com/simonw/datasette/issues/978#issuecomment-700314509 https://api.github.com/repos/simonw/datasette/issues/978 MDEyOklzc3VlQ29tbWVudDcwMDMxNDUwOQ== simonw 9599 2020-09-28T22:20:51Z 2020-09-28T22:20:51Z OWNER Here's the HTML for the broken example above: ```html <style> @media only screen and (max-width: 576px) { .rows-and-columns td:nth-of-type(1):before { content: "dateutil_parse(\2210 october 2020 3pm\22)"; } .rows-and-columns td:nth-of-type(2):before { content: "dateutil_easter(\222020\22)"; } .rows-and-columns td:nth-of-type(3):before { content: "dateutil_parse_fuzzy(\22This is due 10 september\22)"; } .rows-and-columns td:nth-of-type(4):before { content: "dateutil_parse(\221/2/2020\22)"; } .rows-and-columns td:nth-of-type(5):before { content: "dateutil_parse(\222020-03-04\22)"; } .rows-and-columns td:nth-of-type(6):before { content: "dateutil_parse_dayfirst(\222020-03-04\22)"; } .rows-and-columns td:nth-of-type(7):before { content: "dateutil_easter(2020)"; } } </style> ``` The glitch affects the ones where the quote is followed by digits. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Rendering glitch with column headings on mobile 710506708  
700316511 https://github.com/simonw/datasette/issues/978#issuecomment-700316511 https://api.github.com/repos/simonw/datasette/issues/978 MDEyOklzc3VlQ29tbWVudDcwMDMxNjUxMQ== simonw 9599 2020-09-28T22:26:38Z 2020-09-28T22:26:38Z OWNER The fix may be to use `\0022` instead of `\22`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Rendering glitch with column headings on mobile 710506708  
700317760 https://github.com/simonw/datasette/issues/978#issuecomment-700317760 https://api.github.com/repos/simonw/datasette/issues/978 MDEyOklzc3VlQ29tbWVudDcwMDMxNzc2MA== simonw 9599 2020-09-28T22:30:25Z 2020-09-28T22:30:25Z OWNER ```python print('\\' + "{:X}".format(ord('"')).zfill(4)) \0022 ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Rendering glitch with column headings on mobile 710506708  
700319656 https://github.com/simonw/datasette/issues/978#issuecomment-700319656 https://api.github.com/repos/simonw/datasette/issues/978 MDEyOklzc3VlQ29tbWVudDcwMDMxOTY1Ng== simonw 9599 2020-09-28T22:36:44Z 2020-09-28T22:36:44Z OWNER Weirdly even those leading 0s doesn't fix it: <img width="600" alt="Real-time_HTML_Editor_and_Using_character_escapes_in_markup_and_CSS" src="https://user-images.githubusercontent.com/9599/94492937-44775b00-01a0-11eb-9c5f-e991af620404.png"> But... padding to six characters does! See https://www.w3.org/International/questions/qa-escapes <img width="607" alt="Real-time_HTML_Editor_and_Using_character_escapes_in_markup_and_CSS" src="https://user-images.githubusercontent.com/9599/94492988-61139300-01a0-11eb-8304-bffe448c7d2b.png"> ``` In [32]: print('\\' + "{:X}".format(ord('"')).zfill(6)) \000022 ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Rendering glitch with column headings on mobile 710506708  
700320480 https://github.com/simonw/datasette/issues/978#issuecomment-700320480 https://api.github.com/repos/simonw/datasette/issues/978 MDEyOklzc3VlQ29tbWVudDcwMDMyMDQ4MA== simonw 9599 2020-09-28T22:39:18Z 2020-09-28T22:39:18Z OWNER ```python def escape_css_string(s): return _css_re.sub(lambda m: "\\" + ("{:X}".format(ord(m.group())).zfill(6)), s) ``` That fixes it: <img width="363" alt="data__select_dateutil_parse__10_october_2020_3pm____dateutil_easter__2020____dateutil_parse_fuzzy__This_is_due_10_september____dateutil_parse__1_2_2020____dateutil_parse__2020-03-04____dateutil_parse_dayfirst__2020-03-04____dateutil_easter_" src="https://user-images.githubusercontent.com/9599/94493173-c23b6680-01a0-11eb-9468-e972c51b015c.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Rendering glitch with column headings on mobile 710506708  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);