issue_comments
9 rows where issue = 771216293
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
| id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| 748356492 | https://github.com/simonw/datasette/issues/1155#issuecomment-748356492 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0ODM1NjQ5Mg== | simonw 9599 | 2020-12-18T22:49:32Z | 2020-12-22T01:13:05Z | OWNER | There's some messy code that needs fixing here. The `datasette.databases` dictionary right now has a key that corresponds to the `/_internal` URL in the path, and a value that's a `Database()` object. BUT... the `Database()` object doesn't know what its key is. While fixing this I should fix the issue where Datasette gets confused by multiple databases with the same stem: https://github.com/simonw/datasette/issues/509 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 748367922 | https://github.com/simonw/datasette/issues/1155#issuecomment-748367922 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0ODM2NzkyMg== | simonw 9599 | 2020-12-18T23:15:24Z | 2020-12-18T23:15:24Z | OWNER | The code for building up that `.databases` dictionary is a bit convoluted. Here's the code that adds a `:memory:` database if the user specified `--memory` OR if there are no files to be attached: https://github.com/simonw/datasette/blob/ebc7aa287c99fe6114b79aeab8efb8d4489a6182/datasette/app.py#L221-L241 I'm not sure why I wrote it this way, instead of just calling `.add_database(":memory:", Database(..., is_memory=True)`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 748368384 | https://github.com/simonw/datasette/issues/1155#issuecomment-748368384 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0ODM2ODM4NA== | simonw 9599 | 2020-12-18T23:17:00Z | 2020-12-18T23:17:00Z | OWNER | Here's the commit where I added it. https://github.com/simonw/datasette/commit/9743e1d91b5f0a2b3c1c0bd6ffce8739341f43c4 - I didn't yet have the `.add_database()` mechanism. Today the `MEMORY` object bit is no longer needed. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 748368660 | https://github.com/simonw/datasette/issues/1155#issuecomment-748368660 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0ODM2ODY2MA== | simonw 9599 | 2020-12-18T23:18:04Z | 2020-12-19T01:12:00Z | OWNER | A `Database` should have a `.name` which is unique across the Datasette instance and is used in the URL. The `path` should be optional, only set for file databases. A new `.memory_name` property can be used for shared memory databases. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 748368938 | https://github.com/simonw/datasette/issues/1155#issuecomment-748368938 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0ODM2ODkzOA== | simonw 9599 | 2020-12-18T23:19:04Z | 2020-12-18T23:19:04Z | OWNER | `Database` internal class is documented here: https://docs.datasette.io/en/latest/internals.html#database-class | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 748397998 | https://github.com/simonw/datasette/issues/1155#issuecomment-748397998 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0ODM5Nzk5OA== | simonw 9599 | 2020-12-19T01:28:18Z | 2020-12-19T01:28:18Z | OWNER | `datasette-graphql` returns an error due to this issue: <img width="878" alt="GraphiQL_and_fixtures__compound_three_primary_keys__1_001_rows" src="https://user-images.githubusercontent.com/9599/102677257-61e01380-4156-11eb-8f88-fe26b9c4a40b.png"> On the console: ``` INFO: 127.0.0.1:63116 - "POST /graphql/_internal HTTP/1.1" 500 Internal Server Error Traceback (most recent call last): File "/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.8/site-packages/promise/promise.py", line 844, in handle_future_result resolve(future.result()) File "/Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.8/site-packages/datasette_graphql/utils.py", line 603, in resolve_table data, _, _ = await view.data( File "/Users/simon/Dropbox/Development/datasette/datasette/views/table.py", line 304, in data db = self.ds.databases[database] graphql.error.located_error.GraphQLLocatedError: ':memory:c6dd5abe1a757a7de00d99b699175bd33d9a575f05b5751bf856b8656fb07edd' ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 749170608 | https://github.com/simonw/datasette/issues/1155#issuecomment-749170608 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0OTE3MDYwOA== | simonw 9599 | 2020-12-21T20:01:47Z | 2020-12-21T20:01:47Z | OWNER | I removed that `MEMORY` object() in dcdfb2c301341d45b66683e3e3be72f9c7585b2f | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 749176936 | https://github.com/simonw/datasette/issues/1155#issuecomment-749176936 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0OTE3NjkzNg== | simonw 9599 | 2020-12-21T20:18:15Z | 2020-12-21T20:18:15Z | OWNER | Fun query: ```sql select table_name, group_concat(name, ', ') from columns group by database_name, table_name ``` https://latest.datasette.io/_internal?sql=select+table_name%2C+group_concat%28name%2C+%27%2C+%27%29+from+columns+group+by+database_name%2C+table_name | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 | |
| 749723557 | https://github.com/simonw/datasette/issues/1155#issuecomment-749723557 | https://api.github.com/repos/simonw/datasette/issues/1155 | MDEyOklzc3VlQ29tbWVudDc0OTcyMzU1Nw== | simonw 9599 | 2020-12-22T19:08:27Z | 2020-12-22T19:08:27Z | OWNER | I'm going to have the `.add_database()` method select the name used in the path, de-duping against any existing names. It will then set database.name to that so that the database has access to its own name. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better internal database_name for _internal database 771216293 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] (
[html_url] TEXT,
[issue_url] TEXT,
[id] INTEGER PRIMARY KEY,
[node_id] TEXT,
[user] INTEGER REFERENCES [users]([id]),
[created_at] TEXT,
[updated_at] TEXT,
[author_association] TEXT,
[body] TEXT,
[reactions] TEXT,
[issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
ON [issue_comments] ([user]);