issue_comments

Table actions

9 rows where issue = 780267857

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
755156606 https://github.com/simonw/datasette/issues/1178#issuecomment-755156606 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTE1NjYwNg== simonw 9599 2021-01-06T08:21:49Z 2021-01-06T08:21:49Z OWNER https://github.com/simonw/datasette-export-notebook/blob/aec398eab4f34791d240d7bc47b6eec575b357be/datasette_export_notebook/__init__.py#L18-L23 Maybe this is a bug in `datasette.absolute_url`? Perhaps it doesn't take the scheme into account. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755157066 https://github.com/simonw/datasette/issues/1178#issuecomment-755157066 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTE1NzA2Ng== simonw 9599 2021-01-06T08:22:47Z 2021-01-06T08:22:47Z OWNER Weird... https://github.com/simonw/datasette/blob/a882d679626438ba0d809944f06f239bcba8ee96/datasette/app.py#L609-L613 ```python def absolute_url(self, request, path): url = urllib.parse.urljoin(request.url, path) if url.startswith("http://") and self.setting("force_https_urls"): url = "https://" + url[len("http://") :] return url ``` That looks like it should work. Needs more digging. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755157281 https://github.com/simonw/datasette/issues/1178#issuecomment-755157281 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTE1NzI4MQ== simonw 9599 2021-01-06T08:23:14Z 2021-01-06T08:23:14Z OWNER https://latest-with-plugins.datasette.io/-/settings says `"force_https_urls": false` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755157732 https://github.com/simonw/datasette/issues/1178#issuecomment-755157732 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTE1NzczMg== simonw 9599 2021-01-06T08:24:12Z 2021-01-06T08:24:12Z OWNER https://latest-with-plugins.datasette.io/fixtures/sortable.json has the bug too - the `next_url` is `http://` when it should be `https://`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755158310 https://github.com/simonw/datasette/issues/1178#issuecomment-755158310 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTE1ODMxMA== simonw 9599 2021-01-06T08:25:31Z 2021-01-06T08:25:31Z OWNER Moving this to the Datasette repo. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755160187 https://github.com/simonw/datasette/issues/1178#issuecomment-755160187 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTE2MDE4Nw== simonw 9599 2021-01-06T08:29:35Z 2021-01-06T08:29:35Z OWNER https://latest-with-plugins.datasette.io/-/asgi-scope ``` {'asgi': {'spec_version': '2.1', 'version': '3.0'}, 'client': ('169.254.8.129', 54971), 'headers': [(b'host', b'latest-with-plugins.datasette.io'), (b'user-agent', b'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:84.0) Gecko' b'/20100101 Firefox/84.0'), (b'accept', b'text/html,application/xhtml+xml,application/xml;q=0.9,image/' b'webp,*/*;q=0.8'), (b'accept-language', b'en-US,en;q=0.5'), (b'dnt', b'1'), (b'cookie', b'_ga_LL6M7BK6D4=GS1.1.1609886546.49.1.1609886923.0; _ga=GA1.1' b'.894633707.1607575712'), (b'upgrade-insecure-requests', b'1'), (b'x-client-data', b'CgSL6ZsV'), (b'x-cloud-trace-context', b'e776af843c657d2a3da28a73b726e6fe/14187666787557102189;o=1'), (b'x-forwarded-for', b'148.64.98.14'), (b'x-forwarded-proto', b'https'), (b'forwarded', b'for="148.64.98.14";proto=https'), (b'accept-encoding', b'gzip, deflate, br'), (b'content-length', b'0')], 'http_version': '1.1', 'method': 'GET', 'path': '/-/asgi-scope', 'query_string': b'', 'raw_path': b'/-/asgi-scope', 'root_path': '', 'scheme': 'http', 'server': ('169.254.8.130', 8080), 'type': 'http'} ``` Note the `'scheme': 'http'` but also the `(b'x-forwarded-proto', b'https')`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755163886 https://github.com/simonw/datasette/issues/1178#issuecomment-755163886 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTE2Mzg4Ng== simonw 9599 2021-01-06T08:37:51Z 2021-01-06T08:37:51Z OWNER Easiest fix would be for `publish cloudrun` to set `force_https_urls`: `datasette publish now` used to do this: https://github.com/simonw/datasette/blob/07e208cc6d9e901b87552c1be2854c220b3f9b6d/datasette/publish/now.py#L59-L63 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755468795 https://github.com/simonw/datasette/issues/1178#issuecomment-755468795 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTQ2ODc5NQ== simonw 9599 2021-01-06T18:14:35Z 2021-01-06T18:14:35Z OWNER Deploying that change now to test it. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  
755476820 https://github.com/simonw/datasette/issues/1178#issuecomment-755476820 https://api.github.com/repos/simonw/datasette/issues/1178 MDEyOklzc3VlQ29tbWVudDc1NTQ3NjgyMA== simonw 9599 2021-01-06T18:24:47Z 2021-01-06T18:24:47Z OWNER Issue fixed - https://latest-with-plugins.datasette.io/github/issue_comments.Notebook?_labels=on displays the correct schemes now. I can't think of a reason anyone on Cloud Run would ever NOT want the `force_https_urls` option, but just in case I've made it so if you pass `--extra-options --setting force_https_urls off` to `publish cloudrun` your setting will be respected. https://github.com/simonw/datasette/blob/97fb10c17dd007a275ab743742e93e932335ad67/datasette/publish/cloudrun.py#L105-L110 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use force_https_urls on when deploying with Cloud Run 780267857  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);