github: issue_comments: 3 rows where issue = 783778672

3 rows where issue = 783778672

Search:

descending

id ▼	html_url	issue_url	node_id	user	created_at	updated_at	author_association	body	reactions	issue
759098964	https://github.com/simonw/sqlite-utils/issues/220#issuecomment-759098964	https://api.github.com/repos/simonw/sqlite-utils/issues/220	MDEyOklzc3VlQ29tbWVudDc1OTA5ODk2NA==	simonw 9599	2021-01-12T23:19:55Z	2021-01-12T23:19:55Z	OWNER	I don't think it makes sense to call `.enable_fts()` on a view does it? When I'm working with views and FTS I tend to write my queries against a FTS table for one of the tables that is used by the view - https://docs.datasette.io/en/stable/full_text_search.html#configuring-full-text-search-for-a-table-or-view describes how I do that in Datasette for example. Can you expand on your use-case for FTS and views? I'm ready to be convinced otherwise, but I don't see how it would work right now.	{"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}	Better error message for _fts methods against views 783778672*
761015218	https://github.com/simonw/sqlite-utils/issues/220#issuecomment-761015218	https://api.github.com/repos/simonw/sqlite-utils/issues/220	MDEyOklzc3VlQ29tbWVudDc2MTAxNTIxOA==	mhalle 649467	2021-01-15T15:40:08Z	2021-01-15T15:40:08Z	NONE	Make sense. If you're coming from the sqlite3 side of things, rather than the datasette side, wanting the fts methods to work for views makes more sense. sqlite3 allows fts5 tables on views, so I was looking for CLI functionality to build the fts virtual tables. Ultimately, though, sharing fts virtual tables across tables and derivative views is likely more efficient. Maybe an explicit error message like, "fts is not supported for views" rather than just throwing an exception that the method doesn't exist" might be helpful. Not critical though. Thanks.	{"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}	Better error message for _fts methods against views 783778672*
783662968	https://github.com/simonw/sqlite-utils/issues/220#issuecomment-783662968	https://api.github.com/repos/simonw/sqlite-utils/issues/220	MDEyOklzc3VlQ29tbWVudDc4MzY2Mjk2OA==	mhalle 649467	2021-02-22T20:44:51Z	2021-02-22T20:44:51Z	NONE	Actually, coming back to this, I have a clearer use case for enabling fts generation for views: making it easier to bring in text from lookup tables and other joins. The datasette documentation describes populating an fts table like so: ``` INSERT INTO "items_fts" (rowid, name, description, category_name) SELECT items. rowid, items.name, items.description, categories.name FROM items JOIN categories ON items.category_id=categories.id; ``` Alternatively if you have fts support in sqlite_utils for views (which sqlite and fts5 support), you can do the same thing just by creating a view that captures the above joins as columns, then creating an fts table from that view. Such an fts table can be created using sqlite_utils, where one created with your method can't. The resulting fts table can then be used by a whole family of related tables and views in the manner you described earlier in this issue.	{"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}	Better error message for _fts methods against views 783778672*

Advanced export

JSON shape: default, array, newline-delimited, object

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);