issue_comments

Table actions

3 rows where issue = 817597268

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
786840425 https://github.com/simonw/datasette/issues/1246#issuecomment-786840425 https://api.github.com/repos/simonw/datasette/issues/1246 MDEyOklzc3VlQ29tbWVudDc4Njg0MDQyNQ== simonw 9599 2021-02-26T19:11:56Z 2021-02-26T19:11:56Z OWNER Relevant code: https://github.com/simonw/datasette/blob/afed51b1e36cf275c39e71c7cb262d6c5bdbaa31/datasette/facets.py#L271-L295 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Suggest for ArrayFacet possibly confused by blank values 817597268  
786840734 https://github.com/simonw/datasette/issues/1246#issuecomment-786840734 https://api.github.com/repos/simonw/datasette/issues/1246 MDEyOklzc3VlQ29tbWVudDc4Njg0MDczNA== simonw 9599 2021-02-26T19:12:39Z 2021-02-26T19:12:47Z OWNER Could I take this part: ```python suggested_facet_sql = """ select distinct json_type({column}) from ({sql}) """.format( column=escape_sqlite(column), sql=self.sql ) ``` And add `where {column} is not null and {column} != ''` perhaps? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Suggest for ArrayFacet possibly confused by blank values 817597268  
787611153 https://github.com/simonw/datasette/issues/1246#issuecomment-787611153 https://api.github.com/repos/simonw/datasette/issues/1246 MDEyOklzc3VlQ29tbWVudDc4NzYxMTE1Mw== simonw 9599 2021-03-01T03:30:57Z 2021-03-01T03:30:57Z OWNER I'm going to try a new pattern for testing this, enabled by #1151 - the test will create a new named in-memory database, write some records to it and then run some test facets against that. This will save me from having to add yet another fixtures table for this. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Suggest for ArrayFacet possibly confused by blank values 817597268  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);