home / github

Menu
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

10 rows where issue = 965143346

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, author_association, created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
896154028 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896154028 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41ajms simonw 9599 2021-08-10T17:01:06Z 2021-08-10T17:01:06Z OWNER On Python 3.6: ``` sqlite_utils/db.py:366: in Database def tables(self) -> List[Table]: E NameError: name 'Table' is not defined ``` Python 3.7 can fix this with `from __future__ import annotations` but since we still support 3.6 I'll have to use a string instead. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896156971 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896156971 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41akUr simonw 9599 2021-08-10T17:04:22Z 2021-08-10T17:05:59Z OWNER I'm going to get Read The Docs to build the docs for this branch too - on https://readthedocs.org/projects/sqlite-utils/versions/ I am clicking this button: <img width="881" alt="Versions___Read_the_Docs" src="https://user-images.githubusercontent.com/9599/128903015-0f2649e7-34a8-4dfd-984c-b1b5bd8a98be.png"> I then set it to "active" (so pushes to the branch will build it) and "hidden" (so it wouldn't show up in search or in the navigation menu). https://docs.readthedocs.io/en/stable/versions.html#version-states <img width="846" alt="autodoc_-_sqlite-utils___Read_the_Docs" src="https://user-images.githubusercontent.com/9599/128903217-efe827c6-4f54-42dd-943e-ddf9ab3a05d8.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896162082 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896162082 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41alki codecov[bot] 22429695 2021-08-10T17:10:39Z 2021-08-10T23:07:35Z NONE # [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#312](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (43bc064) into [main](https://codecov.io/gh/simonw/sqlite-utils/commit/ee469e3122d6f5973ec2584c1580d930daca2e7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (ee469e3) will **decrease** coverage by `0.02%`. > The diff coverage is `96.84%`. [![Impacted file tree graph](https://codecov.io/gh/simonw/sqlite-utils/pull/312/graphs/tree.svg?width=650&height=150&src=pr&token=O0X3703L9P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #312 +/- ## ========================================== - Coverage 96.30% 96.28% -0.03% ========================================== Files 5 5 Lines 2168 2179 +11 ========================================== + Hits 2088 2098 +10 - Misses 80 81 +1 ``` | [Impacted Files](https://codecov.io/gh/simonw/sqlite-utils/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [sqlite\_utils/db.py](https://codecov.io/gh/simonw/sqlite-utils/pull/312/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-c3FsaXRlX3V0aWxzL2RiLnB5) | `97.91% <96.84%> (-0.08%)` … {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896174456 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896174456 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41aol4 simonw 9599 2021-08-10T17:27:01Z 2021-08-10T17:27:01Z OWNER Docs are now building at https://sqlite-utils.datasette.io/en/autodoc/reference.html But there's a problem! The page is semi-blank: <img width="663" alt="Reference_—_sqlite-utils_3_15-6-gc11ff89_documentation" src="https://user-images.githubusercontent.com/9599/128906373-7463e0c9-3b08-4b15-a73a-84b8ba6ab342.png"> I need to teach Read The Docs how to ensure `sqlite_utils` is available for introspection. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896175438 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896175438 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41ao1O simonw 9599 2021-08-10T17:28:19Z 2021-08-10T17:28:19Z OWNER https://sphinx-rtd-tutorial.readthedocs.io/en/latest/sphinx-config.html#autodoc-configuration says do something like this at the top of `conf.py`: ```python import os import sys sys.path.insert(0, os.path.abspath('../../simpleble/')) ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896180956 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896180956 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41aqLc simonw 9599 2021-08-10T17:35:51Z 2021-08-10T17:35:51Z OWNER Reading the rest of https://sphinx-rtd-tutorial.readthedocs.io/en/latest/sphinx-config.html#autodoc-configuration it suggests using a `requirements.txt` file to install dependencies - but I use `setup.py` for that so I need to figure out a different pattern here. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896182934 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896182934 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41aqqW simonw 9599 2021-08-10T17:38:44Z 2021-08-10T17:38:44Z OWNER From https://docs.readthedocs.io/en/stable/config-file/v2.html#packages it looks like I can tell Read The Docs to run `pip install -e .` using a `.readthedocs.yaml` configuration: ```yaml version: 2 sphinx: configuration: docs/conf.py python: version: "3.9" install: - method: pip path: . extra_requirements: - docs ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896186025 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896186025 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41arap simonw 9599 2021-08-10T17:42:51Z 2021-08-10T17:42:51Z OWNER That worked! https://sqlite-utils.datasette.io/en/autodoc/reference.html {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896200682 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896200682 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41au_q simonw 9599 2021-08-10T18:03:40Z 2021-08-10T18:03:40Z OWNER Adding type signatures to `create_table()` and `.create_table_sql()` is a bit too involved, I'll do that in a separate issue. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  
896284722 https://github.com/simonw/sqlite-utils/pull/312#issuecomment-896284722 https://api.github.com/repos/simonw/sqlite-utils/issues/312 IC_kwDOCGYnMM41bDgy simonw 9599 2021-08-10T20:08:03Z 2021-08-10T20:08:21Z OWNER Spotted a rogue backtick: ![A0147E27-7506-49B0-BEFB-20D99BBFEBAD](https://user-images.githubusercontent.com/9599/128927930-b3333dee-a385-409b-a945-f108e6ea40df.jpeg) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add reference page to documentation using Sphinx autodoc 965143346  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 90.153ms · About: simonw/datasette-graphql