home / github

Menu
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

36 rows where "updated_at" is on date 2022-01-20

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, author_association, reactions, issue, updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1016639294 https://github.com/simonw/datasette/issues/1601#issuecomment-1016639294 https://api.github.com/repos/simonw/datasette/issues/1601 IC_kwDOBm6k_c48mK8- simonw 9599 2022-01-19T16:26:44Z 2022-01-20T03:57:17Z OWNER I need to add `sqlite_stat1` to the hidden tables too, see: - https://github.com/simonw/datasette/issues/1587 - https://github.com/simonw/sqlite-utils/issues/366 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add KNN and data_licenses to hidden tables list 1105916061  
1016994329 https://github.com/simonw/datasette/issues/1605#issuecomment-1016994329 https://api.github.com/repos/simonw/datasette/issues/1605 IC_kwDOBm6k_c48nhoZ eyeseast 25778 2022-01-20T00:27:17Z 2022-01-20T00:27:17Z CONTRIBUTOR Right now, I usually have a line in a Makefile like this: ```make combined.geojson: project.db pipenv run datasette project.db --get /project/combined.geojson \ --load-extension spatialite \ --setting sql_time_limit_ms 5000 \ --setting max_returned_rows 20000 \ -m metadata.yml > $@ ``` That all assumes I've loaded whatever I need into `project.db` and created a canned query called `combined` (and then uses `datasette-geojson` for geojson output). It works, but as you can see, it's a lot to manage, a lot of boilerplate, and it wasn't obvious how to get there. If there's an error in the canned query, I get an HTML error page, so that's hard to debug. And it's only one query, so each output needs a line like this. Make isn't ideal, either, for that reason. The thing I really liked with `datafreeze` was doing templated filenames. I have a project now where I need to export a bunch of litttle geojson files, based on queries, and it would be awesome to be able to do something like this: ```yml databases: project: queries: boundaries: sql: "SELECT * FROM boundaries" filename: "boundaries/{id}.geojson" mode: "item" format: geojson ``` And then do: ```sh datasette freeze -m metadata.yml project.db ``` For HTML export, maybe there's a `template` argument, or `format: template` or something. And that gets you a static site generator, kinda for free. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Scripted exports 1108671952  
1017016553 https://github.com/simonw/datasette/issues/1356#issuecomment-1017016553 https://api.github.com/repos/simonw/datasette/issues/1356 IC_kwDOBm6k_c48nnDp simonw 9599 2022-01-20T01:06:37Z 2022-01-20T01:06:37Z OWNER > A problem with this is that if you're using `--query` you likely want ALL of the results - at the moment the only Datasette output type that can stream everything is `.csv` and plugin formats can't handle full streams, see #1062 and #1177. I figured out a neat pattern for streaming JSON arrays in this TIL: https://til.simonwillison.net/python/output-json-array-streaming {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Research: syntactic sugar for using --get with SQL queries, maybe "datasette query" 910092577  
1017095821 https://github.com/simonw/datasette/issues/1601#issuecomment-1017095821 https://api.github.com/repos/simonw/datasette/issues/1601 IC_kwDOBm6k_c48n6aN simonw 9599 2022-01-20T03:56:14Z 2022-01-20T03:56:28Z OWNER Oh interesting, I hadn't heard about KNN2. It looks like it was added to SpatiaLite on 21st June 2021 in https://www.gaia-gis.it/fossil/libspatialite/info/03786a62cdb4ab17 but the most recent release of SpatiaLite is 5.0.1 from 7th February 2021 - so it's not yet in a release. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add KNN and data_licenses to hidden tables list 1105916061  
1017108291 https://github.com/simonw/datasette/issues/1606#issuecomment-1017108291 https://api.github.com/repos/simonw/datasette/issues/1606 IC_kwDOBm6k_c48n9dD simonw 9599 2022-01-20T04:24:54Z 2022-01-20T04:24:54Z OWNER https://github.com/simonw/latest-datasette-with-all-plugins/commit/1e12ffe70be791e3281b41810e837515314c1317 shows that 5 days ago Datasette upgraded from Uvicorn 0.16 to 0.17 Sure enough, in the changelog for 0.17: https://github.com/encode/uvicorn/blob/0.17.0/CHANGELOG.md > - Drop Python 3.6 support ([#1261](https://github.com/encode/uvicorn/pull/1261)) 06/01/22 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Tests failing against Python 3.6 1108846067  
1017108960 https://github.com/simonw/datasette/issues/1606#issuecomment-1017108960 https://api.github.com/repos/simonw/datasette/issues/1606 IC_kwDOBm6k_c48n9ng simonw 9599 2022-01-20T04:26:36Z 2022-01-20T04:26:36Z OWNER https://pypistats.org/packages/datasette shows Python 3.6 is 0.24% of Datasette downloads. <img width="941" alt="image" src="https://user-images.githubusercontent.com/9599/150273301-18ec2ec8-f9ce-49a3-b57d-e74826a5c7ae.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Tests failing against Python 3.6 1108846067  
1017109194 https://github.com/simonw/datasette/issues/1606#issuecomment-1017109194 https://api.github.com/repos/simonw/datasette/issues/1606 IC_kwDOBm6k_c48n9rK simonw 9599 2022-01-20T04:27:07Z 2022-01-20T04:27:07Z OWNER Relevant: - https://github.com/simonw/datasette/issues/1577 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Tests failing against Python 3.6 1108846067  
1017109401 https://github.com/simonw/datasette/issues/1577#issuecomment-1017109401 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c48n9uZ simonw 9599 2022-01-20T04:27:34Z 2022-01-20T04:27:34Z OWNER OK, now that Uvicorn has dropped 3.6 support - see #1606 - I think this decision is easy to make. I'm dropping 3.6. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Drop support for Python 3.6 1087913724  
1017112130 https://github.com/simonw/datasette/issues/1577#issuecomment-1017112130 https://api.github.com/repos/simonw/datasette/issues/1577 IC_kwDOBm6k_c48n-ZC simonw 9599 2022-01-20T04:33:57Z 2022-01-20T04:33:57Z OWNER Dropped support for Python 3.6: updated `setup.py`, changed all references in the documentation to say 3.7 is the minimum required version, got rid of the GitHub Actions tests against 3.6. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Drop support for Python 3.6 1087913724  
1017113831 https://github.com/simonw/datasette/issues/1601#issuecomment-1017113831 https://api.github.com/repos/simonw/datasette/issues/1601 IC_kwDOBm6k_c48n-zn simonw 9599 2022-01-20T04:38:14Z 2022-01-20T04:38:14Z OWNER I don't have solid tests in place for exercising SpatiaLite, but this change feels safe enough that I'm not going to add tests for it. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add KNN and data_licenses to hidden tables list 1105916061  
1017124310 https://github.com/simonw/datasette/issues/1600#issuecomment-1017124310 https://api.github.com/repos/simonw/datasette/issues/1600 IC_kwDOBm6k_c48oBXW simonw 9599 2022-01-20T05:06:09Z 2022-01-20T05:06:09Z OWNER Fixed: https://docs.datasette.io/en/latest/plugins.html#seeing-what-plugins-are-installed {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} plugins --all example should use cog 1104691662  
1017131209 https://github.com/simonw/datasette/issues/1603#issuecomment-1017131209 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oDDJ simonw 9599 2022-01-20T05:22:40Z 2022-01-20T05:22:40Z OWNER This one is 101KB and 1536*1536 which is a bit big! https://github.com/simonw/datasette-app/blob/main/build/icon.png {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017131801 https://github.com/simonw/datasette/issues/1603#issuecomment-1017131801 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oDMZ simonw 9599 2022-01-20T05:23:57Z 2022-01-20T05:23:57Z OWNER https://adamj.eu/tech/2022/01/18/how-to-add-a-favicon-to-your-django-site/ suggests 64x64, I'm going with 128x128 just in case anyone invents a retina-retina screen. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017132927 https://github.com/simonw/datasette/issues/1603#issuecomment-1017132927 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oDd_ simonw 9599 2022-01-20T05:26:29Z 2022-01-20T05:26:29Z OWNER Here's the 128x128 one - 11kb, I resized it using Preview: ![icon](https://user-images.githubusercontent.com/9599/150278798-48cc2da2-3640-414d-a440-20c9d93c09f4.png) Now running it through [Squoosh](https://squoosh.app/editor) using OxiPNG effort=3 colours=24 - brought it down to 1.36KB. ![favicon](https://user-images.githubusercontent.com/9599/150278906-b312940e-0cdb-43ef-a325-45d2b1c240de.png) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017133357 https://github.com/simonw/datasette/issues/1603#issuecomment-1017133357 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oDkt simonw 9599 2022-01-20T05:27:34Z 2022-01-20T05:27:34Z OWNER I'm going to drop it in `datasette/static/favicon.png` and rewrite the `async def favicon()` function to return it, with caching headers. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017136897 https://github.com/simonw/datasette/issues/1603#issuecomment-1017136897 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oEcB simonw 9599 2022-01-20T05:36:29Z 2022-01-20T05:36:29Z OWNER Here's what it looks like in Firefox, Chrome and Safari: ![CleanShot 2022-01-19 at 21 35 06@2x](https://user-images.githubusercontent.com/9599/150279832-6c233115-6540-4746-8cd1-dce25321ebbf.png) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017137117 https://github.com/simonw/datasette/issues/1603#issuecomment-1017137117 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oEfd simonw 9599 2022-01-20T05:37:05Z 2022-01-20T05:37:34Z OWNER I'm not crazy about the look - I think this version of the grid may have too many lines for this particular display size. I'm going to try reducing the number of lines in Figma to see if I like that better. https://www.figma.com/file/LKjceTFNtKm6wCbScDqm1Y/Datasette-Logo {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017139321 https://github.com/simonw/datasette/issues/1603#issuecomment-1017139321 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oFB5 simonw 9599 2022-01-20T05:43:07Z 2022-01-20T05:46:42Z OWNER My attempt with one less grid line looked awful when shrunk down to the browser size: <img width="350" alt="image" src="https://user-images.githubusercontent.com/9599/150280445-a482de8e-8b5f-4145-8567-36ac7105c303.png"> File here: ![favicon](https://user-images.githubusercontent.com/9599/150280463-817a8065-8393-4c10-aec4-5a627cf46fae.png) I'm going with the first attempt for the moment. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017142395 https://github.com/simonw/datasette/issues/1603#issuecomment-1017142395 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oFx7 simonw 9599 2022-01-20T05:50:55Z 2022-01-20T05:50:55Z OWNER The new `/favicon.ico` view: https://github.com/simonw/datasette/blob/0467723ee57c2cbc0f02daa47cef632dd4651df0/datasette/app.py#L182-L192 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017143437 https://github.com/simonw/datasette/issues/1603#issuecomment-1017143437 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oGCN simonw 9599 2022-01-20T05:53:17Z 2022-01-20T05:53:17Z OWNER New favicon now live on https://latest.datasette.io/ - see also https://latest.datasette.io/favicon.ico {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017143817 https://github.com/simonw/datasette/issues/1603#issuecomment-1017143817 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oGIJ simonw 9599 2022-01-20T05:54:09Z 2022-01-20T05:54:09Z OWNER Oops, I pushed the one I liked least out of the two options! Fixing now. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017149828 https://github.com/simonw/datasette/issues/1603#issuecomment-1017149828 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48oHmE simonw 9599 2022-01-20T06:07:31Z 2022-01-20T06:07:31Z OWNER Now live on https://latest.datastte.io/ - I'm happy enough with this for the moment: <img width="364" alt="image" src="https://user-images.githubusercontent.com/9599/150283069-dd23e688-ec77-4200-a892-38e0f8892f30.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017800506 https://github.com/simonw/datasette/issues/1603#issuecomment-1017800506 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48qmc6 simonw 9599 2022-01-20T18:31:18Z 2022-01-20T18:31:18Z OWNER One last go at tidying this up. I decided to do a 32x32 pixel version in Pixelmator, using this trick to access a pixel brush: https://osxdaily.com/2016/11/17/enable-pixel-brush-pixelmator-mac/ <img width="916" alt="image" src="https://user-images.githubusercontent.com/9599/150399724-10b17a97-3ecf-4d82-868c-f8a642f16838.png"> Frustrating how the white boxes are all exactly four pixels high and ALMOST all four pixels wide, but one of them has to be three pixels wide to fit the space. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017806497 https://github.com/simonw/datasette/issues/1603#issuecomment-1017806497 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48qn6h simonw 9599 2022-01-20T18:39:27Z 2022-01-20T18:39:57Z OWNER Here's a comparison between my hand-edited version and the one I have now: ![CleanShot 2022-01-20 at 10 38 00@2x](https://user-images.githubusercontent.com/9599/150401244-7e78ee93-1973-4c95-8f91-01e51e0d5366.png) The new 32x32 image: <img src="https://user-images.githubusercontent.com/9599/150401295-8873fa40-8859-40e3-99d7-e53276319a15.png" width="32" height="32"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017808898 https://github.com/simonw/datasette/issues/1603#issuecomment-1017808898 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48qogC simonw 9599 2022-01-20T18:42:35Z 2022-01-20T18:42:35Z OWNER Resized it down to 208 bytes with https://squoosh.app <img width="883" alt="image" src="https://user-images.githubusercontent.com/9599/150401693-d19c7fdf-7f5d-49b4-8f1e-5c9e62cbdbed.png"> ![favicon](https://user-images.githubusercontent.com/9599/150401709-11a50492-a8c8-4eee-848c-c813f8cd3e4e.png) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017842366 https://github.com/simonw/datasette/issues/1603#issuecomment-1017842366 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48qwq- simonw 9599 2022-01-20T19:19:54Z 2022-01-20T19:19:54Z OWNER Wrote up a TIL: https://til.simonwillison.net/pixelmator/pixel-editing-favicon {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} A proper favicon 1108235694  
1017969452 https://github.com/simonw/datasette/issues/1608#issuecomment-1017969452 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rPss simonw 9599 2022-01-20T22:07:55Z 2022-01-20T22:07:55Z OWNER I think I want a banner at the top of the page making it obvious which version the documentation is talking about. This can be pretty low key for the current stable release, but should be visually more prominent for the `/latest/` branch and for older releases. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017970132 https://github.com/simonw/datasette/issues/1608#issuecomment-1017970132 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rP3U simonw 9599 2022-01-20T22:08:55Z 2022-01-20T22:08:55Z OWNER Might want to consider SEO here too - I want people from search engines to land on `/stable/`, I wonder if I should noindex or `rel=canonical` the other documentation versions? Not sure what best practices for that is. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017971905 https://github.com/simonw/datasette/issues/1608#issuecomment-1017971905 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rQTB simonw 9599 2022-01-20T22:11:40Z 2022-01-20T22:11:40Z OWNER Huh, I had forgotten I already have a banner on older versions: ![D1A65C68-9A37-4FA2-80C4-534739A9D292](https://user-images.githubusercontent.com/9599/150430410-1e22e23f-ed27-4271-89ff-63467eb5f466.jpeg) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017975322 https://github.com/simonw/datasette/issues/1608#issuecomment-1017975322 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rRIa simonw 9599 2022-01-20T22:17:01Z 2022-01-20T22:27:07Z OWNER Turns out that banner is something that ReadTheDocs implemented - I found it using GitHub code search, it's produced by this piece of JavaScript: https://github.com/readthedocs/readthedocs.org/blob/0852d7c10d725d954d3e9a93513171baa1116d9f/readthedocs/core/static-src/core/js/doc-embed/version-compare.js#L13-L21 ```javascript function init(data) { var rtd = rtddata.get(); /// Out of date message if (data.is_highest) { return; } var currentURL = window.location.pathname.replace(rtd['version'], data.slug); var warning = $( '<div class="admonition warning"> ' + '<p class="first admonition-title">Note</p> ' + '<p class="last"> ' + 'You are not reading the most recent version of this documentation. ' + '<a href="#"></a> is the latest version available.' + '</p>' + '</div>'); warning .find('a') .attr('href', currentURL) .text(data.slug); var body = $("div.body"); if (!body.length) { body = $("div.document"); } body.prepend(warning); } ``` And here's where that module is called from the rest of their code: https://github.com/readthedocs/readthedocs.org/blob/bc3e147770e5740314a8e8c33fec5d111c850498/readthedocs/core/static-src/core/js/doc-embed/footer.js#L66-L86 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017981599 https://github.com/simonw/datasette/issues/1608#issuecomment-1017981599 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rSqf simonw 9599 2022-01-20T22:26:32Z 2022-01-20T22:26:32Z OWNER I'm tempted to imitate their JavaScript but check for `/latest/` in the URL and use that to append a similar message warning about this being the documentation for the in-development version. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017988556 https://github.com/simonw/datasette/issues/1608#issuecomment-1017988556 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rUXM simonw 9599 2022-01-20T22:37:51Z 2022-01-20T22:37:51Z OWNER Here's a jQuery recipe that seems to do the right thing: ```javascript jQuery(function ($) { // If this is a /latest/ doc page, show banner linking to /stable/ if (!/\/latest\//.test(location.pathname)) { return; } var stableUrl = location.pathname.replace("/latest/", "/stable/"); // Check it's not a 404 fetch(stableUrl, { method: "HEAD" }).then((response) => { if (response.status == 200) { var warning = $( `<div class="admonition warning"> <p class="first admonition-title">Note</p> <p class="last"> This documentation covers the <strong>development version</strong> of Datasette.</p> <p>See <a href="${stableUrl}">this page</a> for the current stable release. </p> </div>` ); warning.find("a").attr("href", stableUrl); var body = $("div.body"); if (!body.length) { body = $("div.document"); } body.prepend(warning); } }); }); ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017993482 https://github.com/simonw/datasette/issues/1608#issuecomment-1017993482 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rVkK astrojuanlu 316517 2022-01-20T22:46:16Z 2022-01-20T22:46:16Z NONE Or you can use https://sphinx-version-warning.readthedocs.io/! 😄 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017994925 https://github.com/simonw/datasette/issues/1608#issuecomment-1017994925 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rV6t simonw 9599 2022-01-20T22:48:43Z 2022-01-20T22:54:02Z OWNER https://sphinx-version-warning.readthedocs.io/ looks like it can show a banner for "You are looking at v0.36 but you should be looking at 0.40" but doesn't hand the case I need here which is "you are looking at /latest/ but you should be looking at /stable/". Just shipped my fix here: https://docs.datasette.io/en/latest/ <img width="994" alt="image" src="https://user-images.githubusercontent.com/9599/150434433-e2f0d472-77a8-430b-88e5-f22e2c6e8ef0.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1017998993 https://github.com/simonw/datasette/issues/1608#issuecomment-1017998993 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rW6R simonw 9599 2022-01-20T22:56:00Z 2022-01-20T22:56:00Z OWNER > https://sphinx-version-warning.readthedocs.io/ looks like it can show a banner for "You are looking at v0.36 but you should be looking at 0.40" but doesn't hand the case I need here which is "you are looking at /latest/ but you should be looking at /stable/". Correction! That tool DOES support that, as can be seen in their example configuration for their own documentation: https://github.com/humitos/sphinx-version-warning/blob/a82156c2ea08e5feab406514d0ccd9d48a345f48/docs/conf.py#L32-L38 ```python versionwarning_messages = { 'latest': 'This is a custom message only for version "latest" of this documentation.', } versionwarning_admonition_type = 'tip' versionwarning_banner_title = 'Tip' versionwarning_body_selector = 'div[itemprop="articleBody"]' ``` {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  
1018017637 https://github.com/simonw/datasette/issues/1608#issuecomment-1018017637 https://api.github.com/repos/simonw/datasette/issues/1608 IC_kwDOBm6k_c48rbdl simonw 9599 2022-01-20T23:27:59Z 2022-01-20T23:27:59Z OWNER Got a couple of TILs out of this: - [Promoting the stable version of the documentation using rel=canonical](https://til.simonwillison.net/readthedocs/documentation-seo-canonical) - [Linking from /latest/ to /stable/ on Read The Docs](https://til.simonwillison.net/readthedocs/link-from-latest-to-stable) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Documentation should clarify /stable/ vs /latest/ 1109808154  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 576.614ms · About: simonw/datasette-graphql