issue_comments

Table actions

35 rows where "updated_at" is on date 2022-11-18

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, issue, created_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1317757949 https://github.com/simonw/datasette/issues/1896#issuecomment-1317757949 https://api.github.com/repos/simonw/datasette/issues/1896 IC_kwDOBm6k_c5Oi2P9 simonw 9599 2022-11-16T22:27:47Z 2022-11-18T21:48:29Z OWNER Open question: should `resolve_table()` know how to identify named canned queries too? I think not, at least for the moment. Feels a bit too specialist to expose in a documented API. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Extract logic for resolving a URL to a database / table / row 1452364777  
1319401843 https://github.com/simonw/datasette/issues/1897#issuecomment-1319401843 https://api.github.com/repos/simonw/datasette/issues/1897 IC_kwDOBm6k_c5OpHlz simonw 9599 2022-11-18T00:42:03Z 2022-11-18T00:42:23Z OWNER This function works even if the SQLite JSON functions are not available: ```python async def _table_columns(datasette, database_name): internal = datasette.get_database("_internal") result = await internal.execute( "select table_name, name from columns where database_name = ?", [database_name], ) table_columns = {} for row in result.rows: table_columns.setdefault(row["table_name"], []).append(row["name"]) return table_columns ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Serve schema JSON to the SQL editor to enable autocomplete 1452457263  
1319435374 https://github.com/simonw/datasette/issues/1897#issuecomment-1319435374 https://api.github.com/repos/simonw/datasette/issues/1897 IC_kwDOBm6k_c5OpPxu simonw 9599 2022-11-18T01:33:30Z 2022-11-18T01:33:30Z OWNER Just noticed that this isn't including views, which it should. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Serve schema JSON to the SQL editor to enable autocomplete 1452457263  
1319477721 https://github.com/simonw/datasette/issues/1897#issuecomment-1319477721 https://api.github.com/repos/simonw/datasette/issues/1897 IC_kwDOBm6k_c5OpaHZ simonw 9599 2022-11-18T02:51:40Z 2022-11-18T02:51:40Z OWNER Views aren't currently available in the `_internal` schema. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Serve schema JSON to the SQL editor to enable autocomplete 1452457263  
1319478811 https://github.com/simonw/datasette/issues/1897#issuecomment-1319478811 https://api.github.com/repos/simonw/datasette/issues/1897 IC_kwDOBm6k_c5OpaYb simonw 9599 2022-11-18T02:53:57Z 2022-11-18T02:53:57Z OWNER I decided to just go for the view names, not their columns. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Serve schema JSON to the SQL editor to enable autocomplete 1452457263  
1319482791 https://github.com/simonw/datasette/issues/1901#issuecomment-1319482791 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5OpbWn simonw 9599 2022-11-18T03:01:36Z 2022-11-18T03:01:36Z OWNER Good catch. Looks like that bug was introduced by this change: https://github.com/simonw/datasette/commit/1a5e5f2aa951e5bd731067a49819efba68fbe8ef From: - https://github.com/simonw/datasette/issues/1831 The search all plugin includes this code which interacts poorly with that refactor: https://github.com/simonw/datasette-search-all/blob/847b55c368a285e4567627029624d7872ee75cac/datasette_search_all/templates/search_all.html#L31-L36 ```html+jinja {% block nav %} <p class="crumbs"> <a href="{{ urls.instance() }}">home</a> </p> {{ super() }} {% endblock %} ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319483555 https://github.com/simonw/datasette/issues/1901#issuecomment-1319483555 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Opbij simonw 9599 2022-11-18T03:02:35Z 2022-11-18T03:02:35Z OWNER Looks like this issue could affect a bunch of other plugins too: https://cs.github.com/?scopeName=All+repos&scope=&q=%3Cp+class%3D%22crumbs%22%3E+user%3Asimonw {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319493475 https://github.com/simonw/datasette/issues/1901#issuecomment-1319493475 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Opd9j simonw 9599 2022-11-18T03:19:25Z 2022-11-18T07:03:03Z OWNER Other plugins this looks like it will affect: - [x] `datasette-ripgrep` https://github.com/simonw/datasette-ripgrep/blob/03446464420130368582022eeb5944993f64ec8f/datasette_ripgrep/templates/ripgrep.html#L37-L42 - [x] `datasette-socrata` https://github.com/simonw/datasette-socrata/blob/32fb256a461bf0e790eca10bdc7dd9d96c20f7c4/datasette_socrata/templates/datasette_socrata_error.html#L5-L10 - [x] `datasette-configure-fts` https://github.com/simonw/datasette-configure-fts/blob/eca742e5d4b9190fc22d68bc0a406c575e6d09a0/datasette_configure_fts/templates/configure_fts_database.html#L9-L14 - [x] `datasette-edit-templates` https://github.com/simonw/datasette-edit-templates/blob/f772aff4a2a4080c949746668a8ec6302dbeb0d9/datasette_edit_templates/templates/edit_template.html#L17-L23 - [x] `datasette-copyable` https://github.com/simonw/datasette-copyable/blob/204d5c912a8d48c49155c67fba7339d4bb26ab9a/datasette_copyable/templates/copyable.html#L36-L43 - [x] `datasette-public` https://github.com/simonw/datasette-public/blob/32b6a0ba53bd5714b6b41eddd8705b213c105efc/datasette_public/templates/public_table_change_privacy.html#L5-L11 - [x] `datasette-import-table` https://github.com/simonw/datasettecloud-datasette/blob/37d0fe525c6649c1aec3d1ee8bc35a684570e87f/templates/import_data.html#L5-L10 - [x] `datasette-edit-schema` (three places) - [x] `datasette-indieauth` https://github.com/simonw/datasette-indieauth/blob/a08ce67ddad6098b1240adbeff37d040e4df53b1/datasette_indieauth/templates/indieauth.html#L5-L10 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319525520 https://github.com/simonw/datasette/issues/1901#issuecomment-1319525520 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5OplyQ simonw 9599 2022-11-18T04:21:14Z 2022-11-18T07:22:37Z OWNER This search helps too: [https://ripgrep.datasette.io/-/ripgrep?pattern=%7B%25+block+nav&literal=on&ignore=on&glob=%21datasette%2F**](https://ripgrep.datasette.io/-/ripgrep?pattern=%7B%25+block+nav&literal=on&ignore=on&glob=%21datasette%2F**) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319528359 https://github.com/simonw/datasette/issues/1901#issuecomment-1319528359 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Opmen simonw 9599 2022-11-18T04:27:00Z 2022-11-18T04:27:00Z OWNER Also `datasette-indieauth` https://github.com/simonw/datasette-indieauth/blob/a08ce67ddad6098b1240adbeff37d040e4df53b1/datasette_indieauth/templates/indieauth.html#L5-L10 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319533445 https://github.com/simonw/datasette/issues/1897#issuecomment-1319533445 https://api.github.com/repos/simonw/datasette/issues/1897 IC_kwDOBm6k_c5OpnuF bgrins 95570 2022-11-18T04:38:03Z 2022-11-18T04:38:03Z CONTRIBUTOR Are you tracking the change to send the JSON over to the frontend separately or was that part of this? Something like this is probably pretty close https://github.com/bgrins/datasette/commit/8431c98850c7a552dbcde2a4dd0c3dc942a97d25#diff-0c93232bfd5477eeac96382e52769108b41433d960d5277ffcccf2f464e60abdR9 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Serve schema JSON to the SQL editor to enable autocomplete 1452457263  
1319570586 https://github.com/simonw/datasette/issues/1897#issuecomment-1319570586 https://api.github.com/repos/simonw/datasette/issues/1897 IC_kwDOBm6k_c5Opwya simonw 9599 2022-11-18T05:33:20Z 2022-11-18T05:33:20Z OWNER One of the big changes still left to do for Datasette 1.0 is to unify the JSON representation with the context psssed to the templates (via an `?_extra=` mechanism to add extra context needed by the HTML templates), because a goal for 1.0 is for the template context to be a documented API contract such that custom templates won't break with future releases. As such I expect to do quite a bit of refactoring and cleanup on how the template context works later on. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Serve schema JSON to the SQL editor to enable autocomplete 1452457263  
1319571220 https://github.com/simonw/datasette/issues/1900#issuecomment-1319571220 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Opw8U simonw 9599 2022-11-18T05:34:35Z 2022-11-18T05:34:35Z OWNER Which Docker image are you using here? It looks like it's missing SpatiaLite from the image. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319574972 https://github.com/simonw/datasette/issues/1900#issuecomment-1319574972 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Opx28 simonw 9599 2022-11-18T05:41:28Z 2022-11-18T05:41:28Z OWNER Oh this is with `datasette package`? That should work. Will investigate. {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319582239 https://github.com/simonw/datasette/issues/1900#issuecomment-1319582239 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Opzof simonw 9599 2022-11-18T05:55:38Z 2022-11-18T05:55:38Z OWNER Trying this out locally with this 69MB SpatiaLite file I happened to have lying around (from testing `shapefile-to-sqlite` a while ago): https://static.simonwillison.net/static/2022/nps-spatialite.db ``` % datasette package nps-spatialite.db --spatialite ... => [2/6] COPY . /app 0.4s => [3/6] WORKDIR /app 0.0s => [4/6] RUN apt-get update && apt-get install -y python3-dev gcc libsqlite3-mod-spatialite && rm -rf /var/lib/apt/lists/* 29.6s => [5/6] RUN pip install -U datasette 12.0s => [6/6] RUN datasette inspect nps-spatialite.db --inspect-file inspect-data.json 2.6s => exporting to image 3.0s => => exporting layers 3.0s => => writing image sha256:4dfef1c373c5c057ef7ac22344f834d522acef24313a1b25d2eba9e500066b8f 0.0s ``` And then: docker run -p 8001:8001 4dfef1c373c5 This worked fine for me. I ran `datasette package` using Datasette 0.63.1. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319583281 https://github.com/simonw/datasette/issues/1900#issuecomment-1319583281 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Opz4x simonw 9599 2022-11-18T05:57:44Z 2022-11-18T05:57:44Z OWNER Did you use the `--spatialite` option? I just tried this: datasette package nps-spatialite.db It built the image OK (I didn't see the error you reported), but running the container failed with an error: ``` /tmp % docker run -p 8001:8001 7298e8e6bbfb Usage: datasette serve [OPTIONS] [FILES]... Try 'datasette serve --help' for help. Error: It looks like you're trying to load a SpatiaLite database without first loading the SpatiaLite module. Read more: https://docs.datasette.io/en/stable/spatialite.html ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319583703 https://github.com/simonw/datasette/issues/1900#issuecomment-1319583703 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Opz_X simonw 9599 2022-11-18T05:58:31Z 2022-11-18T05:58:31Z OWNER Could you provide full steps to reproduce plus a SpatiaLite database file that triggered this for you? I'm not able to recreate the problem. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319584553 https://github.com/simonw/datasette/issues/1899#issuecomment-1319584553 https://api.github.com/repos/simonw/datasette/issues/1899 IC_kwDOBm6k_c5Op0Mp simonw 9599 2022-11-18T06:00:10Z 2022-11-18T06:01:50Z OWNER I can't actually remember where that `min-height: 70px` came from. I just tried without it and it seems fine - especially since any time you add a newline in the editor it increases its height to fit. I ran this in the DevTools console: ```javascript document.querySelector('.cm-editor').style.minHeight = 'none'; ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Clicking within the CodeMirror area below the SQL (i.e. when there's only a single line) doesn't cause the editor to get focused  1452495049  
1319588163 https://github.com/simonw/datasette/issues/1901#issuecomment-1319588163 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Op1FD simonw 9599 2022-11-18T06:05:11Z 2022-11-18T06:05:11Z OWNER For `datasette-copyable` I want to show breadcrumbs that take database/instance permissions into account, so I'm removing `{% block nav %}` entirely and replacing it with this: ```html+jinja {% block crumbs %} {{ crumbs.nav(request=request, database=database, table=table) }} {% endblock %} ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319596087 https://github.com/simonw/datasette/issues/1900#issuecomment-1319596087 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Op3A3 rdmurphy 419145 2022-11-18T06:16:33Z 2022-11-18T06:16:33Z NONE Interesting! So I tried this locally using your copy of `nps-spatialite.db` and I got the same error. 🤔 ``` ❯ datasette package nps-spatialite.db --spatialite [+] Building 27.5s (10/10) FINISHED => [internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 622B 0.0s => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [internal] load metadata for docker.io/library/python:3.11.0-slim-bullseye 0.9s => [internal] load build context 2.3s => => transferring context: 72.38MB 2.3s => CACHED [1/6] FROM docker.io/library/python:3.11.0-slim-bullseye@sha256:1cd45c5dad845af18d71745c017325725dc979571c1bbe625b67e6051533716c 0.0s => [2/6] COPY . /app 0.1s =>… {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319623911 https://github.com/simonw/datasette/issues/1901#issuecomment-1319623911 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Op9zn simonw 9599 2022-11-18T07:02:56Z 2022-11-18T07:02:56Z OWNER That's all of them! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319627012 https://github.com/simonw/datasette/issues/1901#issuecomment-1319627012 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Op-kE simonw 9599 2022-11-18T07:07:03Z 2022-11-18T07:07:03Z OWNER Here's the full list of 10 plugin releases for this issue: * [datasette-search-all 1.1.1](https://github.com/simonw/datasette-search-all/releases/tag/1.1.1) * [datasette-ripgrep 0.7.1](https://github.com/simonw/datasette-ripgrep/releases/tag/0.7.1) * [datasette-socrata 0.3.1](https://github.com/simonw/datasette-socrata/releases/tag/0.3.1) * [datasette-configure-fts 1.1.1](https://github.com/simonw/datasette-configure-fts/releases/tag/1.1.1) * [datasette-edit-templates 0.2](https://github.com/simonw/datasette-edit-templates/releases/tag/0.2) * [datasette-copyable 0.3.2](https://github.com/simonw/datasette-copyable/releases/tag/0.3.2) * [datasette-public 0.2.1](https://github.com/simonw/datasette-public/releases/tag/0.2.1) * [datasette-import-table 0.3.1](https://github.com/simonw/datasette-import-table/releases/tag/0.3.1) * [datasette-indieauth 1.2.2](https://github.com/simonw/datasette-indieauth/releases/tag/1.2.2) * [datasette-edit-schema 0.5.2](https://github.com/simonw/datasette-edit-schema/releases/tag/0.5.2) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319629469 https://github.com/simonw/datasette/issues/1900#issuecomment-1319629469 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Op_Kd simonw 9599 2022-11-18T07:10:17Z 2022-11-18T07:10:17Z OWNER This is so weird! What version of Datasette do you get from `datasette --version` there - and what's your Docker version / operating system version? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319631421 https://github.com/simonw/datasette/issues/1900#issuecomment-1319631421 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5Op_o9 simonw 9599 2022-11-18T07:13:00Z 2022-11-18T07:13:00Z OWNER You get: ``` => [internal] load metadata for docker.io/library/python:3.11.0-slim-bullseye 0.9s => [internal] load build context 2.3s => => transferring context: 72.38MB 2.3s => CACHED [1/6] FROM docker.io/library/python:3.11.0-slim-bullseye@sha256:1cd45c5dad845af18d71745c017325725dc979571c1bbe625b67e6051533716c 0.0s ``` I get: ``` => [internal] load metadata for docker.io/library/python:3.11.0-slim-bullseye 1.0s => [internal] load build context 0.0s => => transferring context: 705B 0.0s => CACHED [1/6] FROM docker.io/library/python:3.11.0-slim-bullseye@sha256:1cd45c5dad845af18d71745c017325725dc979571c1bbe625b67e6051533716c 0.0s ``` Both the image name and the hash are _exactly_ the same. So why are you getting an error while mine works OK? For my machine: ``` ~ % docker --version Docker version 20.10.12, build e91ed57 ~ % uname -a Darwin Simons-MacBook-Pro-2.local 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct 9 20:14:54 PDT 2022; root:xnu-8792.41.9~2/RELEASE_X86_64 x86_64 ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319639462 https://github.com/simonw/datasette/issues/1900#issuecomment-1319639462 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5OqBmm rdmurphy 419145 2022-11-18T07:24:19Z 2022-11-18T07:24:19Z NONE Is it, uh, possible we are on different architectures? 😅 I'm using an Apple M1 Pro. I jumped into a bash shell of an unmodified `python:3.11.0-slim-bullseye` container and manually ran `apt-get update` and installed `libsqlite3-mod-spatialite`. I don't end up with with `mod_spatialite.so` in `/usr/lib/x86_64-linux-gnu/` — _mine_ is in `/usr/lib/aarch64-linux-gnu/`. [I swapped that directory in here](https://github.com/simonw/datasette/blob/3db37e9a21f774d6c387fd04bf1e4c870554209e/datasette/utils/__init__.py#L407) in a local copy of `datasette` and poof — it worked! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319641636 https://github.com/simonw/datasette/issues/1900#issuecomment-1319641636 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5OqCIk rdmurphy 419145 2022-11-18T07:27:26Z 2022-11-18T07:27:26Z NONE Can confirm that my `uname -a` returns something different at the end: ``` root:xnu-8792.41.9~2/RELEASE_ARM64_T6000 arm64 ``` I'm in `arm64` land, you're in `x86_64`. I am admittedly very fuzzy on how this factors into Docker these days. Honestly thought this was one of the things Docker was suppose to help address. 🤔 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1319642338 https://github.com/simonw/datasette/issues/1899#issuecomment-1319642338 https://api.github.com/repos/simonw/datasette/issues/1899 IC_kwDOBm6k_c5OqCTi simonw 9599 2022-11-18T07:28:28Z 2022-11-18T07:28:28Z OWNER Demo: https://latest.datasette.io/fixtures {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Clicking within the CodeMirror area below the SQL (i.e. when there's only a single line) doesn't cause the editor to get focused  1452495049  
1319642535 https://github.com/simonw/datasette/pull/1898#issuecomment-1319642535 https://api.github.com/repos/simonw/datasette/issues/1898 IC_kwDOBm6k_c5OqCWn simonw 9599 2022-11-18T07:28:45Z 2022-11-18T07:28:45Z OWNER Thanks! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Use DOMContentLoaded instead of load event for CodeMirror initialization 1452485922  
1319664697 https://github.com/simonw/datasette/issues/1900#issuecomment-1319664697 https://api.github.com/repos/simonw/datasette/issues/1900 IC_kwDOBm6k_c5OqHw5 rdmurphy 419145 2022-11-18T07:59:36Z 2022-11-18T08:00:38Z NONE Okay, my final observations for the night! I've been pushing and pulling the various levers in `utils/__init__.py` to see what makes this work without hard-coding in something for `arm64` and it seems that if I change `/usr/lib/x86_64-linux-gnu/mod_spatialite.so` [here](https://github.com/simonw/datasette/blob/3ecd131e57add427d847b614c920c9624bb2e66b/datasette/utils/__init__.py#L407) to just `mod_spatialite` it's happy. Unfortunately cannot audit that for `x86_64`, but maybe that's a solution that'd be cross-arch compatible? It seems like it's the hard-coding of that path that's tripping it up. (It was actually [this comment from back in 2018 in an entirely unrelated repo](https://github.com/pelias/docker/pull/28#issuecomment-433168462) that nudged me to try this, ha.) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette package --spatialite throws error during build 1452572348  
1320394127 https://github.com/simonw/sqlite-utils/issues/510#issuecomment-1320394127 https://api.github.com/repos/simonw/sqlite-utils/issues/510 IC_kwDOCGYnMM5Os52P ar-jan 1176293 2022-11-18T18:37:51Z 2022-11-18T18:37:51Z NONE I guess it is not incorrect when it says the version is `4`, though it is confusing. Maybe it doesn't even refer to FTS4/FTS5 versions, but something else? In any case, it's not related to sqlite-utils, but SQLite itself. {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Cannot enable FTS5 despite it being available 1434911255  
1320563197 https://github.com/simonw/datasette/issues/1863#issuecomment-1320563197 https://api.github.com/repos/simonw/datasette/issues/1863 IC_kwDOBm6k_c5OtjH9 simonw 9599 2022-11-18T21:47:35Z 2022-11-18T21:48:07Z OWNER Incomplete implementation of this view: ```python class RowUpdateView(BaseView): name = "row-update" def __init__(self, datasette): self.ds = datasette async def post(self, request): database_route = tilde_decode(request.url_vars["database"]) table = tilde_decode(request.url_vars["table"]) try: db = self.ds.get_database(route=database_route) except KeyError: return _error(["Database not found: {}".format(database_route)], 404) database_name = db.name if not await db.table_exists(table): return _error(["Table not found: {}".format(table)], 404) pk_values = urlsafe_components(request.url_vars["pks"]) sql, params, pks = await row_sql_params_pks(db, table, pk_values) results = await db.execute(sql, params, truncate=True) rows = list(results.rows) if not rows: return _error([f"Record not found: {pk_values}"], 404) # Ensure user has permission to update this row if not await self.ds.permission_allowed( request.actor, "update-row", resource=(database_name, table) ): return _error(["Permission denied"], 403) body = await request.post_body() try: data = json.loads(body) except json.JSONDecodeError as e: return _error(["Invalid JSON: {}".format(e)]) if not isinstance(data, dict): return _error(["JSON must be a dictionary"]) def update_row(conn): sqlite_utils.Database(conn)[table].update(pk_values, updates) await db.execute_write_fn(update_row) result = {"ok": True} if data.get("return"): result["row"] = {"row-here": "TODO"} return Response.json(result, status=200) ``` This is before the refactor in: - #1896 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Update a single record in an existing table 1425029242  
1320588299 https://github.com/simonw/datasette/issues/1896#issuecomment-1320588299 https://api.github.com/repos/simonw/datasette/issues/1896 IC_kwDOBm6k_c5OtpQL simonw 9599 2022-11-18T22:16:59Z 2022-11-18T22:17:06Z OWNER Found myself needing an `await db.view_exists()` method for this, similar to the existing `await db.table_exists()` one. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Extract logic for resolving a URL to a database / table / row 1452364777  
1320614541 https://github.com/simonw/datasette/issues/1903#issuecomment-1320614541 https://api.github.com/repos/simonw/datasette/issues/1903 IC_kwDOBm6k_c5OtvqN simonw 9599 2022-11-18T22:47:41Z 2022-11-18T22:47:41Z OWNER When I do this it's important to update the documentation for `resolve_database()` and the like: https://github.com/simonw/datasette/blob/ee64130fa8a5ff4a24791916c696e10cf2375102/docs/internals.rst#L594 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Refactor all error classes into a datasette.exceptions module 1455928469  
1320616559 https://github.com/simonw/datasette/issues/1896#issuecomment-1320616559 https://api.github.com/repos/simonw/datasette/issues/1896 IC_kwDOBm6k_c5OtwJv simonw 9599 2022-11-18T22:51:14Z 2022-11-18T22:51:14Z OWNER New methods are documented here: https://docs.datasette.io/en/1.0-dev/internals.html#resolve-database-request {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Extract logic for resolving a URL to a database / table / row 1452364777  
1320625260 https://github.com/simonw/datasette/issues/1891#issuecomment-1320625260 https://api.github.com/repos/simonw/datasette/issues/1891 IC_kwDOBm6k_c5OtyRs simonw 9599 2022-11-18T23:01:03Z 2022-11-18T23:01:48Z OWNER I think this actually needs to include a whole section of the documentation about the road to 1.0 - what to expect (planned breaking changes) etc. I can add that to the https://docs.datasette.io/en/stable/contributing.html page perhaps - or even create a Roadmap page. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 1.0a0 release notes 1450303205  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);