home / github / pull_requests

Menu
  • GraphQL API

pull_requests: 727012996

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association repo url merged_by auto_merge
727012996 MDExOlB1bGxSZXF1ZXN0NzI3MDEyOTk2 324 closed 0 Use python-dateutil package instead of dateutils 191622 While working on updating `sqlite-utils` for NixOS/Nixpkgs, I came a cross the following: In 5ec6686153e29ae10d4921a1ad4c841f192f20e2, a new dependency was added on `dateutils` (https://pypi.org/project/dateutils/). I believe this is unintentional, and instead `python-dateutil` (https://pypi.org/project/python-dateutil/) was intended. My reasoning is: - `python-dateutil` is imported here in [recipes.py](https://github.com/simonw/sqlite-utils/blob/5ec6686153e29ae10d4921a1ad4c841f192f20e2/sqlite_utils/recipes.py#L1) - The `mypy` `type-python-dateutil` dependency in [setup.py](https://github.com/simonw/sqlite-utils/blob/5ec6686153e29ae10d4921a1ad4c841f192f20e2/setup.py#L36) - `python-dateutil` is a dependency of `dateutils` as seen in the output in [docs/tutorial.ipynb](https://github.com/simonw/sqlite-utils/blob/77c240df56068341561e95e4a412cbfa24dc5bc7/docs/tutorial.ipynb#L43) Seems like the trailing "s" seems to be the source of confusion ๐Ÿ˜… I've swapped the dependencies out, hope this helps. 2021-09-03T18:31:19Z 2021-11-14T23:25:40Z 2021-11-14T23:25:40Z 2021-11-14T23:25:40Z bc4c42d68879c710c851dba3c98deda96ca6caa8     0 275ac3b282947fa5df5d18de835d5d958a778e72 77c240df56068341561e95e4a412cbfa24dc5bc7 CONTRIBUTOR 140912432 https://github.com/simonw/sqlite-utils/pull/324    

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette ยท Queries took 4.499ms