github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/859#issuecomment-647922203 | https://api.github.com/repos/simonw/datasette/issues/859 | 647922203 | MDEyOklzc3VlQ29tbWVudDY0NzkyMjIwMw== | 3243482 | 2020-06-23T05:44:58Z | 2021-01-05T08:22:43Z | CONTRIBUTOR | I'm seeing the problem on database page. Index page and table page runs quite fast. - Tables have <10 columns (`id`, `url`, `title`, `body_html`, `date`, `author`, `meta` (for keeping unstructured json)). I've added index on `date` columns (using `sqlite-utils`) in addition to the index present on `id` columns. - All tables have FTS enabled on `text` and `varchar` columns (`title`, `body_html` etc) to speed up searching. - There are couple of tables related with foreign keys (think a thread in a forum and posts in that thread, related with `thread_id`) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 642572841 | |
https://github.com/simonw/datasette/issues/1173#issuecomment-754463845 | https://api.github.com/repos/simonw/datasette/issues/1173 | 754463845 | MDEyOklzc3VlQ29tbWVudDc1NDQ2Mzg0NQ== | 9599 | 2021-01-05T07:41:43Z | 2021-01-05T07:41:43Z | OWNER | https://github.com/oleksis/pyinstaller-manylinux looks useful, via https://twitter.com/oleksis/status/1346341987876823040 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 778682317 | |
https://github.com/simonw/datasette/issues/1167#issuecomment-754619930 | https://api.github.com/repos/simonw/datasette/issues/1167 | 754619930 | MDEyOklzc3VlQ29tbWVudDc1NDYxOTkzMA== | 3637 | 2021-01-05T12:57:57Z | 2021-01-05T12:57:57Z | CONTRIBUTOR | Not sure where exactly to put the actual docs (presumably somewhere in [docs/contributing.rst](https://github.com/simonw/datasette/blob/main/docs/contributing.rst)) but I've made a slight change to make it easier to run locally (copying [the approach in excalidraw](https://github.com/excalidraw/excalidraw/blob/ade2565f497243a5e428f4906d8ed80c872fd981/package.json#L90-L94)): https://github.com/simonw/datasette/compare/main...benpickles:prettier-docs | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 777145954 | |
https://github.com/simonw/datasette/issues/1175#issuecomment-754696725 | https://api.github.com/repos/simonw/datasette/issues/1175 | 754696725 | MDEyOklzc3VlQ29tbWVudDc1NDY5NjcyNQ== | 9599 | 2021-01-05T15:12:30Z | 2021-01-05T15:12:30Z | OWNER | Some tips here: https://github.com/tiangolo/fastapi/issues/78 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779156520 | |
https://github.com/dogsheep/twitter-to-sqlite/issues/54#issuecomment-754721153 | https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/54 | 754721153 | MDEyOklzc3VlQ29tbWVudDc1NDcyMTE1Mw== | 21148 | 2021-01-05T15:51:09Z | 2021-01-05T15:51:09Z | CONTRIBUTOR | Correction: the failure is on `lists-member.js` (I was thrown by the `block` variable name, but that's just a coincidence) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779088071 | |
https://github.com/dogsheep/twitter-to-sqlite/pull/55#issuecomment-754728696 | https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/55 | 754728696 | MDEyOklzc3VlQ29tbWVudDc1NDcyODY5Ng== | 21148 | 2021-01-05T16:02:55Z | 2021-01-05T16:02:55Z | CONTRIBUTOR | This now works for me, though I'm entirely ensure if it's a just-my-export thing or a wider issue. Also, this doesn't contain any tests. So I'm not sure if there's more work to be done here, or if this is good enough. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779211940 | |
https://github.com/dogsheep/twitter-to-sqlite/issues/54#issuecomment-754729035 | https://api.github.com/repos/dogsheep/twitter-to-sqlite/issues/54 | 754729035 | MDEyOklzc3VlQ29tbWVudDc1NDcyOTAzNQ== | 21148 | 2021-01-05T16:03:29Z | 2021-01-05T16:03:29Z | CONTRIBUTOR | I was able to fix this, at least enough to get _my_ archive to import. Not sure if there's more work to be done here or not. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779088071 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-754951786 | https://api.github.com/repos/simonw/datasette/issues/1176 | 754951786 | MDEyOklzc3VlQ29tbWVudDc1NDk1MTc4Ng== | 9599 | 2021-01-05T22:56:27Z | 2021-01-05T22:56:43Z | OWNER | Idea: introduce a `@documented` decorator which marks specific functions as part of the public, documented API. The unit tests can then confirm that anything with that decorator is both documented and tested. ```python @documented def escape_css_string(s): return _css_re.sub( lambda m: "\\" + (f"{ord(m.group()):X}".zfill(6)), s.replace("\r\n", "\n"), ) ``` Or maybe `@public`? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-754952040 | https://api.github.com/repos/simonw/datasette/issues/1176 | 754952040 | MDEyOklzc3VlQ29tbWVudDc1NDk1MjA0MA== | 9599 | 2021-01-05T22:57:09Z | 2021-01-05T22:57:09Z | OWNER | It might be neater to move all of the non-public functions into a separate module - `datasette.utils.internal` perhaps. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-754952146 | https://api.github.com/repos/simonw/datasette/issues/1176 | 754952146 | MDEyOklzc3VlQ29tbWVudDc1NDk1MjE0Ng== | 9599 | 2021-01-05T22:57:26Z | 2021-01-05T22:57:26Z | OWNER | Known public APIs might be worth adding type annotations to as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-754957378 | https://api.github.com/repos/simonw/datasette/issues/1176 | 754957378 | MDEyOklzc3VlQ29tbWVudDc1NDk1NzM3OA== | 9599 | 2021-01-05T23:12:03Z | 2021-01-05T23:12:03Z | OWNER | This needs to be done for Datasette 1.0. At the very least I need to ensure it's clear that `datasette.utils` is not part of the public API unless explicitly marked as such. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 779691739 | |
https://github.com/simonw/datasette/issues/576#issuecomment-754957563 | https://api.github.com/repos/simonw/datasette/issues/576 | 754957563 | MDEyOklzc3VlQ29tbWVudDc1NDk1NzU2Mw== | 9599 | 2021-01-05T23:12:37Z | 2021-01-05T23:12:37Z | OWNER | I'm happy with how this has evolved, so I'm closing the issue. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 497170355 | |
https://github.com/simonw/datasette/issues/576#issuecomment-754957658 | https://api.github.com/repos/simonw/datasette/issues/576 | 754957658 | MDEyOklzc3VlQ29tbWVudDc1NDk1NzY1OA== | 9599 | 2021-01-05T23:12:50Z | 2021-01-05T23:12:50Z | OWNER | See https://docs.datasette.io/en/stable/internals.html | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 497170355 | |
https://github.com/simonw/datasette/issues/782#issuecomment-754958610 | https://api.github.com/repos/simonw/datasette/issues/782 | 754958610 | MDEyOklzc3VlQ29tbWVudDc1NDk1ODYxMA== | 9599 | 2021-01-05T23:15:24Z | 2021-01-05T23:15:24Z | OWNER | https://latest-with-plugins.datasette.io/fixtures/roadside_attraction_characteristics/1.json-preview returns a 500 error at the moment - a KeyError on 'filtered_table_rows_count'. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 627794879 | |
https://github.com/simonw/datasette/issues/1171#issuecomment-754958998 | https://api.github.com/repos/simonw/datasette/issues/1171 | 754958998 | MDEyOklzc3VlQ29tbWVudDc1NDk1ODk5OA== | 9599 | 2021-01-05T23:16:33Z | 2021-01-05T23:16:33Z | OWNER | That's really useful, thanks @rcoup | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 778450486 |