github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/277#issuecomment-390804333 | https://api.github.com/repos/simonw/datasette/issues/277 | 390804333 | MDEyOklzc3VlQ29tbWVudDM5MDgwNDMzMw== | 9599 | 2018-05-21T22:40:16Z | 2018-05-21T22:43:50Z | OWNER | We should merge this before refactoring the tests though, because that way we don't couple the new tests to the verification of this change. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 324836533 | |
https://github.com/simonw/datasette/issues/276#issuecomment-390795067 | https://api.github.com/repos/simonw/datasette/issues/276 | 390795067 | MDEyOklzc3VlQ29tbWVudDM5MDc5NTA2Nw== | 45057 | 2018-05-21T21:55:57Z | 2018-05-21T21:55:57Z | CONTRIBUTOR | Well, we do have the capability to detect spatialite so my intention certainly wasn't to require it. I can see the advantage of having it as a plugin but it does touch a number of points in the code. I think I'm going to attack this by refactoring the necessary bits and seeing where that leads (which was my plan anyway). I think my main concern is - if I add certain plugin hooks for this, is anything else ever going to use them? I'm not sure I have an answer to that question yet, either way. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 324835838 | |
https://github.com/simonw/datasette/issues/276#issuecomment-390707760 | https://api.github.com/repos/simonw/datasette/issues/276 | 390707760 | MDEyOklzc3VlQ29tbWVudDM5MDcwNzc2MA== | 9599 | 2018-05-21T16:30:35Z | 2018-05-21T16:30:35Z | OWNER | This probably needs to be in a plugin simply because getting Spatialite compiled and installed is a bit of a pain. It's a great opportunity to expand the plugin hooks in useful ways though. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 324835838 | |
https://github.com/simonw/datasette/pull/277#issuecomment-390707183 | https://api.github.com/repos/simonw/datasette/issues/277 | 390707183 | MDEyOklzc3VlQ29tbWVudDM5MDcwNzE4Mw== | 9599 | 2018-05-21T16:28:39Z | 2018-05-21T16:28:39Z | OWNER | This is definitely a big improvement. I'd like to refactor the unit tests that cover .inspect() too - currently they are a huge ugly blob at the top of test_api.py | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 324836533 | |
https://github.com/simonw/datasette/issues/247#issuecomment-390689406 | https://api.github.com/repos/simonw/datasette/issues/247 | 390689406 | MDEyOklzc3VlQ29tbWVudDM5MDY4OTQwNg== | 11912854 | 2018-05-21T15:29:31Z | 2018-05-21T15:29:31Z | NONE | I've changed my mind about the way to support external connectors aside of SQLite and I'm working in a more simple style that respects the original Datasette, i.e. less refactoring. I present you [a version of Datasette wich supports other database connectors](https://github.com/jsancho-gpl/datasette/tree/external-connectors) and [a Datasette connector for HDF5/PyTables files](https://github.com/jsancho-gpl/datasette-pytables). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 319449852 | |
https://github.com/simonw/datasette/pull/258#issuecomment-390577711 | https://api.github.com/repos/simonw/datasette/issues/258 | 390577711 | MDEyOklzc3VlQ29tbWVudDM5MDU3NzcxMQ== | 247131 | 2018-05-21T07:38:15Z | 2018-05-21T07:38:15Z | NONE | Excellent, I was not aware of the auto redirect to the new hash. My bad This solves my use case. I do agree that your suggested --no-url-hash approach is much neater. I will investigate | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 322741659 |