github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/231#issuecomment-412291395 | https://api.github.com/repos/simonw/datasette/issues/231 | 412291395 | MDEyOklzc3VlQ29tbWVudDQxMjI5MTM5NQ== | 9599 | 2018-08-11T17:54:41Z | 2018-08-11T17:54:41Z | OWNER | I'm going to separate the issue of enabling and disabling plugins from the existence of the `plugins` key. The format will simply be: ``` { "plugins": { "name-of-plugin": { ... any structures you like go here, defined by the plugin ... } } } ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 316323336 | |
https://github.com/simonw/datasette/issues/185#issuecomment-412299013 | https://api.github.com/repos/simonw/datasette/issues/185 | 412299013 | MDEyOklzc3VlQ29tbWVudDQxMjI5OTAxMw== | 9599 | 2018-08-11T20:14:54Z | 2018-08-11T20:14:54Z | OWNER | I've been worrying about how this one relates to #260 - I'd like to validate metadata (to help protect against people e.g. misspelling `license_url` and then being confused when their license isn't displayed properly), but this issue requests the ability to add arbitrary additional keys to the metadata structure. I think the solution is to introduce a metadata key called `extra_metadata_keys` which allows you to specifically list the extra keys that you want to enable. Something like this: ``` { "title": "My title", "source": "Source", "source_url": "https://www.example.com/", "release_date": "2018-04-01", "extra_metadata_keys": ["release_date"] } ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 299760684 | |
https://github.com/simonw/datasette/issues/238#issuecomment-412291437 | https://api.github.com/repos/simonw/datasette/issues/238 | 412291437 | MDEyOklzc3VlQ29tbWVudDQxMjI5MTQzNw== | 9599 | 2018-08-11T17:55:26Z | 2018-08-11T18:02:48Z | OWNER | On further thought, I'd much rather implement this using some kind of metadata plugin hook - see #357 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 317714268 | |
https://github.com/simonw/datasette/issues/188#issuecomment-412291327 | https://api.github.com/repos/simonw/datasette/issues/188 | 412291327 | MDEyOklzc3VlQ29tbWVudDQxMjI5MTMyNw== | 9599 | 2018-08-11T17:53:17Z | 2018-08-11T17:53:17Z | OWNER | Potential problem: the existing `metadata.json` format looks like this: ``` { "title": "Custom title for your index page", "description": "Some description text can go here", "license": "ODbL", "license_url": "https://opendatacommons.org/licenses/odbl/", "databases": { "database1": { "source": "Alternative source", "source_url": "http://example.com/", "tables": { "example_table": { "description_html": "Custom <em>table</em> description", "license": "CC BY 3.0 US", "license_url": "https://creativecommons.org/licenses/by/3.0/us/" } } } } } ``` This doesn't make sense for metadata that is bundled with a specific database - there's no point in having the `databases` key, instead the content of `database1` in the above example should be at the top level. This also means that if you rename the `*.db` file you won't have to edit its metadata at the same time. Calling such an embedded file `metadata.json` when the shape is different could be confusing. Maybe call it `database-metadata.json` instead. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 309047460 | |
https://github.com/simonw/datasette/issues/174#issuecomment-412290986 | https://api.github.com/repos/simonw/datasette/issues/174 | 412290986 | MDEyOklzc3VlQ29tbWVudDQxMjI5MDk4Ng== | 9599 | 2018-08-11T17:46:51Z | 2018-08-11T17:46:51Z | OWNER | This was fixed in https://github.com/simonw/datasette/commit/89d9fbb91bfc0dd9091b34dbf3cf540ab849cc44 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 281197863 |