github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/698#issuecomment-608087223 | https://api.github.com/repos/simonw/datasette/issues/698 | 608087223 | MDEyOklzc3VlQ29tbWVudDYwODA4NzIyMw== | 9599 | 2020-04-02T21:02:25Z | 2020-04-02T21:02:25Z | OWNER | YAML for metadata is relevant to this: #713 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 582517965 | |
https://github.com/simonw/datasette/issues/698#issuecomment-608125928 | https://api.github.com/repos/simonw/datasette/issues/698 | 608125928 | MDEyOklzc3VlQ29tbWVudDYwODEyNTkyOA== | 9599 | 2020-04-02T22:32:41Z | 2020-04-02T22:33:10Z | OWNER | I really want the option to use a `<textarea>` for a specific value. Idea: metadata syntax like this: ```json { "databases": { "my-database": { "queries": { "add_twitter_handle": { "sql": "insert into twitter_handles (username) values (:username)", "write": true, "params": { "username": { "widget": "textarea" } } } } } } } ``` I can ship with some default widgets and provide a plugin hook for registering extra widgets. This opens up some really exciting possibilities for things like map widgets that let you draw polygons. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 582517965 | |
https://github.com/simonw/datasette/pull/703#issuecomment-608137641 | https://api.github.com/repos/simonw/datasette/issues/703 | 608137641 | MDEyOklzc3VlQ29tbWVudDYwODEzNzY0MQ== | 9599 | 2020-04-02T23:08:26Z | 2020-04-02T23:08:26Z | OWNER | I'm going to split canned queries out from arbitrary queries to make the code easier to follow. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 585597133 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608020485 | https://api.github.com/repos/simonw/datasette/issues/713 | 608020485 | MDEyOklzc3VlQ29tbWVudDYwODAyMDQ4NQ== | 9599 | 2020-04-02T18:11:53Z | 2020-04-02T18:11:53Z | OWNER | I can add https://pypi.org/project/PyYAML/ as a dependency for this. One open question: how best to tell the difference between a JSON and a YAML file? I'd rather not do it based on a file extension. Since I'm going to read the whole file into memory anyway (rather than try to stream it) and I only load it once at startup, maybe I try to parse with one and, if there's a parsing error, try the other one before giving up? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608021760 | https://api.github.com/repos/simonw/datasette/issues/713 | 608021760 | MDEyOklzc3VlQ29tbWVudDYwODAyMTc2MA== | 9599 | 2020-04-02T18:14:20Z | 2020-04-02T18:14:58Z | OWNER | I'm going to depend on ~=5.3 https://github.com/yaml/pyyaml/blob/master/CHANGES - though I could probably depend on a much wider set of versions (or maybe even no pinned minimum version at all). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608022801 | https://api.github.com/repos/simonw/datasette/issues/713 | 608022801 | MDEyOklzc3VlQ29tbWVudDYwODAyMjgwMQ== | 9599 | 2020-04-02T18:16:23Z | 2020-04-02T18:16:23Z | OWNER | I'm going to try to parse as JSON first, then fall back to YAML, then error. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608023877 | https://api.github.com/repos/simonw/datasette/issues/713 | 608023877 | MDEyOklzc3VlQ29tbWVudDYwODAyMzg3Nw== | 9599 | 2020-04-02T18:18:29Z | 2020-04-02T18:19:43Z | OWNER | Don't forget to fix the code in publish that loads and modifies metadata, e.g.: https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/utils/__init__.py#L361-L367 And: https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/publish/heroku.py#L156-L168 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608062703 | https://api.github.com/repos/simonw/datasette/issues/713 | 608062703 | MDEyOklzc3VlQ29tbWVudDYwODA2MjcwMw== | 9599 | 2020-04-02T19:35:53Z | 2020-04-02T19:35:53Z | OWNER | https://github.com/simonw/datasette/blob/6717c719dd36dc2adc0f9da38a8c8e08129e96b4/datasette/utils/__init__.py#L795-L803 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608062899 | https://api.github.com/repos/simonw/datasette/issues/713 | 608062899 | MDEyOklzc3VlQ29tbWVudDYwODA2Mjg5OQ== | 9599 | 2020-04-02T19:36:17Z | 2020-04-02T19:36:17Z | OWNER | Documentation: https://datasette.readthedocs.io/en/latest/metadata.html#using-yaml-for-metadata | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 592829135 | |
https://github.com/simonw/datasette/pull/714#issuecomment-608033652 | https://api.github.com/repos/simonw/datasette/issues/714 | 608033652 | MDEyOklzc3VlQ29tbWVudDYwODAzMzY1Mg== | 9599 | 2020-04-02T18:37:08Z | 2020-04-02T18:37:08Z | OWNER | Writing unit tests for this is tricky as the YAML loading happens in the CLI code, but most of my existing unit tests skip that step and run directly against a Datasette instance. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 592844348 |