github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/731#issuecomment-618758326 | https://api.github.com/repos/simonw/datasette/issues/731 | 618758326 | MDEyOklzc3VlQ29tbWVudDYxODc1ODMyNg== | 25778 | 2020-04-24T01:55:00Z | 2020-04-24T01:55:00Z | CONTRIBUTOR | Mounting `./static` at `/static` seems the simplest way. Saves you the trouble of deciding what else (`img` for example) gets special treatment. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 605110015 | |
https://github.com/simonw/datasette/issues/731#issuecomment-618772317 | https://api.github.com/repos/simonw/datasette/issues/731 | 618772317 | MDEyOklzc3VlQ29tbWVudDYxODc3MjMxNw== | 9599 | 2020-04-24T02:49:46Z | 2020-04-24T02:49:46Z | OWNER | Yeah I'll do that. My original thinking on allowing the `--static` option to mount other things to the root is that it would make it easy for people to add HTML "pages" to their site - like https://www.niche-museums.com/map for example. But I've proposed a better solution for that here: #648 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 605110015 | |
https://github.com/simonw/datasette/issues/648#issuecomment-618775028 | https://api.github.com/repos/simonw/datasette/issues/648 | 618775028 | MDEyOklzc3VlQ29tbWVudDYxODc3NTAyOA== | 9599 | 2020-04-24T03:01:32Z | 2020-04-24T03:01:32Z | OWNER | Now that I've closed #577 this should be pretty easy to implement. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 534492501 | |
https://github.com/simonw/datasette/issues/648#issuecomment-618775631 | https://api.github.com/repos/simonw/datasette/issues/648 | 618775631 | MDEyOklzc3VlQ29tbWVudDYxODc3NTYzMQ== | 9599 | 2020-04-24T03:03:35Z | 2020-04-24T03:03:35Z | OWNER | > Stretch goal: it would be neat if these pages could return custom HTTP headers (eg content-type) and maybe even status codes (eg for redirects) somehow. I think I could do that with a custom template function - if that function is called during the render then we follow those instructions instead of returning the rendered HTML. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 534492501 | |
https://github.com/dogsheep/dogsheep-photos/issues/12#issuecomment-618796564 | https://api.github.com/repos/dogsheep/dogsheep-photos/issues/12 | 618796564 | MDEyOklzc3VlQ29tbWVudDYxODc5NjU2NA== | 9599 | 2020-04-24T04:35:25Z | 2020-04-24T04:35:25Z | MEMBER | Code: https://github.com/dogsheep/photos-to-sqlite/blob/a388cf1f1b6b67752d669466cda8b171b6582171/photos_to_sqlite/cli.py#L109-L114 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 606033104 | |
https://github.com/simonw/datasette/issues/648#issuecomment-619259859 | https://api.github.com/repos/simonw/datasette/issues/648 | 619259859 | MDEyOklzc3VlQ29tbWVudDYxOTI1OTg1OQ== | 9599 | 2020-04-24T22:10:34Z | 2020-04-24T22:10:34Z | OWNER | The trickiest part here is the 404 logic. It's spread out through a couple of places right now. It's in `datasette.utils.asgi.AsgiRouter`: https://github.com/simonw/datasette/blob/227bb3e91fe34811a9374150798643a5af98ed79/datasette/utils/asgi.py#L98-L134 Then also in the `DatasetteRouter subclass of that: https://github.com/simonw/datasette/blob/227bb3e91fe34811a9374150798643a5af98ed79/datasette/app.py#L736-L757 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 534492501 | |
https://github.com/simonw/datasette/issues/648#issuecomment-619263600 | https://api.github.com/repos/simonw/datasette/issues/648 | 619263600 | MDEyOklzc3VlQ29tbWVudDYxOTI2MzYwMA== | 9599 | 2020-04-24T22:23:13Z | 2020-04-24T22:23:13Z | OWNER | Idea: `handle_404` can hand certain not found errors off to `handle_500` so it can render them correctly; https://github.com/simonw/datasette/blob/227bb3e91fe34811a9374150798643a5af98ed79/datasette/app.py#L748-L765 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 534492501 |