github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/141#issuecomment-620970547 | https://api.github.com/repos/simonw/datasette/issues/141 | 620970547 | MDEyOklzc3VlQ29tbWVudDYyMDk3MDU0Nw== | 9599 | 2020-04-29T03:27:37Z | 2020-04-29T03:27:54Z | OWNER | This bug raised its head again in #744 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 275814941 | |
https://github.com/simonw/datasette/issues/698#issuecomment-621036032 | https://api.github.com/repos/simonw/datasette/issues/698 | 621036032 | MDEyOklzc3VlQ29tbWVudDYyMTAzNjAzMg== | 9599 | 2020-04-29T07:29:52Z | 2020-04-29T07:29:52Z | OWNER | What should happen when a query has been successfully executed? That depends on the query. Some queries may wish to redirect to another page. Other queries might want to show a custom message. There should at least be a default message saying the query has been executed. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 582517965 | |
https://github.com/simonw/datasette/issues/698#issuecomment-621037724 | https://api.github.com/repos/simonw/datasette/issues/698 | 621037724 | MDEyOklzc3VlQ29tbWVudDYyMTAzNzcyNA== | 9599 | 2020-04-29T07:34:02Z | 2020-04-29T07:34:02Z | OWNER | Concept for displaying a success message: <img width="662" alt="fixtures__compound_three_primary_keys__1_001_rows" src="https://user-images.githubusercontent.com/9599/80571201-0a1b4f00-89b1-11ea-8688-2e3e4304e475.png"> CSS: ```css .success { padding: 1em; border: 1px solid green; background-color: #c7fbc7; } | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 582517965 | |
https://github.com/simonw/datasette/issues/698#issuecomment-621041812 | https://api.github.com/repos/simonw/datasette/issues/698 | 621041812 | MDEyOklzc3VlQ29tbWVudDYyMTA0MTgxMg== | 9599 | 2020-04-29T07:42:48Z | 2020-04-29T07:42:48Z | OWNER | Need to figure out what the `.json` mode for this looks like - and if there's a `.csv` mode (I think not). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 582517965 | |
https://github.com/simonw/datasette/pull/703#issuecomment-621045107 | https://api.github.com/repos/simonw/datasette/issues/703 | 621045107 | MDEyOklzc3VlQ29tbWVudDYyMTA0NTEwNw== | 9599 | 2020-04-29T07:49:35Z | 2020-04-29T07:49:35Z | OWNER | Adding some still-to-do items to a checklist in the description. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 585597133 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620969639 | https://api.github.com/repos/simonw/datasette/issues/744 | 620969639 | MDEyOklzc3VlQ29tbWVudDYyMDk2OTYzOQ== | 9599 | 2020-04-29T03:23:31Z | 2020-04-29T03:23:31Z | OWNER | Is it possible that your `/tmp` directory is on a different volume from the `template` folder? That could cause a problem with the symlinks. Here's the code in question: https://github.com/simonw/datasette/blob/89c4ddd4828623888e91a1d2cb396cba12d4e7b4/datasette/utils/__init__.py#L595-L609 It looks to me like we were expecting an `OSError` but in your environment you got a `shutil.Error` instead. So a fix could be to capture that error as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620970159 | https://api.github.com/repos/simonw/datasette/issues/744 | 620970159 | MDEyOklzc3VlQ29tbWVudDYyMDk3MDE1OQ== | 9599 | 2020-04-29T03:25:45Z | 2020-04-29T03:25:45Z | OWNER | https://docs.python.org/3/library/shutil.html#shutil.copytree says that `shutil.Error` should be raised here, so I think this is a bug in the `link_or_copy_directory` function. I don't have an environment that can replicate this bug. @aborruso I'm going to ship a fix in a branch that you can test against. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620970475 | https://api.github.com/repos/simonw/datasette/issues/744 | 620970475 | MDEyOklzc3VlQ29tbWVudDYyMDk3MDQ3NQ== | 9599 | 2020-04-29T03:27:20Z | 2020-04-29T03:27:20Z | OWNER | This exception handling was introduced in #141 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-620971526 | https://api.github.com/repos/simonw/datasette/issues/744 | 620971526 | MDEyOklzc3VlQ29tbWVudDYyMDk3MTUyNg== | 9599 | 2020-04-29T03:32:14Z | 2020-04-29T03:32:14Z | OWNER | @aborruso I think I have a branch with a fix - could you try it out? Install the new branch like this: ``` pip install https://github.com/simonw/datasette/archive/issue-744.zip ``` Then try running `datasette publish heroku` again. If this fixes your bug I'll merge that pull request! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-621008152 | https://api.github.com/repos/simonw/datasette/issues/744 | 621008152 | MDEyOklzc3VlQ29tbWVudDYyMTAwODE1Mg== | 30607 | 2020-04-29T06:05:02Z | 2020-04-29T06:05:02Z | NONE | Hi @simonw , I have installed it and I have the below errors. > Is it possible that your /tmp directory is on a different volume from the template folder? That could cause a problem with the symlinks. No, /tmp folder is in the same volume. Thank you ``` Traceback (most recent call last): File "/home/aborruso/.local/lib/python3.7/site-packages/datasette/utils/__init__.py", line 607, in link_or_copy_directory shutil.copytree(src, dst, copy_function=os.link) File "/usr/lib/python3.7/shutil.py", line 365, in copytree raise Error(errors) shutil.Error: [('/var/youtubeComunePalermo/processing/./template/base.html', '/tmp/tmpcqv_1i5d/templates/base.html', "[Errno 18] Invalid cross-device link: '/var/youtubeComunePalermo/processing/./template/base.html' -> '/tmp/tmpcqv_1i5d/templates/base.html'"), ('/var/youtubeComunePalermo/processing/./template/index.html', '/tmp/tmpcqv_1i5d/templates/index.html', "[Errno 18] Invalid cross-device link: '/var/youtubeComunePalermo/processing/./template/index.html' -> '/tmp/tmpcqv_1i5d/templates/index.html'")] During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/aborruso/.local/bin/datasette", line 8, in <module> sys.exit(cli()) File "/home/aborruso/.local/lib/python3.7/site-packages/click/core.py", line 829, in __call__ return self.main(*args, **kwargs) File "/home/aborruso/.local/lib/python3.7/site-packages/click/core.py", line 782, in main rv = self.invoke(ctx) File "/home/aborruso/.local/lib/python3.7/site-packages/click/core.py", line 1259, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/home/aborruso/.local/lib/python3.7/site-packages/click/core.py", line 1259, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/home/aborruso/.local/lib/python3.7/site-packages/click/core.py", line 1066, in invoke return ctx.invoke(self.callback, **ctx.params) File "/home/aborruso/.local/lib/python3.7/site-pa… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-621011554 | https://api.github.com/repos/simonw/datasette/issues/744 | 621011554 | MDEyOklzc3VlQ29tbWVudDYyMTAxMTU1NA== | 30607 | 2020-04-29T06:17:26Z | 2020-04-29T06:17:26Z | NONE | A stupid note: I have no `tmpcqv_1i5d` folder in in `/tmp`. It seems to me that it does not create any `/tmp/tmpcqv_1i5d/templates` folder (or other name folder, inside /tmp) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-621027697 | https://api.github.com/repos/simonw/datasette/issues/744 | 621027697 | MDEyOklzc3VlQ29tbWVudDYyMTAyNzY5Nw== | 9599 | 2020-04-29T07:08:09Z | 2020-04-29T07:08:09Z | OWNER | What operating system are you using? I need to figure out a way to replicate this bug. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/744#issuecomment-621030783 | https://api.github.com/repos/simonw/datasette/issues/744 | 621030783 | MDEyOklzc3VlQ29tbWVudDYyMTAzMDc4Mw== | 30607 | 2020-04-29T07:16:27Z | 2020-04-29T07:16:27Z | NONE | Hi @simonw it's debian as Windows Subsystem for Linux ``` PRETTY_NAME="Pengwin" NAME="Pengwin" VERSION_ID="10" VERSION="10 (buster)" ID=debian ID_LIKE=debian HOME_URL="https://github.com/whitewaterfoundry/Pengwin" SUPPORT_URL="https://github.com/whitewaterfoundry/Pengwin" BUG_REPORT_URL="https://github.com/whitewaterfoundry/Pengwin" VERSION_CODENAME=buster ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608058890 | |
https://github.com/simonw/datasette/issues/745#issuecomment-620972158 | https://api.github.com/repos/simonw/datasette/issues/745 | 620972158 | MDEyOklzc3VlQ29tbWVudDYyMDk3MjE1OA== | 9599 | 2020-04-29T03:35:25Z | 2020-04-29T03:35:25Z | OWNER | Relevant documentation: https://datasette.readthedocs.io/en/stable/performance.html#hashed-url-mode | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608613033 | |
https://github.com/simonw/datasette/pull/746#issuecomment-621027374 | https://api.github.com/repos/simonw/datasette/issues/746 | 621027374 | MDEyOklzc3VlQ29tbWVudDYyMTAyNzM3NA== | 9599 | 2020-04-29T07:07:23Z | 2020-04-29T07:07:23Z | OWNER | It looks like this isn't the right fix: https://github.com/simonw/datasette/issues/744#issuecomment-621008152 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 608752766 |