github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/906#issuecomment-663720907 | https://api.github.com/repos/simonw/datasette/issues/906 | 663720907 | MDEyOklzc3VlQ29tbWVudDY2MzcyMDkwNw== | 9599 | 2020-07-24T20:29:24Z | 2020-07-24T20:29:24Z | OWNER | Here are the existing test cases: https://github.com/simonw/datasette/blob/2115d7e3457b48b3cf9c81551b9fed2d0e9cd111/tests/test_utils.py#L468-L505 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 665400224 | |
https://github.com/simonw/datasette/pull/902#issuecomment-663724425 | https://api.github.com/repos/simonw/datasette/issues/902 | 663724425 | MDEyOklzc3VlQ29tbWVudDY2MzcyNDQyNQ== | 9599 | 2020-07-24T20:38:42Z | 2020-07-24T20:38:42Z | OWNER | Thanks for spotting this! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 662439034 | |
https://github.com/simonw/datasette/issues/456#issuecomment-663724675 | https://api.github.com/repos/simonw/datasette/issues/456 | 663724675 | MDEyOklzc3VlQ29tbWVudDY2MzcyNDY3NQ== | 9599 | 2020-07-24T20:39:17Z | 2020-07-24T20:39:17Z | OWNER | Yes this is still a bug! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 442327592 | |
https://github.com/simonw/datasette/issues/907#issuecomment-663726146 | https://api.github.com/repos/simonw/datasette/issues/907 | 663726146 | MDEyOklzc3VlQ29tbWVudDY2MzcyNjE0Ng== | 9599 | 2020-07-24T20:43:27Z | 2020-07-24T20:43:27Z | OWNER | It might be good to have a little interactive tool which helps debug these things, since there are quite a few edge-cases and the damage caused if people use them incorrectly is substantial. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 665403403 | |
https://github.com/simonw/datasette/issues/908#issuecomment-663726318 | https://api.github.com/repos/simonw/datasette/issues/908 | 663726318 | MDEyOklzc3VlQ29tbWVudDY2MzcyNjMxOA== | 9599 | 2020-07-24T20:43:57Z | 2020-07-24T20:45:38Z | OWNER | I can implement this as a plugin. Or it could ship as part of Datasette, somewhere under the `/-/` namespace like the `PermissionsDebugView` and `MessagesDebugView` tools. I'm going to ship it in Datasette core, to further reinforce the philosophy that debugging tools are important. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 665407663 | |
https://github.com/simonw/datasette/pull/901#issuecomment-663727716 | https://api.github.com/repos/simonw/datasette/issues/901 | 663727716 | MDEyOklzc3VlQ29tbWVudDY2MzcyNzcxNg== | 22429695 | 2020-07-24T20:47:57Z | 2020-07-24T20:47:57Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=h1) Report > Merging [#901](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=desc) into [master](https://codecov.io/gh/simonw/datasette/commit/d9a5ef1c32a4390e398653ebfd570f8e1a03d93e&el=desc) will **decrease** coverage by `0.00%`. > The diff coverage is `83.33%`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/901/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #901 +/- ## ========================================== - Coverage 83.41% 83.41% -0.01% ========================================== Files 27 27 Lines 3636 3642 +6 ========================================== + Hits 3033 3038 +5 - Misses 603 604 +1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/datasette/pull/901/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `93.76% <66.66%> (-0.18%)` | :arrow_down: | | [datasette/filters.py](https://codecov.io/gh/simonw/datasette/pull/901/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2ZpbHRlcnMucHk=) | `94.35% <100.00%> (+0.09%)` | :arrow_up: | | [datasette/utils/asgi.py](https://codecov.io/gh/simonw/datasette/pull/901/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3V0aWxzL2FzZ2kucHk=) | `91.47% <0.00%> (+0.07%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=footer). Last update [d9a5ef1.… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 662322234 | |
https://github.com/simonw/datasette/issues/907#issuecomment-663764203 | https://api.github.com/repos/simonw/datasette/issues/907 | 663764203 | MDEyOklzc3VlQ29tbWVudDY2Mzc2NDIwMw== | 9599 | 2020-07-24T22:53:07Z | 2020-07-24T22:53:07Z | OWNER | Actually that is already covered here: https://github.com/simonw/datasette/blob/6be5654ffab282e8cf39cc138ba2d4496ebc7407/docs/authentication.rst#L158 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 665403403 | |
https://github.com/simonw/datasette/issues/908#issuecomment-663765308 | https://api.github.com/repos/simonw/datasette/issues/908 | 663765308 | MDEyOklzc3VlQ29tbWVudDY2Mzc2NTMwOA== | 9599 | 2020-07-24T22:57:15Z | 2020-07-24T22:57:15Z | OWNER | Tool lives at https://latest.datasette.io/-/allow-debug | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 665407663 | |
https://github.com/simonw/datasette/issues/906#issuecomment-663767678 | https://api.github.com/repos/simonw/datasette/issues/906 | 663767678 | MDEyOklzc3VlQ29tbWVudDY2Mzc2NzY3OA== | 9599 | 2020-07-24T23:07:22Z | 2020-07-24T23:07:22Z | OWNER | Illustration of current system: https://latest.datasette.io/-/allow-debug?actor=%7B%0D%0A++++%22id%22%3A+%22terry%22%0D%0A%7D&allow=null - `null` allows https://latest.datasette.io/-/allow-debug?actor=%7B%0D%0A++++%22id%22%3A+%22terry%22%0D%0A%7D&allow={} - `{}` denies | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 665400224 |