github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/956#issuecomment-683212246 | https://api.github.com/repos/simonw/datasette/issues/956 | 683212246 | MDEyOklzc3VlQ29tbWVudDY4MzIxMjI0Ng== | 9599 | 2020-08-29T01:21:26Z | 2020-08-29T01:21:26Z | OWNER | I added this but I have no idea if I got it right or not: https://github.com/simonw/datasette/blob/c36e287d71d68ecb2a45e9808eede15f19f931fb/.github/workflows/publish.yml#L58-L63 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 688427751 | |
https://github.com/simonw/datasette/issues/956#issuecomment-683212421 | https://api.github.com/repos/simonw/datasette/issues/956 | 683212421 | MDEyOklzc3VlQ29tbWVudDY4MzIxMjQyMQ== | 9599 | 2020-08-29T01:22:23Z | 2020-08-29T01:22:23Z | OWNER | Here's the error message again: > invalid argument `"***/datasette::0.49a0"` for `"-t, --tag"` flag: invalid reference format | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 688427751 | |
https://github.com/simonw/datasette/issues/956#issuecomment-683212960 | https://api.github.com/repos/simonw/datasette/issues/956 | 683212960 | MDEyOklzc3VlQ29tbWVudDY4MzIxMjk2MA== | 9599 | 2020-08-29T01:25:34Z | 2020-08-29T01:25:34Z | OWNER | So I guess this bit is wrong: https://github.com/simonw/datasette/blob/c36e287d71d68ecb2a45e9808eede15f19f931fb/.github/workflows/publish.yml#L71-L73 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 688427751 | |
https://github.com/simonw/datasette/issues/956#issuecomment-683213973 | https://api.github.com/repos/simonw/datasette/issues/956 | 683213973 | MDEyOklzc3VlQ29tbWVudDY4MzIxMzk3Mw== | 9599 | 2020-08-29T01:31:39Z | 2020-08-29T01:31:39Z | OWNER | Here's how the old Travis mechanism worked: https://github.com/simonw/datasette/blob/52eabb019d4051084b21524bd0fd9c2731126985/.travis.yml#L41-L47 So I was assuming that the eqivalent of `$REPO:$TRAVIS_TAG` in GitHub Actions is `$REPO::${GITHUB_REF#refs/tags/}`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 688427751 | |
https://github.com/simonw/datasette/issues/956#issuecomment-683214102 | https://api.github.com/repos/simonw/datasette/issues/956 | 683214102 | MDEyOklzc3VlQ29tbWVudDY4MzIxNDEwMg== | 9599 | 2020-08-29T01:32:21Z | 2020-08-29T01:32:21Z | OWNER | Maybe the bug here is the double colon? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 688427751 | |
https://github.com/simonw/datasette/issues/957#issuecomment-683355508 | https://api.github.com/repos/simonw/datasette/issues/957 | 683355508 | MDEyOklzc3VlQ29tbWVudDY4MzM1NTUwOA== | 9599 | 2020-08-29T23:54:01Z | 2020-08-29T23:54:01Z | OWNER | Reviewing https://github.com/search?q=user%3Asimonw+%22from+datasette%22&type=Code I spotted these others: ```python # Various: from datasette.utils import path_with_replaced_args from datasette.plugins import pm from datasette.utils import QueryInterrupted from datasette.utils.asgi import Response, Forbidden, NotFound # datasette-publish-vercel: from datasette.publish.common import ( add_common_publish_arguments_and_options, fail_if_publish_binary_not_installed ) from datasette.utils import temporary_docker_directory # datasette-insert from datasette.utils import actor_matches_allow, sqlite3 # obsolete: russian-ira-facebook-ads-datasette from datasette.utils import TableFilter # simonw/museums from datasette.utils.asgi import asgi_send # datasette-media from datasette.utils.asgi import Response, asgi_send_file # datasette/tests/plugins/my_plugin.py from datasette.facets import Facet # datasette-graphql from datasette.views.table import TableView ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 688622148 | |
https://github.com/simonw/datasette/issues/957#issuecomment-683355598 | https://api.github.com/repos/simonw/datasette/issues/957 | 683355598 | MDEyOklzc3VlQ29tbWVudDY4MzM1NTU5OA== | 9599 | 2020-08-29T23:55:10Z | 2020-08-29T23:55:34Z | OWNER | Of these I think I'm going to promote the following to being importable directly `from datasette`: - `from datasette.app import Datasette` - `from datasette.utils import QueryInterrupted` - `from datasette.utils.asgi import Response, Forbidden, NotFound` - `from datasette.utils import actor_matches_allow` All of the rest are infrequently used enough (or clearly named enough) that I'm happy to leave them as-is. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 688622148 |