github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/sqlite-utils/issues/180#issuecomment-699718788 | https://api.github.com/repos/simonw/sqlite-utils/issues/180 | 699718788 | MDEyOklzc3VlQ29tbWVudDY5OTcxODc4OA== | 9599 | 2020-09-28T01:11:45Z | 2020-09-28T01:11:45Z | OWNER | https://hypothesis.readthedocs.io/ | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 709861194 | |
https://github.com/simonw/sqlite-utils/issues/181#issuecomment-699762881 | https://api.github.com/repos/simonw/sqlite-utils/issues/181 | 699762881 | MDEyOklzc3VlQ29tbWVudDY5OTc2Mjg4MQ== | 9599 | 2020-09-28T04:29:23Z | 2020-09-28T04:29:23Z | OWNER | Relevant code: https://github.com/simonw/sqlite-utils/blob/94fc62857ee2655a21d85f6dae84b67bbfa5956d/sqlite_utils/db.py#L331-L367 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 709920027 | |
https://github.com/simonw/datasette/pull/977#issuecomment-700012161 | https://api.github.com/repos/simonw/datasette/issues/977 | 700012161 | MDEyOklzc3VlQ29tbWVudDcwMDAxMjE2MQ== | 22429695 | 2020-09-28T13:37:44Z | 2020-09-28T13:37:44Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/977?src=pr&el=h1) Report > Merging [#977](https://codecov.io/gh/simonw/datasette/pull/977?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/9a6d0dce282e7fb58c5610e24c74098c923abfdc?el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/977/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/977?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## main #977 +/- ## ======================================= Coverage 84.27% 84.27% ======================================= Files 28 28 Lines 3847 3847 ======================================= Hits 3242 3242 Misses 605 605 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/977?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/977?src=pr&el=footer). Last update [9a6d0dc...5c01344](https://codecov.io/gh/simonw/datasette/pull/977?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710269200 | |
https://github.com/simonw/datasette/issues/978#issuecomment-700313836 | https://api.github.com/repos/simonw/datasette/issues/978 | 700313836 | MDEyOklzc3VlQ29tbWVudDcwMDMxMzgzNg== | 9599 | 2020-09-28T22:19:05Z | 2020-09-28T22:19:05Z | OWNER | Looks like a bug in this function: https://github.com/simonw/datasette/blob/1f021c37110fc9019b0ef70062c28c335e568ae2/datasette/utils/__init__.py#L269-L274 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710506708 | |
https://github.com/simonw/datasette/issues/978#issuecomment-700314509 | https://api.github.com/repos/simonw/datasette/issues/978 | 700314509 | MDEyOklzc3VlQ29tbWVudDcwMDMxNDUwOQ== | 9599 | 2020-09-28T22:20:51Z | 2020-09-28T22:20:51Z | OWNER | Here's the HTML for the broken example above: ```html <style> @media only screen and (max-width: 576px) { .rows-and-columns td:nth-of-type(1):before { content: "dateutil_parse(\2210 october 2020 3pm\22)"; } .rows-and-columns td:nth-of-type(2):before { content: "dateutil_easter(\222020\22)"; } .rows-and-columns td:nth-of-type(3):before { content: "dateutil_parse_fuzzy(\22This is due 10 september\22)"; } .rows-and-columns td:nth-of-type(4):before { content: "dateutil_parse(\221/2/2020\22)"; } .rows-and-columns td:nth-of-type(5):before { content: "dateutil_parse(\222020-03-04\22)"; } .rows-and-columns td:nth-of-type(6):before { content: "dateutil_parse_dayfirst(\222020-03-04\22)"; } .rows-and-columns td:nth-of-type(7):before { content: "dateutil_easter(2020)"; } } </style> ``` The glitch affects the ones where the quote is followed by digits. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710506708 | |
https://github.com/simonw/datasette/issues/978#issuecomment-700316511 | https://api.github.com/repos/simonw/datasette/issues/978 | 700316511 | MDEyOklzc3VlQ29tbWVudDcwMDMxNjUxMQ== | 9599 | 2020-09-28T22:26:38Z | 2020-09-28T22:26:38Z | OWNER | The fix may be to use `\0022` instead of `\22`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710506708 | |
https://github.com/simonw/datasette/issues/978#issuecomment-700317760 | https://api.github.com/repos/simonw/datasette/issues/978 | 700317760 | MDEyOklzc3VlQ29tbWVudDcwMDMxNzc2MA== | 9599 | 2020-09-28T22:30:25Z | 2020-09-28T22:30:25Z | OWNER | ```python print('\\' + "{:X}".format(ord('"')).zfill(4)) \0022 ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710506708 | |
https://github.com/simonw/datasette/issues/978#issuecomment-700319656 | https://api.github.com/repos/simonw/datasette/issues/978 | 700319656 | MDEyOklzc3VlQ29tbWVudDcwMDMxOTY1Ng== | 9599 | 2020-09-28T22:36:44Z | 2020-09-28T22:36:44Z | OWNER | Weirdly even those leading 0s doesn't fix it: <img width="600" alt="Real-time_HTML_Editor_and_Using_character_escapes_in_markup_and_CSS" src="https://user-images.githubusercontent.com/9599/94492937-44775b00-01a0-11eb-9c5f-e991af620404.png"> But... padding to six characters does! See https://www.w3.org/International/questions/qa-escapes <img width="607" alt="Real-time_HTML_Editor_and_Using_character_escapes_in_markup_and_CSS" src="https://user-images.githubusercontent.com/9599/94492988-61139300-01a0-11eb-8304-bffe448c7d2b.png"> ``` In [32]: print('\\' + "{:X}".format(ord('"')).zfill(6)) \000022 ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710506708 | |
https://github.com/simonw/datasette/issues/978#issuecomment-700320480 | https://api.github.com/repos/simonw/datasette/issues/978 | 700320480 | MDEyOklzc3VlQ29tbWVudDcwMDMyMDQ4MA== | 9599 | 2020-09-28T22:39:18Z | 2020-09-28T22:39:18Z | OWNER | ```python def escape_css_string(s): return _css_re.sub(lambda m: "\\" + ("{:X}".format(ord(m.group())).zfill(6)), s) ``` That fixes it: <img width="363" alt="data__select_dateutil_parse__10_october_2020_3pm____dateutil_easter__2020____dateutil_parse_fuzzy__This_is_due_10_september____dateutil_parse__1_2_2020____dateutil_parse__2020-03-04____dateutil_parse_dayfirst__2020-03-04____dateutil_easter_" src="https://user-images.githubusercontent.com/9599/94493173-c23b6680-01a0-11eb-9468-e972c51b015c.png"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710506708 | |
https://github.com/simonw/datasette/issues/979#issuecomment-700343229 | https://api.github.com/repos/simonw/datasette/issues/979 | 700343229 | MDEyOklzc3VlQ29tbWVudDcwMDM0MzIyOQ== | 9599 | 2020-09-28T23:55:55Z | 2020-09-28T23:55:55Z | OWNER | Here's the code that adds it to the HTML context: https://github.com/simonw/datasette/blob/c11383e6284e000b2641569457efa16ac9e0d6ae/datasette/views/table.py#L835-L837 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710650633 | |
https://github.com/simonw/datasette/issues/979#issuecomment-700343373 | https://api.github.com/repos/simonw/datasette/issues/979 | 700343373 | MDEyOklzc3VlQ29tbWVudDcwMDM0MzM3Mw== | 9599 | 2020-09-28T23:56:27Z | 2020-09-28T23:56:27Z | OWNER | This would benefit https://github.com/simonw/datasette-import-table - which currently ignores the `CREATE TABLE` and derives the schema by inserting rows. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 710650633 |