github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1033#issuecomment-714657366 | https://api.github.com/repos/simonw/datasette/issues/1033 | 714657366 | MDEyOklzc3VlQ29tbWVudDcxNDY1NzM2Ng== | 82988 | 2020-10-22T17:51:29Z | 2020-10-22T17:51:29Z | CONTRIBUTOR | How does `/-/static` relate to [current guidance docs around `static`](https://docs.datasette.io/en/latest/custom_templates.html?highlight=static#serving-static-files) regarding the `--static option` and metadata formulations such as `"extra_js_urls": [ "/static/app.js"]` (I've not managed to get this to work in a Jupyter server proxied set up; the [datasette / jupyter server proxy repo](https://github.com/simonw/jupyterserverproxy-datasette-demo) may provide a useful test example, eg via MyBinder, for folk to crib from?) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 725099777 | |
https://github.com/simonw/datasette/issues/1033#issuecomment-714681365 | https://api.github.com/repos/simonw/datasette/issues/1033 | 714681365 | MDEyOklzc3VlQ29tbWVudDcxNDY4MTM2NQ== | 9599 | 2020-10-22T18:33:48Z | 2020-10-22T18:33:48Z | OWNER | That's a good question - I hadn't considered that. I'm going to open a new issue to have `extra_js_urls` respect the `base_url` setting, since the static files will be served from a different location. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 725099777 | |
https://github.com/simonw/datasette/issues/1041#issuecomment-714682288 | https://api.github.com/repos/simonw/datasette/issues/1041 | 714682288 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjI4OA== | 9599 | 2020-10-22T18:35:15Z | 2020-10-22T18:35:15Z | OWNER | @psychemedia said: https://github.com/simonw/datasette/issues/1033#issuecomment-714657366 > How does `/-/static` relate to [current guidance docs around `static`](https://docs.datasette.io/en/latest/custom_templates.html?highlight=static#serving-static-files) regarding the `--static option` and metadata formulations such as `"extra_js_urls": [ "/static/app.js"]` (I've not managed to get this to work in a Jupyter server proxied set up; the [datasette / jupyter server proxy repo](https://github.com/simonw/jupyterserverproxy-datasette-demo) may provide a useful test example, eg via MyBinder, for folk to crib from?) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 727627923 | |
https://github.com/simonw/datasette/issues/1041#issuecomment-714682825 | https://api.github.com/repos/simonw/datasette/issues/1041 | 714682825 | MDEyOklzc3VlQ29tbWVudDcxNDY4MjgyNQ== | 9599 | 2020-10-22T18:36:10Z | 2020-10-22T18:36:10Z | OWNER | I'll need to update these docs once there's a solution for this in place: https://docs.datasette.io/en/latest/custom_templates.html#serving-static-files | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 727627923 | |
https://github.com/simonw/datasette/issues/1041#issuecomment-714683801 | https://api.github.com/repos/simonw/datasette/issues/1041 | 714683801 | MDEyOklzc3VlQ29tbWVudDcxNDY4MzgwMQ== | 9599 | 2020-10-22T18:37:47Z | 2020-10-22T18:37:47Z | OWNER | I think I'll do this by looking for URLs that start with `/` - since it's also possible to have full `https://...` URLs in that setting. ```json { "extra_css_urls": [ "/static/styles.css" ], "extra_js_urls": [ "/static/app.js" ] } ``` I need to think about the `extra_css_urls` and `extra_js_urls` plugin hooks too: https://docs.datasette.io/en/stable/plugin_hooks.html#extra-css-urls-template-database-table-columns-view-name-request-datasette | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 727627923 | |
https://github.com/simonw/datasette/issues/998#issuecomment-714090965 | https://api.github.com/repos/simonw/datasette/issues/998 | 714090965 | MDEyOklzc3VlQ29tbWVudDcxNDA5MDk2NQ== | 9599 | 2020-10-22T00:54:30Z | 2020-10-22T00:54:30Z | OWNER | Easiest fix for the column action menu positioning - hide them when the user scrolls the containing div: ```javascript document.querySelector('.table-wrapper').addEventListener( 'scroll', () => document.querySelector('.dropdown-menu').style.display = 'none' ); ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 717699884 | |
https://github.com/simonw/datasette/issues/998#issuecomment-714092002 | https://api.github.com/repos/simonw/datasette/issues/998 | 714092002 | MDEyOklzc3VlQ29tbWVudDcxNDA5MjAwMg== | 9599 | 2020-10-22T00:55:10Z | 2020-10-22T00:55:10Z | OWNER | This isn't blocked on #987 - it just means that `datasette-cluster-map` will need to learn to look for `.table-wrapper` first and fall back on the table. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 717699884 | |
https://github.com/simonw/datasette/issues/998#issuecomment-714117534 | https://api.github.com/repos/simonw/datasette/issues/998 | 714117534 | MDEyOklzc3VlQ29tbWVudDcxNDExNzUzNA== | 9599 | 2020-10-22T01:12:06Z | 2020-10-22T01:12:06Z | OWNER | Demo: ![table-scroll](https://user-images.githubusercontent.com/9599/96806421-e74e7e00-13c8-11eb-95fe-44d01e4c2eb3.gif) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 717699884 | |
https://github.com/simonw/datasette/issues/998#issuecomment-714205783 | https://api.github.com/repos/simonw/datasette/issues/998 | 714205783 | MDEyOklzc3VlQ29tbWVudDcxNDIwNTc4Mw== | 9599 | 2020-10-22T03:58:13Z | 2020-10-22T03:58:13Z | OWNER | This is now live here: https://global-power-plants.datasettes.com/global-power-plants/global-power-plants | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 717699884 | |
https://github.com/simonw/datasette/pull/1031#issuecomment-714206875 | https://api.github.com/repos/simonw/datasette/issues/1031 | 714206875 | MDEyOklzc3VlQ29tbWVudDcxNDIwNjg3NQ== | 9599 | 2020-10-22T04:01:19Z | 2020-10-22T04:01:19Z | OWNER | I don't fully understand the bug you're fixing here. Could you provide a bit more explanation? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 724369025 | |
https://github.com/simonw/datasette/pull/1031#issuecomment-714289680 | https://api.github.com/repos/simonw/datasette/issues/1031 | 714289680 | MDEyOklzc3VlQ29tbWVudDcxNDI4OTY4MA== | 299380 | 2020-10-22T07:23:52Z | 2020-10-22T07:23:52Z | NONE | The bug is that currently when there are databases passed in, but no -i flag, e.g. in configuration directory mode, inclusion in inspect-data.json does not automatically cause databases to be considered immutable, as described in the documentation. The reason is that the -i flag is specified multiple=True, which means when it is not passed in we will get an empty list [], rather than None. So the current code decides that no databases are immutable rather than falling back to inspect-data.json -- as is presumably intended. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 724369025 | |
https://github.com/simonw/datasette/pull/1040#issuecomment-714206533 | https://api.github.com/repos/simonw/datasette/issues/1040 | 714206533 | MDEyOklzc3VlQ29tbWVudDcxNDIwNjUzMw== | 9599 | 2020-10-22T04:00:25Z | 2020-10-22T04:00:25Z | OWNER | I've decided not to offer a configuration option to turn this off. I'll reconsider if someone asks for it. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 726910999 | |
https://github.com/simonw/sqlite-utils/issues/171#issuecomment-714208848 | https://api.github.com/repos/simonw/sqlite-utils/issues/171 | 714208848 | MDEyOklzc3VlQ29tbWVudDcxNDIwODg0OA== | 9599 | 2020-10-22T04:07:14Z | 2020-10-22T04:07:14Z | OWNER | I made the `--load-extension` command much more widely supported in #137 - which should be useful for anyone who wants to use this extension. It's a bit too obscure for me to want to add direct Python library support relating to that extension though. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 707407567 | |
https://github.com/simonw/sqlite-utils/issues/171#issuecomment-714219725 | https://api.github.com/repos/simonw/sqlite-utils/issues/171 | 714219725 | MDEyOklzc3VlQ29tbWVudDcxNDIxOTcyNQ== | 649467 | 2020-10-22T04:38:35Z | 2020-10-22T04:38:35Z | NONE | Thanks. As I said, I think the result (being able to query tree structures like ancestors and descendants) is more important than the implementation, and I agree that this particular sqlite extension is too obscure. Just providing an sqlite utility to build or rebuild a transitive closure table might be more generically useful. I find that hierarchical data shows up pretty frequently in some data science problems. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 707407567 | |
https://github.com/simonw/sqlite-utils/issues/173#issuecomment-714758139 | https://api.github.com/repos/simonw/sqlite-utils/issues/173 | 714758139 | MDEyOklzc3VlQ29tbWVudDcxNDc1ODEzOQ== | 9599 | 2020-10-22T20:57:56Z | 2020-10-22T20:57:56Z | OWNER | I could use `ijson` to provide a progress bar for JSON arrays too. I'd prefer to keep that as an optional dependency though, since `sqlite-utils` is a library dependency for many other projects and it would be using `ijson` purely for the CLI component. Here's how to iterate through a list of objects being read from a file: ```python import json parser = ijson.items(open( "/tmp/list.json" ), "item") for object in parser: # ... ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 707478649 |