github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1543#issuecomment-986768401 | https://api.github.com/repos/simonw/datasette/issues/1543 | 986768401 | IC_kwDOBm6k_c460OQR | 22429695 | 2021-12-06T13:18:48Z | 2021-12-06T13:18:48Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1543](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (353a851) into [main](https://codecov.io/gh/simonw/datasette/commit/7c02be2ee94cc64b120cc58b7a72cd387031f287?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (7c02be2) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1543/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1543 +/- ## ======================================= Coverage 91.84% 91.84% ======================================= Files 34 34 Lines 4438 4438 ======================================= Hits 4076 4076 Misses 362 362 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1072135269 | |
https://github.com/simonw/sqlite-utils/issues/350#issuecomment-987015063 | https://api.github.com/repos/simonw/sqlite-utils/issues/350 | 987015063 | IC_kwDOCGYnMM461KeX | 9599 | 2021-12-06T17:55:42Z | 2021-12-06T17:55:42Z | OWNER | API could be this: ```python id = db["columns"].lookup( {"namespace": namespace_id, "name": column}, cache=True ) ``` This could default to a 100 item LRU cache. You could perhaps modify that with `cache_size=500` or with `cache_size=None` to disable the size limit on that cache. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1072435124 | |
https://github.com/simonw/sqlite-utils/issues/350#issuecomment-987015327 | https://api.github.com/repos/simonw/sqlite-utils/issues/350 | 987015327 | IC_kwDOCGYnMM461Kif | 9599 | 2021-12-06T17:56:05Z | 2021-12-06T17:56:05Z | OWNER | Should I implement this remember to apply the optimization in `git-history`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1072435124 | |
https://github.com/simonw/sqlite-utils/issues/350#issuecomment-987016019 | https://api.github.com/repos/simonw/sqlite-utils/issues/350 | 987016019 | IC_kwDOCGYnMM461KtT | 9599 | 2021-12-06T17:56:57Z | 2021-12-06T17:56:57Z | OWNER | Would be interesting to micro-benchmark this to get an idea for how much of a performance boost it is, since the indexed SQLite lookups used by `table.lookup()` should be really fast already. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1072435124 | |
https://github.com/simonw/sqlite-utils/issues/349#issuecomment-987349633 | https://api.github.com/repos/simonw/sqlite-utils/issues/349 | 987349633 | IC_kwDOCGYnMM462cKB | 9599 | 2021-12-06T23:19:28Z | 2021-12-06T23:19:28Z | OWNER | (I ended up not needing this here since `.lookup()` already creates a unique index on `_item_id` for you. Still could be a useful feature though.) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1071531082 |