github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055993700 | https://api.github.com/repos/simonw/sqlite-utils/issues/408 | 1055993700 | IC_kwDOCGYnMM4-8S9k | 9599 | 2022-03-02T00:08:10Z | 2022-03-02T00:08:10Z | OWNER | I thought I'd made it so `deterministic=True` would be silently ignored in environments that don't support it, but clearly I missed a case here! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1145882578 | |
https://github.com/simonw/sqlite-utils/issues/343#issuecomment-1055991226 | https://api.github.com/repos/simonw/sqlite-utils/issues/343 | 1055991226 | IC_kwDOCGYnMM4-8SW6 | 9599 | 2022-03-02T00:03:47Z | 2022-03-02T00:03:47Z | OWNER | Oops, broke mypy: ``` sqlite_utils/db.py:2600: error: Incompatible default for argument "hash_id_columns" (default has type "Default", argument has type "Optional[Iterable[str]]") Found 1 error in 1 file (checked 49 source files) ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1063388037 | |
https://github.com/simonw/sqlite-utils/issues/343#issuecomment-1055992544 | https://api.github.com/repos/simonw/sqlite-utils/issues/343 | 1055992544 | IC_kwDOCGYnMM4-8Srg | 9599 | 2022-03-02T00:06:10Z | 2022-03-02T00:06:10Z | OWNER | Updated documentation: https://sqlite-utils.datasette.io/en/latest/python-api.html#setting-an-id-based-on-the-hash-of-the-row-contents Documentation for the renamed `utils.hash_record()` function: https://sqlite-utils.datasette.io/en/latest/reference.html#sqlite-utils-utils-hash-record | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1063388037 | |
https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055995100 | https://api.github.com/repos/simonw/sqlite-utils/issues/408 | 1055995100 | IC_kwDOCGYnMM4-8TTc | 9599 | 2022-03-02T00:10:41Z | 2022-03-02T00:10:41Z | OWNER | Here's the code in question: https://github.com/simonw/sqlite-utils/blob/521921b849003ed3742338f76f9d47ff3d95eaf3/sqlite_utils/db.py#L384-L394 It's checking for Python 3.8, because that's the version of Python that added the `deterministic=True` option: https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.create_function But from your error message it looks like it should be checking the SQLite version too. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1145882578 | |
https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055996626 | https://api.github.com/repos/simonw/sqlite-utils/issues/408 | 1055996626 | IC_kwDOCGYnMM4-8TrS | 9599 | 2022-03-02T00:12:21Z | 2022-03-02T00:12:21Z | OWNER | Here's the SQLite changelog mentioning that it was added in 3.8.3: https://www.sqlite.org/changes.html#version_3_8_3 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1145882578 | |
https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1056001414 | https://api.github.com/repos/simonw/sqlite-utils/issues/408 | 1056001414 | IC_kwDOCGYnMM4-8U2G | 9599 | 2022-03-02T00:20:26Z | 2022-03-02T00:20:26Z | OWNER | I need a `db.sqlite_version` property to implement this check. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1145882578 |