github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/432#issuecomment-482876432 | https://api.github.com/repos/simonw/datasette/issues/432 | 482876432 | MDEyOklzc3VlQ29tbWVudDQ4Mjg3NjQzMg== | 9599 | 2019-04-13T20:06:32Z | 2019-04-13T20:06:32Z | OWNER | This has a bug which isn't being caught by the unit tests (yet) - facet suggestion suggests facets that have already been enabled: <img width="845" alt="fixtures__facetable__15_rows" src="https://user-images.githubusercontent.com/9599/56084775-eceb0100-5dec-11e9-8d98-24f1ea1862eb.png"> There is also a test failure due to missing plugin hook documentation. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 432893491 | |
https://github.com/simonw/datasette/pull/432#issuecomment-484584234 | https://api.github.com/repos/simonw/datasette/issues/432 | 484584234 | MDEyOklzc3VlQ29tbWVudDQ4NDU4NDIzNA== | 9599 | 2019-04-18T16:33:52Z | 2019-04-18T16:33:52Z | OWNER | It would be nice to decouple the `request` object from the `Facet` class. The request is needed for two things at the moment: * To decide if a specific facet bucket has been selected or not * To construct the `toggle_url` for turning the selection on or off Can I pull those needs out of the Facet class somehow? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 432893491 | |
https://github.com/simonw/datasette/pull/432#issuecomment-488595724 | https://api.github.com/repos/simonw/datasette/issues/432 | 488595724 | MDEyOklzc3VlQ29tbWVudDQ4ODU5NTcyNA== | 45057 | 2019-05-02T08:50:53Z | 2019-05-02T08:50:53Z | CONTRIBUTOR | > Can I pull those needs out of the Facet class somehow? I was thinking that it might be handy for datasette to have a request object which wraps the Sanic Request. This could include the datasette-specific querystring decoding and the `special_args` parsing from TableView.data. This would mean that we could expose the request object to plugin hooks without coupling them to Sanic. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 432893491 | |
https://github.com/simonw/datasette/pull/432#issuecomment-488874364 | https://api.github.com/repos/simonw/datasette/issues/432 | 488874364 | MDEyOklzc3VlQ29tbWVudDQ4ODg3NDM2NA== | 9599 | 2019-05-03T00:04:23Z | 2019-05-03T00:04:23Z | OWNER | Abandoning this in favour of #445 - which contains the code from this branch but updated to incorporate recent changes in master. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 432893491 |