github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/699#issuecomment-611879821 | https://api.github.com/repos/simonw/datasette/issues/699 | 611879821 | MDEyOklzc3VlQ29tbWVudDYxMTg3OTgyMQ== | 9599 | 2020-04-10T05:06:56Z | 2020-04-10T05:06:56Z | OWNER | Another problem this would solve: if you want multiple authentication mechanisms - GitHub auth for users, `Authorization: bearer xxx` auth for API keys - the order in which they run might end up mattering. I dealt with this a bit in https://github.com/simonw/datasette-auth-github/issues/59 But having an authentication plugin hook - where playing get to decide if a user should be authenticated based on the incoming ASGI scopes - would be neater. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 582526961 | |
https://github.com/simonw/datasette/issues/699#issuecomment-611880250 | https://api.github.com/repos/simonw/datasette/issues/699 | 611880250 | MDEyOklzc3VlQ29tbWVudDYxMTg4MDI1MA== | 9599 | 2020-04-10T05:08:54Z | 2020-04-10T05:08:54Z | OWNER | So maybe this is all handled by plugin hooks? `auth_from_scope(datasette, scope)` would be the main one - for deciding if a user should be authenticated based on data from the scope. How would a permissions hook work though? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 582526961 | |
https://github.com/simonw/datasette/issues/724#issuecomment-612154749 | https://api.github.com/repos/simonw/datasette/issues/724 | 612154749 | MDEyOklzc3VlQ29tbWVudDYxMjE1NDc0OQ== | 9599 | 2020-04-10T18:19:31Z | 2020-04-10T18:19:31Z | OWNER | Actually that code isn't the problem, since `extra_metadata` has not yet been read from `metadata.json` at that point. The bug is here: https://github.com/simonw/datasette/blob/d55fe8cdfc2ce7bc6960bf2507766c1fcd1d31a7/datasette/utils/__init__.py#L362-L368 I need to merge dictionaries in a smarter way. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 598013965 | |
https://github.com/simonw/datasette/issues/724#issuecomment-612155297 | https://api.github.com/repos/simonw/datasette/issues/724 | 612155297 | MDEyOklzc3VlQ29tbWVudDYxMjE1NTI5Nw== | 9599 | 2020-04-10T18:20:53Z | 2020-04-10T18:20:53Z | OWNER | Lot's of recipes for deep dictionary merge on https://stackoverflow.com/q/7204805/6083 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 598013965 | |
https://github.com/simonw/datasette/issues/724#issuecomment-612156367 | https://api.github.com/repos/simonw/datasette/issues/724 | 612156367 | MDEyOklzc3VlQ29tbWVudDYxMjE1NjM2Nw== | 9599 | 2020-04-10T18:23:39Z | 2020-04-10T18:23:39Z | OWNER | I think I'll use https://github.com/clarketm/mergedeep (MIT license) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 598013965 | |
https://github.com/simonw/sqlite-utils/issues/98#issuecomment-612173156 | https://api.github.com/repos/simonw/sqlite-utils/issues/98 | 612173156 | MDEyOklzc3VlQ29tbWVudDYxMjE3MzE1Ng== | 9599 | 2020-04-10T19:03:32Z | 2020-04-10T23:08:28Z | OWNER | Investigate this traceback: ``` Traceback (most recent call last): File "fetch_projects.py", line 60, in <module> fetch_projects(db, token) File "fetch_projects.py", line 41, in fetch_projects db["projects"].upsert(project, pk="id") File "/Users/simonw/.local/share/virtualenvs/big-local-datasette-2jT6nJCT/lib/python3.7/site-packages/sqlite_utils/db.py", line 1139, in upsert conversions=conversions, File "/Users/simonw/.local/share/virtualenvs/big-local-datasette-2jT6nJCT/lib/python3.7/site-packages/sqlite_utils/db.py", line 1168, in upsert_all upsert=True, File "/Users/simonw/.local/share/virtualenvs/big-local-datasette-2jT6nJCT/lib/python3.7/site-packages/sqlite_utils/db.py", line 1107, in insert_all row = list(self.rows_where("rowid = ?", [self.last_rowid]))[0] IndexError: list index out of range ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 597671518 | |
https://github.com/simonw/sqlite-utils/issues/98#issuecomment-612258687 | https://api.github.com/repos/simonw/sqlite-utils/issues/98 | 612258687 | MDEyOklzc3VlQ29tbWVudDYxMjI1ODY4Nw== | 9599 | 2020-04-10T23:08:48Z | 2020-04-10T23:08:48Z | OWNER | I need a test that reproduces this. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 597671518 |