github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040959312 | https://api.github.com/repos/simonw/sqlite-utils/issues/407 | 1040959312 | IC_kwDOCGYnMM4-C8dQ | 9599 | 2022-02-16T00:58:32Z | 2022-02-16T00:58:32Z | OWNER | This is honestly one of the most complete PRs I've ever seen for a feature of this size. Thanks so much for this! | {"total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1138948786 | |
https://github.com/simonw/sqlite-utils/issues/398#issuecomment-1040965672 | https://api.github.com/repos/simonw/sqlite-utils/issues/398 | 1040965672 | IC_kwDOCGYnMM4-C-Ao | 9599 | 2022-02-16T01:02:29Z | 2022-02-16T01:02:29Z | OWNER | Documentation: - https://sqlite-utils.datasette.io/en/latest/cli-reference.html#create-database - https://sqlite-utils.datasette.io/en/latest/cli-reference.html#add-geometry-column - https://sqlite-utils.datasette.io/en/latest/cli-reference.html#create-spatial-index - https://sqlite-utils.datasette.io/en/latest/cli.html#spatialite-helpers | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1124237013 | |
https://github.com/simonw/sqlite-utils/issues/406#issuecomment-1040974519 | https://api.github.com/repos/simonw/sqlite-utils/issues/406 | 1040974519 | IC_kwDOCGYnMM4-DAK3 | 9599 | 2022-02-16T01:08:17Z | 2022-02-16T01:08:17Z | OWNER | I had no idea this was possible! I guess SQLite will allow any text string as the column type, defaulting to `TEXT` as the underlying default representation if it doesn't recognize the type. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1128466114 | |
https://github.com/simonw/sqlite-utils/issues/406#issuecomment-1040978032 | https://api.github.com/repos/simonw/sqlite-utils/issues/406 | 1040978032 | IC_kwDOCGYnMM4-DBBw | 9599 | 2022-02-16T01:10:31Z | 2022-02-16T01:10:31Z | OWNER | Allowing custom strings in the `create()` method, as you suggest in your example, feels like a reasonable way to support this. ```python db["dummy"].create({ "title": str, "vector": "array", }) ``` I'm slightly nervous about that just because people might accidentally use this without realizig what they are doing - passing `"column-name": "string"` for example when they should have used `"column-name": str` in order to get a `TEXT` column. Alternatively, this could work: ```python db["dummy"].create({ "title": str, "vector": CustomColumnType("array") }) ``` This would play better with `mypy` too I think. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1128466114 |