issue_comments

Table actions

7,983 rows sorted by id descending

✎ View and edit SQL

This data as json, CSV (advanced)

reactions 15 ✖

id ▲ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1106945876 https://github.com/simonw/datasette/issues/1715#issuecomment-1106945876 https://api.github.com/repos/simonw/datasette/issues/1715 IC_kwDOBm6k_c5B-qdU simonw 9599 2022-04-22T22:24:29Z 2022-04-22T22:24:29Z OWNER Looking at the start of `TableView.data()`: https://github.com/simonw/datasette/blob/d57c347f35bcd8cff15f913da851b4b8eb030867/datasette/views/table.py#L333-L346 I'm going to resolve `table_name` and `database` from the URL - `table_name` will be a string, `database` will be the DB object returned by `datasette.get_database()`. Then those can be passed in separately too. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Refactor TableView to use asyncinject 1212823665  
1106923258 https://github.com/simonw/datasette/issues/1716#issuecomment-1106923258 https://api.github.com/repos/simonw/datasette/issues/1716 IC_kwDOBm6k_c5B-k76 simonw 9599 2022-04-22T22:02:07Z 2022-04-22T22:02:07Z OWNER https://github.com/simonw/datasette/blame/main/datasette/views/base.py <img width="1373" alt="image" src="https://user-images.githubusercontent.com/9599/164801564-d8a11ce9-7d9b-4e85-8947-a547d2986ef3.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Configure git blame to ignore Black commit 1212838949  
1106908642 https://github.com/simonw/datasette/issues/1715#issuecomment-1106908642 https://api.github.com/repos/simonw/datasette/issues/1715 IC_kwDOBm6k_c5B-hXi simonw 9599 2022-04-22T21:47:55Z 2022-04-22T21:47:55Z OWNER I need a `asyncio.Registry` with functions registered to perform the role of the table view. Something like this perhaps: ```python def table_html_context(facet_results, query, datasette, rows): return {...} ``` That then gets called like this: ```python async def view(request): registry = Registry(facet_results, query, datasette, rows) context = await registry.resolve(table_html, request=request, datasette=datasette) return Reponse.html(await datasette.render("table.html", context) ``` It's also interesting to start thinking about this from a Python client library point of view. If I'm writing code outside of the HTTP request cycle, what would it look like? One thing I could do: break out is the code that turns a request into a list of pairs extracted from the request - this code here: https://github.com/simonw/datasette/blob/8338c66a57502ef27c3d7afb2527fbc0663b2570/datasette/views/table.py#L442-L449 I could turn that into a typed dependency injection function like this: ```python def filter_args(request: Request) -> List[Tuple[str, str]]: # Arguments that start with _ and don't contain a __ are # special - things like ?_search= - and should not be # treated as filters. filter_args = [] for key in request.args: if not (key.startswith("_") and "__" not in key): for v in request.args.getlist(key): filter_args.append((key, v)) return filter_args ``` Then I can either pass a `request` into a `.resolve()` call, or I can instead skip that function by passing: ```python output = registry.resolve(table_context, filter_args=[("foo", "bar")]) ``` I do need to think about where plugins get executed in all of this. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Refactor TableView to use asyncinject 1212823665  
1105642187 https://github.com/simonw/datasette/issues/1101#issuecomment-1105642187 https://api.github.com/repos/simonw/datasette/issues/1101 IC_kwDOBm6k_c5B5sLL eyeseast 25778 2022-04-21T18:59:08Z 2022-04-21T18:59:08Z CONTRIBUTOR Ha! That was your idea (and a good one). But it's probably worth measuring to see what overhead it adds. It did require both passing in the database and making the whole thing `async`. Just timing the queries themselves: 1. [Using `AsGeoJSON(geometry) as geometry`](https://alltheplaces-datasette.fly.dev/alltheplaces?sql=select%0D%0A++id%2C%0D%0A++properties%2C%0D%0A++AsGeoJSON%28geometry%29+as+geometry%2C%0D%0A++spider%0D%0Afrom%0D%0A++places%0D%0Aorder+by%0D%0A++id%0D%0Alimit%0D%0A++1000) takes 10.235 ms 2. [Leaving as binary](https://alltheplaces-datasette.fly.dev/alltheplaces?sql=select%0D%0A++id%2C%0D%0A++properties%2C%0D%0A++geometry%2C%0D%0A++spider%0D%0Afrom%0D%0A++places%0D%0Aorder+by%0D%0A++id%0D%0Alimit%0D%0A++1000) takes 8.63 ms Looking at the network panel: 1. Takes about 200 ms for the `fetch` request 2. Takes about 300 ms I'm not sure how best to time the GeoJSON generation, but it would be interesting to check. Maybe I'll write a plugin to add query times to response headers. The other thing to consider with async streaming is that it might be well-suited for a slower response. When I have to get the whole result and send a response in a fixed amount of time, I need the most efficient query possible. If I can hang onto a connection and get things one chunk at a time, maybe it's ok if there's some overhead. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} register_output_renderer() should support streaming data 749283032  
1105615625 https://github.com/simonw/datasette/issues/1101#issuecomment-1105615625 https://api.github.com/repos/simonw/datasette/issues/1101 IC_kwDOBm6k_c5B5lsJ simonw 9599 2022-04-21T18:31:41Z 2022-04-21T18:32:22Z OWNER The `datasette-geojson` plugin is actually an interesting case here, because of the way it converts SpatiaLite geometries into GeoJSON: https://github.com/eyeseast/datasette-geojson/blob/602c4477dc7ddadb1c0a156cbcd2ef6688a5921d/datasette_geojson/__init__.py#L61-L66 ```python if isinstance(geometry, bytes): results = await db.execute( "SELECT AsGeoJSON(:geometry)", {"geometry": geometry} ) return geojson.loads(results.single_value()) ``` That actually seems to work really well as-is, but it does worry me a bit that it ends up having to execute an extra `SELECT` query for every single returned row - especially in streaming mode where it might be asked to return 1m rows at once. My PostgreSQL/MySQL engineering brain says that this would be better handled by doing a chunk of these (maybe 100) at once, to avoid the per-query-overhead - but with SQLite that might not be necessary. At any rate, this is one of the reasons I'm interested in "iterate over this sequence of chunks of 100 rows at a time" as a potential option here. Of course, a better solution would be for `datasette-geojson` to have a way to influence the SQL query before it is executed, adding a `AsGeoJSON(geometry)` clause to it - so that's something I'm open to as well. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} register_output_renderer() should support streaming data 749283032  
1105608964 https://github.com/simonw/datasette/issues/1101#issuecomment-1105608964 https://api.github.com/repos/simonw/datasette/issues/1101 IC_kwDOBm6k_c5B5kEE simonw 9599 2022-04-21T18:26:29Z 2022-04-21T18:26:29Z OWNER I'm questioning if the mechanisms should be separate at all now - a single response rendering is really just a case of a streaming response that only pulls the first N records from the iterator. It probably needs to be an `async for` iterator, which I've not worked with much before. Good opportunity to learn. This actually gets a fair bit more complicated due to the work I'm doing right now to improve the default JSON API: - #1709 I want to do things like make faceting results optionally available to custom renderers - which is a separate concern from streaming rows. I'm going to poke around with a bunch of prototypes and see what sticks. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} register_output_renderer() should support streaming data 749283032  
1105588651 https://github.com/simonw/datasette/issues/1101#issuecomment-1105588651 https://api.github.com/repos/simonw/datasette/issues/1101 IC_kwDOBm6k_c5B5fGr eyeseast 25778 2022-04-21T18:15:39Z 2022-04-21T18:15:39Z CONTRIBUTOR What if you split rendering and streaming into two things: - `render` is a function that returns a response - `stream` is a function that sends chunks, or yields chunks passed to an ASGI `send` callback That way current plugins still work, and streaming is purely additive. A `stream` function could get a cursor or iterator of rows, instead of a list, so it could more efficiently handle large queries. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} register_output_renderer() should support streaming data 749283032  
1105571003 https://github.com/simonw/datasette/issues/1101#issuecomment-1105571003 https://api.github.com/repos/simonw/datasette/issues/1101 IC_kwDOBm6k_c5B5ay7 simonw 9599 2022-04-21T18:10:38Z 2022-04-21T18:10:46Z OWNER Maybe the simplest design for this is to add an optional `can_stream` to the contract: ```python @hookimpl def register_output_renderer(datasette): return { "extension": "tsv", "render": render_tsv, "can_render": lambda: True, "can_stream": lambda: True } ``` When streaming, a new parameter could be passed to the render function - maybe `chunks` - which is an iterator/generator over a sequence of chunks of rows. Or it could use the existing `rows` parameter but treat that as an iterator? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} register_output_renderer() should support streaming data 749283032  
1105474232 https://github.com/dogsheep/github-to-sqlite/issues/72#issuecomment-1105474232 https://api.github.com/repos/dogsheep/github-to-sqlite/issues/72 IC_kwDODFdgUs5B5DK4 simonw 9599 2022-04-21T17:02:15Z 2022-04-21T17:02:15Z MEMBER That's interesting - yeah it looks like the number of pages can be derived from the `Link` header, which is enough information to show a progress bar, probably using Click just to avoid adding another dependency. https://docs.github.com/en/rest/guides/traversing-with-pagination {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} feature: display progress bar when downloading multi-page responses 1211283427  
1105464661 https://github.com/simonw/datasette/pull/1574#issuecomment-1105464661 https://api.github.com/repos/simonw/datasette/issues/1574 IC_kwDOBm6k_c5B5A1V dholth 208018 2022-04-21T16:51:24Z 2022-04-21T16:51:24Z NONE tfw you have more ephemeral storage than upstream bandwidth ``` FROM python:3.10-slim AS base RUN apt update && apt -y install zstd ENV DATASETTE_SECRET 'sosecret' RUN --mount=type=cache,target=/root/.cache/pip pip install -U datasette datasette-pretty-json datasette-graphql ENV PORT 8080 EXPOSE 8080 FROM base AS pack COPY . /app WORKDIR /app RUN datasette inspect --inspect-file inspect-data.json RUN zstd --rm *.db FROM base AS unpack COPY --from=pack /app /app WORKDIR /app CMD ["/bin/bash", "-c", "shopt -s nullglob && zstd --rm -d *.db.zst && datasette serve --host 0.0.0.0 --cors --inspect-file inspect-data.json --metadata metadata.json --create --port $PORT *.db"] ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} introduce new option for datasette package to use a slim base image 1084193403  
1103312860 https://github.com/simonw/datasette/issues/1713#issuecomment-1103312860 https://api.github.com/repos/simonw/datasette/issues/1713 IC_kwDOBm6k_c5Bwzfc fgregg 536941 2022-04-20T00:52:19Z 2022-04-20T00:52:19Z NONE feels related to #1402 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Datasette feature for publishing snapshots of query results 1203943272  
1101594549 https://github.com/simonw/sqlite-utils/issues/425#issuecomment-1101594549 https://api.github.com/repos/simonw/sqlite-utils/issues/425 IC_kwDOCGYnMM5BqP-1 simonw 9599 2022-04-18T17:36:14Z 2022-04-18T17:36:14Z OWNER Releated: - #408 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} `sqlite3.NotSupportedError`: deterministic=True requires SQLite 3.8.3 or higher 1203842656  
1100243987 https://github.com/simonw/datasette/pull/1159#issuecomment-1100243987 https://api.github.com/repos/simonw/datasette/issues/1159 IC_kwDOBm6k_c5BlGQT lovasoa 552629 2022-04-15T17:24:43Z 2022-04-15T17:24:43Z NONE @simonw : do you think this could be merged ? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Improve the display of facets information 774332247  
1099540225 https://github.com/simonw/datasette/issues/1713#issuecomment-1099540225 https://api.github.com/repos/simonw/datasette/issues/1713 IC_kwDOBm6k_c5BiacB eyeseast 25778 2022-04-14T19:09:57Z 2022-04-14T19:09:57Z CONTRIBUTOR I wonder if this overlaps with what I outlined in #1605. You could run something like this: ```sh datasette freeze -d exports/ aws s3 cp exports/ s3://my-export-bucket/$(date) ``` And maybe that does what you need. Of course, that plugin isn't built yet. But that's the idea. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Datasette feature for publishing snapshots of query results 1203943272  
1099443468 https://github.com/simonw/datasette/issues/1713#issuecomment-1099443468 https://api.github.com/repos/simonw/datasette/issues/1713 IC_kwDOBm6k_c5BiC0M rayvoelker 9308268 2022-04-14T17:26:27Z 2022-04-14T17:26:27Z NONE What would be an awesome feature as a plugin would be to be able to save a query (and possibly even results) to a github gist. Being able to share results that way would be super fantastic. Possibly even in Jupyter Notebook format (since github and github gists nicely render those)! I know there's the handy datasette-saved-queries plugin, but a button that could export stuff out and then even possibly import stuff back in (I'm sort of thinking the way that Google Colab allows you to save to github, and then pull the notebook back in is a really great workflow ![image](https://user-images.githubusercontent.com/9308268/163441612-9ad2649f-c73e-4557-aaf2-e3d0fdc48fbf.png) https://github.com/cincinnatilibrary/collection-analysis/blob/master/reports/colab_datasette_example.ipynb ) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Datasette feature for publishing snapshots of query results 1203943272  
1098628334 https://github.com/simonw/datasette/issues/1713#issuecomment-1098628334 https://api.github.com/repos/simonw/datasette/issues/1713 IC_kwDOBm6k_c5Be7zu simonw 9599 2022-04-14T01:43:00Z 2022-04-14T01:43:13Z OWNER Current workaround for fast publishing to S3: datasette fixtures.db --get /fixtures/facetable.json | \ s3-credentials put-object my-bucket facetable.json - {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Datasette feature for publishing snapshots of query results 1203943272  
1098548931 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1098548931 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5BeobD simonw 9599 2022-04-13T22:41:59Z 2022-04-13T22:41:59Z OWNER I'm going to close this ticket since it looks like this is a bug in the way the Dockerfile builds Python, but I'm going to ship a fix for that issue I found so the `LD_PRELOAD` workaround above should work OK with the next release of `sqlite-utils`. Thanks for the detailed bug report! {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1098548090 https://github.com/simonw/sqlite-utils/issues/424#issuecomment-1098548090 https://api.github.com/repos/simonw/sqlite-utils/issues/424 IC_kwDOCGYnMM5BeoN6 simonw 9599 2022-04-13T22:40:15Z 2022-04-13T22:40:15Z OWNER New error: ```pycon >>> from sqlite_utils import Database >>> db = Database(memory=True) >>> db["foo"].create({}) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/simon/Dropbox/Development/sqlite-utils/sqlite_utils/db.py", line 1465, in create self.db.create_table( File "/Users/simon/Dropbox/Development/sqlite-utils/sqlite_utils/db.py", line 885, in create_table sql = self.create_table_sql( File "/Users/simon/Dropbox/Development/sqlite-utils/sqlite_utils/db.py", line 771, in create_table_sql assert columns, "Tables must have at least one column" AssertionError: Tables must have at least one column ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Better error message if you try to create a table with no columns 1200866134  
1098545390 https://github.com/simonw/sqlite-utils/issues/425#issuecomment-1098545390 https://api.github.com/repos/simonw/sqlite-utils/issues/425 IC_kwDOCGYnMM5Benju simonw 9599 2022-04-13T22:34:52Z 2022-04-13T22:34:52Z OWNER That broke Python 3.7 because it doesn't support `deterministic=True` even being passed: > function takes at most 3 arguments (4 given) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} `sqlite3.NotSupportedError`: deterministic=True requires SQLite 3.8.3 or higher 1203842656  
1098537000 https://github.com/simonw/sqlite-utils/issues/425#issuecomment-1098537000 https://api.github.com/repos/simonw/sqlite-utils/issues/425 IC_kwDOCGYnMM5Belgo simonw 9599 2022-04-13T22:18:22Z 2022-04-13T22:18:22Z OWNER I figured out a workaround in https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1098535531 The current `register(fn)` method looks like this: https://github.com/simonw/sqlite-utils/blob/95522ad919f96eb6cc8cd3cd30389b534680c717/sqlite_utils/db.py#L389-L403 This alternative implementation worked in the environment where that failed: ```python def register(fn): name = fn.__name__ arity = len(inspect.signature(fn).parameters) if not replace and (name, arity) in self._registered_functions: return fn kwargs = {} done = False if deterministic: # Try this, but fall back if sqlite3.NotSupportedError try: self.conn.create_function(name, arity, fn, **dict(kwargs, deterministic=True)) done = True except sqlite3.NotSupportedError: pass if not done: self.conn.create_function(name, arity, fn, **kwargs) self._registered_functions.add((name, arity)) return fn ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} `sqlite3.NotSupportedError`: deterministic=True requires SQLite 3.8.3 or higher 1203842656  
1098535531 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1098535531 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5BelJr simonw 9599 2022-04-13T22:15:48Z 2022-04-13T22:15:48Z OWNER Trying this alternative implementation of the `register()` method: ```python def register(fn): name = fn.__name__ arity = len(inspect.signature(fn).parameters) if not replace and (name, arity) in self._registered_functions: return fn kwargs = {} done = False if deterministic: # Try this, but fall back if sqlite3.NotSupportedError try: self.conn.create_function(name, arity, fn, **dict(kwargs, deterministic=True)) done = True except sqlite3.NotSupportedError: pass if not done: self.conn.create_function(name, arity, fn, **kwargs) self._registered_functions.add((name, arity)) return fn ``` With that fix, the following worked! ``` LD_PRELOAD=./build/sqlite-autoconf-3360000/.libs/libsqlite3.so sqlite-utils indexes /tmp/global.db --table table index_name seqno cid name desc coll key --------- -------------------------- ------- ----- ------- ------ ------ ----- countries idx_countries_country_name 0 1 country 0 BINARY 1 countries idx_countries_country_name 1 2 name 0 BINARY 1 ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1098532220 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1098532220 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5BekV8 simonw 9599 2022-04-13T22:09:52Z 2022-04-13T22:09:52Z OWNER That error is weird - it's not supposed to happen according to this code here: https://github.com/simonw/sqlite-utils/blob/95522ad919f96eb6cc8cd3cd30389b534680c717/sqlite_utils/db.py#L389-L400 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1098531354 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1098531354 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5BekIa simonw 9599 2022-04-13T22:08:20Z 2022-04-13T22:08:20Z OWNER OK I figured out what's going on here. First I added an extra `print(sql)` statement to the `indexes` command to see what SQL it was running: ``` (app-root) sqlite-utils indexes global.db --table select sqlite_master.name as "table", indexes.name as index_name, xinfo.* from sqlite_master join pragma_index_list(sqlite_master.name) indexes join pragma_index_xinfo(index_name) xinfo where sqlite_master.type = 'table' and xinfo.key = 1 Error: near "(": syntax error ``` This made me suspicious that the SQLite version being used here didn't support joining against the `pragma_index_list(...)` table-valued functions in that way. So I checked the version: ``` (app-root) sqlite3 SQLite version 3.36.0 2021-06-18 18:36:39 ``` That version should be fine - it's the one you compiled in the Dockerfile. Then I checked the version that `sqlite-utils` itself was using: ``` (app-root) sqlite-utils memory 'select sqlite_version()' [{"sqlite_version()": "3.7.17"}] ``` It's running SQLite 3.7.17! So the problem here is that the Python in that Docker image is running a very old version of SQLite. I tried using the trick in https://til.simonwillison.net/sqlite/ld-preload as a workaround, and it almost worked: ``` (app-root) python3 -c 'import sqlite3; print(sqlite3.connect(":memory").execute("select sqlite_version()").fetchone())' ('3.7.17',) (app-root) LD_PRELOAD=./build/sqlite-autoconf-3360000/.libs/libsqlite3.so python3 -c 'import sqlite3; print(sqlite3.connect(":memory").execute("select sqlite_version()").fetchone())' ('3.36.0',) ``` But when I try to run `sqlite-utils` like that I get an error: ``` (app-root) LD_PRELOAD=./build/sqlite-autoconf-3360000/.libs/libsqlite3.so sqlite-utils indexes /tmp/global.db ... File "/opt/app-root/lib64/python3.8/site-packages/sqlite_utils/cli.py", line 1624, in query db.register_fts4_bm25() File "/opt/app-root/lib64/python3.8/site-packages/sqlite_utils/db.py", line 412, in register_fts… {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1098295517 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1098295517 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5Bdqjd simonw 9599 2022-04-13T17:16:20Z 2022-04-13T17:16:20Z OWNER Aha! I was able to replicate the bug using your `Dockerfile` - thanks very much for providing that. ``` (app-root) sqlite-utils indexes global.db --table Error: near "(": syntax error ``` (That wa sbefore I even ran the `extract` command.) To build your `Dockerfile` I copied it into an empty folder and ran the following: ``` wget https://www.sqlite.org/2021/sqlite-autoconf-3360000.tar.gz docker build . -t centos-sqlite-utils docker run -it centos-sqlite-utils /bin/bash ``` This gave me a shell in which I could replicate the bug. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1098288158 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1098288158 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5Bdowe simonw 9599 2022-04-13T17:07:53Z 2022-04-13T17:07:53Z OWNER I can't replicate the bug I'm afraid: ``` % wget "https://github.com/wri/global-power-plant-database/blob/232a6666/output_database/global_power_plant_database.csv?raw=true" ... 2022-04-13 10:06:29 (8.97 MB/s) - ‘global_power_plant_database.csv?raw=true’ saved [8856038/8856038] % sqlite-utils insert global.db power_plants \ 'global_power_plant_database.csv?raw=true' --csv [------------------------------------] 0% [###################################-] 99% 00:00:00% % sqlite-utils indexes global.db --table table index_name seqno cid name desc coll key ------- ------------ ------- ----- ------ ------ ------ ----- % sqlite-utils extract global.db power_plants country country_long \ --table countries \ --fk-column country_id \ --rename country_long name % sqlite-utils indexes global.db --table table index_name seqno cid name desc coll key --------- -------------------------- ------- ----- ------- ------ ------ ----- countries idx_countries_country_name 0 1 country 0 BINARY 1 countries idx_countries_country_name 1 2 name 0 BINARY 1 ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1097115034 https://github.com/simonw/datasette/issues/1712#issuecomment-1097115034 https://api.github.com/repos/simonw/datasette/issues/1712 IC_kwDOBm6k_c5BZKWa simonw 9599 2022-04-12T19:12:21Z 2022-04-12T19:12:21Z OWNER Got a TIL out of this too: https://til.simonwillison.net/spatialite/gunion-to-combine-geometries {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Make "<Binary: 2427344 bytes>" easier to read 1202227104  
1097076622 https://github.com/simonw/datasette/issues/1712#issuecomment-1097076622 https://api.github.com/repos/simonw/datasette/issues/1712 IC_kwDOBm6k_c5BZA-O simonw 9599 2022-04-12T18:42:04Z 2022-04-12T18:42:04Z OWNER I'm not going to show the tooltip if the formatted number is in bytes. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Make "<Binary: 2427344 bytes>" easier to read 1202227104  
1097068474 https://github.com/simonw/datasette/issues/1712#issuecomment-1097068474 https://api.github.com/repos/simonw/datasette/issues/1712 IC_kwDOBm6k_c5BY--6 simonw 9599 2022-04-12T18:38:18Z 2022-04-12T18:38:18Z OWNER <img width="633" alt="image" src="https://user-images.githubusercontent.com/9599/163030785-9dcc5a21-6a1b-42a7-97de-10e7d2874412.png"> {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Make "<Binary: 2427344 bytes>" easier to read 1202227104  
1095687566 https://github.com/simonw/datasette/issues/1708#issuecomment-1095687566 https://api.github.com/repos/simonw/datasette/issues/1708 IC_kwDOBm6k_c5BTt2O simonw 9599 2022-04-11T23:24:30Z 2022-04-11T23:24:30Z OWNER ## Redesigned template context **Warning:** if you use any custom templates with your Datasette instance they are likely to break when you upgrade to 1.0. The template context has been redesigned to be based on the documented JSON API. This means that the template context can be considered stable going forward, so any custom templates you implement should continue to work when you upgrade Datasette in the future. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 1.0a0 release notes 1200649124  
1095675839 https://github.com/simonw/datasette/issues/1708#issuecomment-1095675839 https://api.github.com/repos/simonw/datasette/issues/1708 IC_kwDOBm6k_c5BTq-_ simonw 9599 2022-04-11T23:06:30Z 2022-04-11T23:09:56Z OWNER # Datasette 1.0 alpha 0 This alpha release is the first preview of Datasette 1.0. Datasette 1.0 marks a significant milestone in the project: it is the point from which various aspects of Datasette can be considered "stable", in that code developed against them should expect not to be broken by future releases in the 1.x series. This will hold true until the next major version release, Datasette 2.0 - which we hope to hold off releasing for as long as possible. The following Datasette components should be be considered stable after 1.0: - The plugin API. Plugins developed against 1.0 should continue to work unmodified throughout the 1.x series. - The JSON API. Code written that interacts with Datasette's default JSON web API should continue to work. - The template context. If you build custom templates against Datasette your custom pages should continue to work. Note that none of these components will cease to introduce new features. New plugin hooks, new JSON APIs and new template context variables can be introduced without breaking existing code. Since this alpha release previews features that will be frozen for 1.0, please test this thoroughly against your existing Datasette projects. You can install the alpha using: pip install datasette==1.0a0 ## JSON API changes The most significant changes introduced in this new alpha concern Datasette's JSON API. The default JSON returned by the `/database/table.json` endpoint has changed. It now returns an object with two keys: `rows` - which contains a list of objects representing the rows in the table or query, and `more` containing a `boolean` that shows if there are more rows or if this object contains them all. ```json { "rows": [{ "id": 1, "name": "Name 1" }, { "id": 2, "name": "Name 2" }], "more": false } ``` [ Initially I thought about going with `next_url`, which would be `null` if you have reached the last page of records. Maybe that would be better? But since `next_url` cannot be … {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 1.0a0 release notes 1200649124  
1095673947 https://github.com/simonw/datasette/issues/1705#issuecomment-1095673947 https://api.github.com/repos/simonw/datasette/issues/1705 IC_kwDOBm6k_c5BTqhb simonw 9599 2022-04-11T23:03:49Z 2022-04-11T23:03:49Z OWNER I'll also encourage testing against both Datasette 0.x and Datasette 1.0 using a GitHub Actions matrix. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} How to upgrade your plugin for 1.0 documentation 1197926598  
1095673670 https://github.com/simonw/datasette/issues/1710#issuecomment-1095673670 https://api.github.com/repos/simonw/datasette/issues/1710 IC_kwDOBm6k_c5BTqdG simonw 9599 2022-04-11T23:03:25Z 2022-04-11T23:03:25Z OWNER Dupe of: - #1705 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Guide for plugin authors to upgrade their plugins for 1.0 1200649889  
1095672127 https://github.com/simonw/datasette/issues/1711#issuecomment-1095672127 https://api.github.com/repos/simonw/datasette/issues/1711 IC_kwDOBm6k_c5BTqE_ simonw 9599 2022-04-11T23:00:58Z 2022-04-11T23:00:58Z OWNER - #1510 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Template context powered entirely by the JSON API format 1200650491  
1095671940 https://github.com/simonw/datasette/issues/1709#issuecomment-1095671940 https://api.github.com/repos/simonw/datasette/issues/1709 IC_kwDOBm6k_c5BTqCE simonw 9599 2022-04-11T23:00:39Z 2022-04-11T23:01:41Z OWNER - #262 - #782 - #1509 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Redesigned JSON API with ?_extra= parameters 1200649502  
1095277937 https://github.com/simonw/datasette/issues/1707#issuecomment-1095277937 https://api.github.com/repos/simonw/datasette/issues/1707 IC_kwDOBm6k_c5BSJ1x simonw 9599 2022-04-11T16:32:31Z 2022-04-11T16:33:00Z OWNER That's a really interesting idea! That page is one of the least developed at the moment. There's plenty of room for it to grow new useful features. I like this suggestion because it feels like a good opportunity to introduce some unobtrusive JavaScript. Could use a details/summary element that uses `fetch()` to load in the extra data for example. Could even do something with the `<datasette-table>` Web Component here... https://github.com/simonw/datasette-table {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [feature] expanded detail page 1200224939  
1094453751 https://github.com/simonw/datasette/issues/1699#issuecomment-1094453751 https://api.github.com/repos/simonw/datasette/issues/1699 IC_kwDOBm6k_c5BPAn3 eyeseast 25778 2022-04-11T01:32:12Z 2022-04-11T01:32:12Z CONTRIBUTOR Was looking through old issues and realized a bunch of this got discussed in #1101 (including by me!), so sorry to rehash all this. Happy to help with whatever piece of it I can. Would be very excited to be able to use format plugins with exports. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Proposal: datasette query 1193090967  
1094152642 https://github.com/simonw/datasette/issues/1706#issuecomment-1094152642 https://api.github.com/repos/simonw/datasette/issues/1706 IC_kwDOBm6k_c5BN3HC simonw 9599 2022-04-10T01:11:54Z 2022-04-10T01:11:54Z OWNER This relates to this much larger vision: - #417 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [feature] immutable mode for a directory, not just individual sqlite file 1198822563  
1094152173 https://github.com/simonw/datasette/issues/1706#issuecomment-1094152173 https://api.github.com/repos/simonw/datasette/issues/1706 IC_kwDOBm6k_c5BN2_t simonw 9599 2022-04-10T01:08:50Z 2022-04-10T01:08:50Z OWNER This is a good idea - it matches the way `datasette .` works for mutable database files already. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [feature] immutable mode for a directory, not just individual sqlite file 1198822563  
1093454899 https://github.com/simonw/datasette/pull/1693#issuecomment-1093454899 https://api.github.com/repos/simonw/datasette/issues/1693 IC_kwDOBm6k_c5BLMwz simonw 9599 2022-04-08T23:07:04Z 2022-04-08T23:07:04Z OWNER Tests failed here due to this issue: - https://github.com/psf/black/pull/2987 A future Black release should fix that. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Bump black from 22.1.0 to 22.3.0 1184850337  
1092850719 https://github.com/simonw/datasette/pull/1703#issuecomment-1092850719 https://api.github.com/repos/simonw/datasette/issues/1703 IC_kwDOBm6k_c5BI5Qf codecov[bot] 22429695 2022-04-08T13:18:04Z 2022-04-08T13:18:04Z NONE # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1703?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1703](https://codecov.io/gh/simonw/datasette/pull/1703?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (73aabe6) into [main](https://codecov.io/gh/simonw/datasette/commit/90d1be9952db9aaddc21a536e4d00a8de44765d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (90d1be9) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main #1703 +/- ## ======================================= Coverage 91.75% 91.75% ======================================= Files 34 34 Lines 4573 4573 ======================================= Hits 4196 4196 Misses 377 377 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1703?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1703?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [90d1be9...73aabe6](https://codecov.io/gh/simonw/datasette/pull/1703?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/d… {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Update beautifulsoup4 requirement from <4.11.0,>=4.8.1 to >=4.8.1,<4.12.0 1197298420  
1092386254 https://github.com/simonw/datasette/issues/1699#issuecomment-1092386254 https://api.github.com/repos/simonw/datasette/issues/1699 IC_kwDOBm6k_c5BHH3O eyeseast 25778 2022-04-08T02:39:25Z 2022-04-08T02:39:25Z CONTRIBUTOR And just to think this through a little more, here's what `stream_geojson` might look like: ```python async def stream_geojson(datasette, columns, rows, database, stream): db = datasette.get_database(database) for row in rows: feature = await row_to_geojson(row, db) stream.write(feature + "\n") # just assuming newline mode for now ``` Alternately, that could be an async generator, like this: ```python async def stream_geojson(datasette, columns, rows, database): db = datasette.get_database(database) for row in rows: feature = await row_to_geojson(row, db) yield feature ``` Not sure which makes more sense, but I think this pattern would open up a lot of possibility. If you had your [stream_indented_json](https://til.simonwillison.net/python/output-json-array-streaming) function, you could do `yield from stream_indented_json(rows, 2)` and be one your way. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Proposal: datasette query 1193090967  
1092370880 https://github.com/simonw/datasette/issues/1699#issuecomment-1092370880 https://api.github.com/repos/simonw/datasette/issues/1699 IC_kwDOBm6k_c5BHEHA eyeseast 25778 2022-04-08T02:07:40Z 2022-04-08T02:07:40Z CONTRIBUTOR So maybe `render_output_render` returns something like this: ```python @hookimpl def register_output_renderer(datasette): return { "extension": "geojson", "render": render_geojson, "stream": stream_geojson, "can_render": can_render_geojson, } ``` And stream gets an iterator, instead of a list of rows, so it can efficiently handle large queries. Maybe it also gets passed a destination stream, or it returns an iterator. I'm not sure what makes more sense. Either way, that might cover both CLI exports and streaming responses. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Proposal: datasette query 1193090967  
1092361727 https://github.com/simonw/datasette/issues/1699#issuecomment-1092361727 https://api.github.com/repos/simonw/datasette/issues/1699 IC_kwDOBm6k_c5BHB3_ simonw 9599 2022-04-08T01:47:43Z 2022-04-08T01:47:43Z OWNER A render mode for that plugin hook that writes to a stream is exactly what I have in mind: - #1062 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Proposal: datasette query 1193090967  
1092357672 https://github.com/simonw/datasette/issues/1699#issuecomment-1092357672 https://api.github.com/repos/simonw/datasette/issues/1699 IC_kwDOBm6k_c5BHA4o eyeseast 25778 2022-04-08T01:39:40Z 2022-04-08T01:39:40Z CONTRIBUTOR > My best thought on how to differentiate them so far is plugins: if Datasette plugins that provide alternative outputs - like .geojson and .yml and suchlike - also work for the datasette query command that would make a lot of sense to me. That's my thinking, too. It's really the thing I've been wanting since writing `datasette-geojson`, since I'm always exporting with `datasette --get`. The workflow I'm always looking for is something like this: ```sh cd alltheplaces-datasette datasette query dunkin_in_suffolk -f geojson -o dunkin_in_suffolk.geojson ``` I think this probably needs either a new plugin hook separate from `register_output_renderer` or a way to use that without going through the HTTP stack. Or maybe a render mode that writes to a stream instead of a response. Maybe there's a new key in the dictionary that `register_output_renderer` returns that handles CLI exports. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Proposal: datasette query 1193090967  
1092321966 https://github.com/simonw/datasette/issues/1699#issuecomment-1092321966 https://api.github.com/repos/simonw/datasette/issues/1699 IC_kwDOBm6k_c5BG4Ku simonw 9599 2022-04-08T00:20:32Z 2022-04-08T00:20:56Z OWNER If we do this I'm keen to have it be more than just an alternative to the existing `sqlite-utils` command - especially since if I add `sqlite-utils` as a dependency of Datasette in the future that command will be installed as part of `pip install datasette` anyway. My best thought on how to differentiate them so far is plugins: if Datasette plugins that provide alternative outputs - like `.geojson` and `.yml` and suchlike - also work for the `datasette query` command that would make a lot of sense to me. One way that could work: a `--fmt geojson` option to this command which uses the plugin that was registered for the specified extension. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Proposal: datasette query 1193090967  
1087428593 https://github.com/simonw/datasette/issues/1549#issuecomment-1087428593 https://api.github.com/repos/simonw/datasette/issues/1549 IC_kwDOBm6k_c5A0Nfx fgregg 536941 2022-04-04T11:17:13Z 2022-04-04T11:17:13Z NONE another way to get the behavior of downloading the file is to use the download attribute of the anchor tag https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-download {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Redesign CSV export to improve usability 1077620955  
1086784547 https://github.com/simonw/datasette/issues/1698#issuecomment-1086784547 https://api.github.com/repos/simonw/datasette/issues/1698 IC_kwDOBm6k_c5AxwQj simonw 9599 2022-04-03T06:10:24Z 2022-04-03T06:10:24Z OWNER Warning added here: https://docs.datasette.io/en/latest/publish.html#publishing-to-google-cloud-run {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Add a warning about bots and Cloud Run 1190828163  
1085323192 https://github.com/simonw/datasette/issues/1697#issuecomment-1085323192 https://api.github.com/repos/simonw/datasette/issues/1697 IC_kwDOBm6k_c5AsLe4 simonw 9599 2022-04-01T02:01:51Z 2022-04-01T02:01:51Z OWNER Huh, turns out `Request.fake()` wasn't yet documented. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} `Request.fake(..., url_vars={})` 1189113609  
1084216224 https://github.com/simonw/datasette/pull/1574#issuecomment-1084216224 https://api.github.com/repos/simonw/datasette/issues/1574 IC_kwDOBm6k_c5An9Og fs111 33631 2022-03-31T07:45:25Z 2022-03-31T07:45:25Z NONE @simonw I like that you want to go "slim by default". Do you want another PR for that or should I just wait? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} introduce new option for datasette package to use a slim base image 1084193403  
1083351437 https://github.com/simonw/datasette/issues/1696#issuecomment-1083351437 https://api.github.com/repos/simonw/datasette/issues/1696 IC_kwDOBm6k_c5AkqGN simonw 9599 2022-03-30T16:20:49Z 2022-03-30T16:21:02Z OWNER Maybe like this: <img width="499" alt="image" src="https://user-images.githubusercontent.com/9599/160883280-c19d5a22-e923-491f-8bf4-1a4f5215d684.png"> ```html <h3>283 rows where dcode = 3 <span style="color: #aaa; font-size: 0.9em">(Human Related: Other)</span> </h3> ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Show foreign key label when filtering 1186696202  
1082663746 https://github.com/simonw/datasette/issues/1692#issuecomment-1082663746 https://api.github.com/repos/simonw/datasette/issues/1692 IC_kwDOBm6k_c5AiCNC simonw 9599 2022-03-30T06:14:39Z 2022-03-30T06:14:51Z OWNER I like your design, though I think it should be `"nomodule": True` for consistency with the other options. I think `"async": True` is worth supporting too. {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [plugins][feature request]: Support additional script tag attributes when loading custom JS 1182227211  
1082661795 https://github.com/simonw/datasette/issues/1692#issuecomment-1082661795 https://api.github.com/repos/simonw/datasette/issues/1692 IC_kwDOBm6k_c5AiBuj simonw 9599 2022-03-30T06:11:41Z 2022-03-30T06:11:41Z OWNER This is a good idea. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [plugins][feature request]: Support additional script tag attributes when loading custom JS 1182227211  
1082617386 https://github.com/simonw/datasette/issues/1695#issuecomment-1082617386 https://api.github.com/repos/simonw/datasette/issues/1695 IC_kwDOBm6k_c5Ah24q simonw 9599 2022-03-30T04:46:18Z 2022-03-30T04:46:18Z OWNER ` selected = (column_qs, str(row["value"])) in qs_pairs` is wrong. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Option to un-filter facet not shown for `?col__exact=value` 1185868354  
1082617241 https://github.com/simonw/datasette/issues/1695#issuecomment-1082617241 https://api.github.com/repos/simonw/datasette/issues/1695 IC_kwDOBm6k_c5Ah22Z simonw 9599 2022-03-30T04:45:55Z 2022-03-30T04:45:55Z OWNER Relevant template: https://github.com/simonw/datasette/blob/e73fa72917ca28c152208d62d07a490c81cadf52/datasette/templates/table.html#L168-L172 Populated from here: https://github.com/simonw/datasette/blob/c496f2b663ff0cef908ffaaa68b8cb63111fb5f2/datasette/facets.py#L246-L253 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Option to un-filter facet not shown for `?col__exact=value` 1185868354  
1082476727 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1082476727 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5AhUi3 strada 770231 2022-03-29T23:52:38Z 2022-03-29T23:52:38Z NONE @simonw Thanks for looking into it and documenting the solution! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1081861670 https://github.com/simonw/datasette/pull/1693#issuecomment-1081861670 https://api.github.com/repos/simonw/datasette/issues/1693 IC_kwDOBm6k_c5Ae-Ym codecov[bot] 22429695 2022-03-29T13:18:47Z 2022-05-20T20:36:30Z NONE # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1693](https://codecov.io/gh/simonw/datasette/pull/1693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (65a5d5e) into [main](https://codecov.io/gh/simonw/datasette/commit/1465fea4798599eccfe7e8f012bd8d9adfac3039?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (1465fea) will **not change** coverage. > The diff coverage is `n/a`. > :exclamation: Current head 65a5d5e differs from pull request most recent head ec2d1e4. Consider uploading reports for the commit ec2d1e4 to get more accurate results ```diff @@ Coverage Diff @@ ## main #1693 +/- ## ======================================= Coverage 91.67% 91.67% ======================================= Files 36 36 Lines 4658 4658 ======================================= Hits 4270 4270 Misses 388 388 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [1d33fd0...ec2d1e4](https://codecov.io/gh/simonw/datasette/pull/1693?src=pr&el=l… {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Bump black from 22.1.0 to 22.3.0 1184850337  
1081860312 https://github.com/simonw/datasette/pull/1694#issuecomment-1081860312 https://api.github.com/repos/simonw/datasette/issues/1694 IC_kwDOBm6k_c5Ae-DY codecov[bot] 22429695 2022-03-29T13:17:30Z 2022-03-29T13:17:30Z NONE # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1694?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1694](https://codecov.io/gh/simonw/datasette/pull/1694?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (83ff967) into [main](https://codecov.io/gh/simonw/datasette/commit/e73fa72917ca28c152208d62d07a490c81cadf52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (e73fa72) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main #1694 +/- ## ======================================= Coverage 91.74% 91.74% ======================================= Files 34 34 Lines 4565 4565 ======================================= Hits 4188 4188 Misses 377 377 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1694?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1694?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [e73fa72...83ff967](https://codecov.io/gh/simonw/datasette/pull/1694?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/d… {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Update click requirement from <8.1.0,>=7.1.1 to >=7.1.1,<8.2.0 1184850675  
1081079506 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1081079506 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5Ab_bS learning4life 24938923 2022-03-28T19:58:55Z 2022-03-28T20:05:57Z NONE Sure, it is from the documentation example: [Extracting columns into a separate table](https://sqlite-utils.datasette.io/en/stable/cli.html#extracting-columns-into-a-separate-table) ``` wget "https://github.com/wri/global-power-plant-database/blob/232a6666/output_database/global_power_plant_database.csv?raw=true" sqlite-utils insert global.db power_plants \ 'global_power_plant_database.csv?raw=true' --csv # Extract those columns: sqlite-utils extract global.db power_plants country country_long \ --table countries \ --fk-column country_id \ --rename country_long name ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1081047053 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1081047053 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5Ab3gN simonw 9599 2022-03-28T19:22:37Z 2022-03-28T19:22:37Z OWNER Wrote about this in my weeknotes: https://simonwillison.net/2022/Mar/28/datasette-auth0/#new-features-as-documentation {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1080141111 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1080141111 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5AYaU3 simonw 9599 2022-03-28T03:25:57Z 2022-03-28T03:54:37Z OWNER So now this should solve your problem: ``` echo '[{"name": "notaword"}, {"name": "word"}] ' | python3 -m sqlite_utils insert listings.db listings - --convert ' import enchant d = enchant.Dict("en_US") def convert(row): global d row["is_dictionary_word"] = d.check(row["name"]) ' ``` {"total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1079806857 https://github.com/simonw/datasette/issues/1688#issuecomment-1079806857 https://api.github.com/repos/simonw/datasette/issues/1688 IC_kwDOBm6k_c5AXIuJ hydrosquall 9020979 2022-03-27T01:01:14Z 2022-03-27T01:01:14Z NONE Thank you! I went through the cookiecutter template, and published my first package here: https://github.com/hydrosquall/datasette-nteract-data-explorer {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [plugins][documentation] Is it possible to serve per-plugin static folders when writing one-off (single file) plugins? 1181432624  
1079788375 https://github.com/simonw/datasette/issues/1690#issuecomment-1079788375 https://api.github.com/repos/simonw/datasette/issues/1690 IC_kwDOBm6k_c5AXENX simonw 9599 2022-03-26T22:43:00Z 2022-03-26T22:43:00Z OWNER Then I can update this section of the documentation which currently recommends the above pattern: https://docs.datasette.io/en/stable/authentication.html#the-ds-actor-cookie {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Idea: `datasette.set_actor_cookie(response, actor)` 1182141761  
1079788346 https://github.com/simonw/datasette/issues/1690#issuecomment-1079788346 https://api.github.com/repos/simonw/datasette/issues/1690 IC_kwDOBm6k_c5AXEM6 simonw 9599 2022-03-26T22:42:40Z 2022-03-26T22:42:40Z OWNER I don't want to do a `response.set_actor_cookie()` method because I like `Response` not to carry too many Datasette-specific features. So `datasette.set_actor_cookie(response, actor, expire_after=None)` would be a better place for this I think. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Idea: `datasette.set_actor_cookie(response, actor)` 1182141761  
1079779040 https://github.com/simonw/datasette/issues/1689#issuecomment-1079779040 https://api.github.com/repos/simonw/datasette/issues/1689 IC_kwDOBm6k_c5AXB7g simonw 9599 2022-03-26T21:35:57Z 2022-03-26T21:35:57Z OWNER Fixed: https://docs.datasette.io/en/latest/internals.html#add-message-request-message-type-datasette-info {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} datasette.add_message() documentation is incorrect 1182065616  
1079582485 https://github.com/simonw/datasette/issues/1688#issuecomment-1079582485 https://api.github.com/repos/simonw/datasette/issues/1688 IC_kwDOBm6k_c5AWR8V simonw 9599 2022-03-26T03:15:34Z 2022-03-26T03:15:34Z OWNER Yup, you're right in what you figured out here: stand-alone plugins can't currently package static assets other then using the static folder. The `datasette-plugin` cookiecutter template should make creating a Python package pretty easy though: https://github.com/simonw/datasette-plugin You can run that yourself, or you can run it using this GitHub template repository: https://github.com/simonw/datasette-plugin-template-repository {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [plugins][documentation] Is it possible to serve per-plugin static folders when writing one-off (single file) plugins? 1181432624  
1079550754 https://github.com/simonw/datasette/issues/1688#issuecomment-1079550754 https://api.github.com/repos/simonw/datasette/issues/1688 IC_kwDOBm6k_c5AWKMi hydrosquall 9020979 2022-03-26T01:27:27Z 2022-03-26T03:16:29Z NONE > Is there a way to serve a static assets when using the plugins/ directory method instead of installing plugins as a new python package? As a workaround, I found I can serve my statics from a non-plugin specific folder using the [--static](https://docs.datasette.io/en/stable/custom_templates.html#serving-static-files) CLI flag. ```bash datasette ~/Library/Safari/History.db \ --plugins-dir=plugins/ \ --static assets:dist/ ``` It's not ideal because it means I'll change the cache pattern path depending on how the plugin is running (via pip install or as a one off script), but it's usable as a workaround. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} [plugins][documentation] Is it possible to serve per-plugin static folders when writing one-off (single file) plugins? 1181432624  
1079441621 https://github.com/simonw/sqlite-utils/issues/417#issuecomment-1079441621 https://api.github.com/repos/simonw/sqlite-utils/issues/417 IC_kwDOCGYnMM5AVvjV simonw 9599 2022-03-25T21:18:37Z 2022-03-25T21:18:37Z OWNER Updated documentation: https://sqlite-utils.datasette.io/en/latest/cli.html#inserting-newline-delimited-json {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} insert fails on JSONL with whitespace 1175744654  
1079407962 https://github.com/simonw/sqlite-utils/issues/421#issuecomment-1079407962 https://api.github.com/repos/simonw/sqlite-utils/issues/421 IC_kwDOCGYnMM5AVnVa simonw 9599 2022-03-25T20:25:10Z 2022-03-25T20:25:18Z OWNER Can you share either your whole `global.db` table or a shrunk down example that illustrates the bug? My hunch is that you may have a table or column with a name that triggers the error. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} "Error: near "(": syntax error" when using sqlite-utils indexes CLI 1180427792  
1079406708 https://github.com/simonw/sqlite-utils/issues/422#issuecomment-1079406708 https://api.github.com/repos/simonw/sqlite-utils/issues/422 IC_kwDOCGYnMM5AVnB0 simonw 9599 2022-03-25T20:23:21Z 2022-03-25T20:23:21Z OWNER Fixing this would require a bump to 4.0 because it would break existing code. The alternative would be to introduce a new `ignore_nulls=True` parameter which users can change to `ignore_nulls=False`. Or come up with better wording for that. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Reconsider not running convert functions against null values 1181236173  
1079404281 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1079404281 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5AVmb5 simonw 9599 2022-03-25T20:19:50Z 2022-03-25T20:19:50Z OWNER Now documented here: https://sqlite-utils.datasette.io/en/latest/cli.html#using-a-convert-function-to-execute-initialization {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1079384771 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1079384771 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5AVhrD simonw 9599 2022-03-25T19:51:34Z 2022-03-25T19:53:01Z OWNER This works: ``` % sqlite-utils insert dogs.db dogs dogs.json --convert ' import random print("seeding") random.seed(10) print(random.random()) def convert(row): global random print(row) row["random_score"] = random.random() ' seeding 0.5714025946899135 {'id': 1, 'name': 'Cleo'} {'id': 2, 'name': 'Pancakes'} {'id': 3, 'name': 'New dog'} (sqlite-utils) sqlite-utils % sqlite-utils rows dogs.db dogs [{"id": 1, "name": "Cleo", "random_score": 0.4288890546751146}, {"id": 2, "name": "Pancakes", "random_score": 0.5780913011344704}, {"id": 3, "name": "New dog", "random_score": 0.20609823213950174}] ``` Having to use `global random` inside the function is frustrating but apparently necessary. https://stackoverflow.com/a/56552138/6083 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1079376283 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1079376283 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5AVfmb simonw 9599 2022-03-25T19:39:30Z 2022-03-25T19:43:35Z OWNER Actually this doesn't work as I thought. This demo shows that the initialization code is run once per item, not a single time at the start of the run: ``` % sqlite-utils insert dogs.db dogs dogs.json --convert ' import random print("seeding") random.seed(10) print(random.random()) def convert(row): print(row) row["random_score"] = random.random() ' seeding 0.5714025946899135 seeding 0.5714025946899135 seeding 0.5714025946899135 seeding 0.5714025946899135 ``` Also that `print(row)` line is not being printed anywhere that gets to the console for some reason. ... my mistake, that happened because I changed this line in order to try to get local imports to work: ```python try: exec(code, globals, locals) return globals["convert"] except (AttributeError, SyntaxError, NameError, KeyError, TypeError): ``` It should be `locals["convert"]` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1079243535 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1079243535 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5AU_MP simonw 9599 2022-03-25T17:25:12Z 2022-03-25T17:25:12Z OWNER That documentation is split across a few places. This is the only bit that talks about `def convert()` pattern right now: - https://sqlite-utils.datasette.io/en/stable/cli.html#converting-data-in-columns But that's for `sqlite-utils convert` - the documentation for `sqlite-utils insert --convert` at https://sqlite-utils.datasette.io/en/stable/cli.html#applying-conversions-while-inserting-data doesn't mention it. Since both `sqlite-utils convert` and `sqlite-utils insert --convert` apply the same rules to the code, they should link to a shared explanation in the documentation. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1079018557 https://github.com/simonw/datasette/pull/1685#issuecomment-1079018557 https://api.github.com/repos/simonw/datasette/issues/1685 IC_kwDOBm6k_c5AUIQ9 codecov[bot] 22429695 2022-03-25T13:16:48Z 2022-03-25T13:16:48Z NONE # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1685?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1685](https://codecov.io/gh/simonw/datasette/pull/1685?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (933ce47) into [main](https://codecov.io/gh/simonw/datasette/commit/c496f2b663ff0cef908ffaaa68b8cb63111fb5f2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (c496f2b) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main #1685 +/- ## ======================================= Coverage 91.74% 91.74% ======================================= Files 34 34 Lines 4565 4565 ======================================= Hits 4188 4188 Misses 377 377 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1685?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1685?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [c496f2b...933ce47](https://codecov.io/gh/simonw/datasette/pull/1685?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/d… {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Update jinja2 requirement from <3.1.0,>=2.10.3 to >=2.10.3,<3.2.0 1180778860  
1078343231 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1078343231 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5ARjY_ simonw 9599 2022-03-24T21:16:10Z 2022-03-24T21:17:20Z OWNER Aha! This may be possible already: https://github.com/simonw/sqlite-utils/blob/396f80fcc60da8dd844577114f7920830a2e5403/sqlite_utils/utils.py#L311-L316 And yes, this does indeed work - you can do something like this: ``` echo '{"name": "harry"}' | sqlite-utils insert db.db people - --convert ' import time # Simulate something expensive time.sleep(1) def convert(row): row["upper"] = row["name"].upper() ' ``` And after running that: ``` sqlite-utils dump db.db BEGIN TRANSACTION; CREATE TABLE [people] ( [name] TEXT, [upper] TEXT ); INSERT INTO "people" VALUES('harry','HARRY'); COMMIT; ``` So this is a documentation issue - there's a trick for it but I didn't know what the trick was! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1078328774 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1078328774 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5ARf3G simonw 9599 2022-03-24T21:12:33Z 2022-03-24T21:12:33Z OWNER Here's how the `_compile_code()` mechanism works at the moment: https://github.com/simonw/sqlite-utils/blob/396f80fcc60da8dd844577114f7920830a2e5403/sqlite_utils/utils.py#L308-L342 At the end it does this: ```python return locals["fn"] ``` So it's already building and then returning a function. The question is if there's a sensible way to allow people to further customize that function by executing some code first, in a way that's easy to explain. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1078322301 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1078322301 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5AReR9 simonw 9599 2022-03-24T21:10:52Z 2022-03-24T21:10:52Z OWNER I can think of three ways forward: - Figure out a pattern that gets that local file import workaround to work - Add another option such as `--convert-init` that lets you pass code that will be executed once at the start - Come up with a pattern where the `--convert` code can run some initialization code and then return a function which will be called against each value I quite like the idea of that third option - I'm going to prototype it and see if I can work something out. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1078315922 https://github.com/simonw/sqlite-utils/issues/420#issuecomment-1078315922 https://api.github.com/repos/simonw/sqlite-utils/issues/420 IC_kwDOCGYnMM5ARcuS simonw 9599 2022-03-24T21:09:27Z 2022-03-24T21:09:27Z OWNER Yeah, this is WAY harder than it should be. There's a clumsy workaround you could use which looks something like this: create a file `my_enchant.py` containing: ```python import enchant d = enchant.Dict("en_US") def check(word): return d.check(word) ``` Then run `sqlite-utils` like this: ``` PYTHONPATH=. cat items.json | jq '.data' | sqlite-utils insert listings.db listings - --convert 'my_enchant.check(value)' --import my_enchant ``` Except I tried that and it doesn't work! I don't know the right pattern for getting `--import` to work with modules in the same directory. So yeah, this is definitely a big feature gap. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Document how to use a `--convert` function that runs initialization code first 1178546862  
1078126065 https://github.com/simonw/datasette/issues/1684#issuecomment-1078126065 https://api.github.com/repos/simonw/datasette/issues/1684 IC_kwDOBm6k_c5AQuXx fgregg 536941 2022-03-24T20:08:56Z 2022-03-24T20:13:19Z NONE would be nice if the behavior was 1. try to facet all the columns 2. for bigger tables try to facet the indexed columns 3. for the biggest tables, turn off autofacetting completely This is based on my assumption that what determines autofaceting is the rarity of unique values. Which may not be true! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Mechanism for disabling faceting on large tables only 1179998071  
1077671779 https://github.com/simonw/sqlite-utils/issues/399#issuecomment-1077671779 https://api.github.com/repos/simonw/sqlite-utils/issues/399 IC_kwDOCGYnMM5AO_dj eyeseast 25778 2022-03-24T14:11:33Z 2022-03-24T14:11:43Z CONTRIBUTOR Coming back to this. I was about to add a utility function to [datasette-geojson]() to convert lat/lng columns to geometries. Thankfully I googled first. There's a SpatiaLite function for this: [MakePoint](https://www.gaia-gis.it/gaia-sins/spatialite-sql-latest.html#p0). ```sql select MakePoint(longitude, latitude) as geometry from places; ``` I'm not sure if that would work with `conversions`, since it needs two columns, but it's an option for tables that already have latitude, longitude columns. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Make it easier to insert geometries, with documentation and maybe code 1124731464  
1077047295 https://github.com/simonw/datasette/issues/1581#issuecomment-1077047295 https://api.github.com/repos/simonw/datasette/issues/1581 IC_kwDOBm6k_c5AMm__ fgregg 536941 2022-03-24T04:08:18Z 2022-03-24T04:08:18Z NONE this has been addressed by the datasette-hashed-urls plugin {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} when hashed urls are turned on, the _memory db has improperly long-lived cache expiry 1089529555  
1077047152 https://github.com/simonw/datasette/pull/1582#issuecomment-1077047152 https://api.github.com/repos/simonw/datasette/issues/1582 IC_kwDOBm6k_c5AMm9w fgregg 536941 2022-03-24T04:07:58Z 2022-03-24T04:07:58Z NONE this has been obviated by the datasette-hashed-urls plugin {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} don't set far expiry if hash is '000' 1090055810  
1076696791 https://github.com/simonw/datasette/issues/1682#issuecomment-1076696791 https://api.github.com/repos/simonw/datasette/issues/1682 IC_kwDOBm6k_c5ALRbX simonw 9599 2022-03-23T18:45:49Z 2022-03-23T18:45:49Z OWNER The problem is here in `QueryView`: https://github.com/simonw/datasette/blob/d7c793d7998388d915f8d270079c68a77a785051/datasette/views/database.py#L206-L238 It should be resolving `database` based on the route path, as seen in other methods like this one: https://github.com/simonw/datasette/blob/d7c793d7998388d915f8d270079c68a77a785051/datasette/views/table.py#L270-L279 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} SQL queries against databases with different routes are broken 1178521513  
1076683297 https://github.com/simonw/datasette/issues/1670#issuecomment-1076683297 https://api.github.com/repos/simonw/datasette/issues/1670 IC_kwDOBm6k_c5ALOIh simonw 9599 2022-03-23T18:32:32Z 2022-03-23T18:32:32Z OWNER Added this to news on https://datasette.io/ https://github.com/simonw/datasette.io/commit/fd3ec57cdd5b935f75cbf52a86b3aabf2c97d217 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Ship Datasette 0.61 1174423568  
1076666293 https://github.com/simonw/datasette/issues/1670#issuecomment-1076666293 https://api.github.com/repos/simonw/datasette/issues/1670 IC_kwDOBm6k_c5ALJ-1 simonw 9599 2022-03-23T18:16:29Z 2022-03-23T18:16:29Z OWNER https://docs.datasette.io/en/stable/changelog.html#v0-61 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Ship Datasette 0.61 1174423568  
1076665837 https://github.com/simonw/datasette/issues/1670#issuecomment-1076665837 https://api.github.com/repos/simonw/datasette/issues/1670 IC_kwDOBm6k_c5ALJ3t simonw 9599 2022-03-23T18:16:01Z 2022-03-23T18:16:01Z OWNER https://github.com/simonw/datasette/releases/tag/0.61 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Ship Datasette 0.61 1174423568  
1076662556 https://github.com/simonw/sqlite-utils/pull/419#issuecomment-1076662556 https://api.github.com/repos/simonw/sqlite-utils/issues/419 IC_kwDOCGYnMM5ALJEc codecov[bot] 22429695 2022-03-23T18:12:47Z 2022-03-23T18:12:47Z NONE # [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#419](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (228f736) into [main](https://codecov.io/gh/simonw/sqlite-utils/commit/93fa79d30b1531bea281d0eb6b925c4e61bc1aa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (93fa79d) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main #419 +/- ## ======================================= Coverage 96.55% 96.55% ======================================= Files 6 6 Lines 2498 2498 ======================================= Hits 2412 2412 Misses 86 86 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [93fa79d...228f736](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.… {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Ignore common generated files 1178484369  
1076652046 https://github.com/simonw/datasette/issues/1670#issuecomment-1076652046 https://api.github.com/repos/simonw/datasette/issues/1670 IC_kwDOBm6k_c5ALGgO simonw 9599 2022-03-23T18:02:30Z 2022-03-23T18:02:30Z OWNER Two new things to add to the release notes from https://github.com/simonw/datasette/compare/0.61a0...main - https://github.com/simonw/datasette/issues/1678 - https://github.com/simonw/datasette/issues/1675 (now also a documented API) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Ship Datasette 0.61 1174423568  
1076647495 https://github.com/simonw/datasette/issues/1670#issuecomment-1076647495 https://api.github.com/repos/simonw/datasette/issues/1670 IC_kwDOBm6k_c5ALFZH simonw 9599 2022-03-23T17:58:16Z 2022-03-23T17:58:16Z OWNER I think the release notes are fine, but they need an opening paragraph highlighting the changes that are most likely to break backwards compatibility. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Ship Datasette 0.61 1174423568  
1076645636 https://github.com/simonw/datasette/pull/1574#issuecomment-1076645636 https://api.github.com/repos/simonw/datasette/issues/1574 IC_kwDOBm6k_c5ALE8E simonw 9599 2022-03-23T17:56:35Z 2022-03-23T17:56:35Z OWNER I'd actually like to switch to slim as the default - I think Datasette should ship the smallest possible container that can still support extra packages being installed using `apt-get install`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} introduce new option for datasette package to use a slim base image 1084193403  
1076644362 https://github.com/simonw/datasette/pull/1665#issuecomment-1076644362 https://api.github.com/repos/simonw/datasette/issues/1665 IC_kwDOBm6k_c5ALEoK simonw 9599 2022-03-23T17:55:39Z 2022-03-23T17:55:39Z OWNER Thanks for the PR - I spotted an error about this and went through and fixed this in all of my repos the other day: https://github.com/search?o=desc&q=user%3Asimonw+google-github-actions%2Fsetup-gcloud%40v0&s=committer-date&type=Commits {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Pin setup-gcloud to v0 instead of master 1173828092  
1076638278 https://github.com/simonw/datasette/issues/1670#issuecomment-1076638278 https://api.github.com/repos/simonw/datasette/issues/1670 IC_kwDOBm6k_c5ALDJG simonw 9599 2022-03-23T17:50:55Z 2022-03-23T17:50:55Z OWNER Release notes are mostly written for the alpha, just need to clean them up a bit https://github.com/simonw/datasette/blob/c4c9dbd0386e46d2bf199f0ed34e4895c98cb78c/docs/changelog.rst#061a0-2022-03-19 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Ship Datasette 0.61 1174423568  
1075438684 https://github.com/simonw/datasette/issues/1681#issuecomment-1075438684 https://api.github.com/repos/simonw/datasette/issues/1681 IC_kwDOBm6k_c5AGeRc simonw 9599 2022-03-22T17:45:50Z 2022-03-22T17:49:09Z OWNER I would expect this to break against SQL views that include calculated columns though - something like this: ```sql create view this_will_break as select pk + 1 as pk_plus_one, 0.5 as score from searchable; ``` Confirmed: the filter interface for that view plain doesn't work for any comparison against that table - except for `score > 0` since `0` is converted to an integer. `0.1` breaks though because it doesn't get converted as it doesn't match `.isdigit()`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Potential bug in numeric handling where_clause for filters 1177101697  
1075437598 https://github.com/simonw/datasette/issues/1681#issuecomment-1075437598 https://api.github.com/repos/simonw/datasette/issues/1681 IC_kwDOBm6k_c5AGeAe simonw 9599 2022-03-22T17:44:42Z 2022-03-22T17:45:04Z OWNER My hunch is that this mechanism doesn't actually do anything useful at all, because of the type conversion that automatically happens for data from tables based on the column type affinities, see: - #1671 So either remove the `self.numeric` type conversion bit entirely, or prove that it is necessary and upgrade it to be able to handle floating point values too. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Potential bug in numeric handling where_clause for filters 1177101697  
1075435185 https://github.com/simonw/datasette/issues/1671#issuecomment-1075435185 https://api.github.com/repos/simonw/datasette/issues/1671 IC_kwDOBm6k_c5AGdax simonw 9599 2022-03-22T17:42:09Z 2022-03-22T17:42:09Z OWNER Also made me realize that this query: ```sql select * from sortable where sortable > :p0 ``` Only works here thanks to the column affinity thing kicking in too: https://latest.datasette.io/fixtures?sql=select+*+from+sortable+where+sortable+%3E+%3Ap0&p0=70 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Filters fail to work correctly against calculated numeric columns returned by SQL views because type affinity rules do not apply 1174655187  
1075432283 https://github.com/simonw/datasette/issues/1671#issuecomment-1075432283 https://api.github.com/repos/simonw/datasette/issues/1671 IC_kwDOBm6k_c5AGctb simonw 9599 2022-03-22T17:39:04Z 2022-03-22T17:43:12Z OWNER Note that Datasette does already have special logic to convert parameters to integers for numeric comparisons like `>`: https://github.com/simonw/datasette/blob/c4c9dbd0386e46d2bf199f0ed34e4895c98cb78c/datasette/filters.py#L203-L212 Though... it looks like there's a bug in that? It doesn't account for `float` values - `"3.5".isdigit()` return `False` - probably for the best, because `int(3.5)` would break that value anyway. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Filters fail to work correctly against calculated numeric columns returned by SQL views because type affinity rules do not apply 1174655187  
1075428030 https://github.com/simonw/datasette/issues/1671#issuecomment-1075428030 https://api.github.com/repos/simonw/datasette/issues/1671 IC_kwDOBm6k_c5AGbq- simonw 9599 2022-03-22T17:34:30Z 2022-03-22T17:34:30Z OWNER No, I think I need to use `cast` - I can't think of any way to ask SQLite "for this query, what types are the columns that will come back from it?" Even the details from the `explain` trick explored in #1293 don't seem to come back with column type information: https://latest.datasette.io/fixtures?sql=explain+select+pk%2C+text1%2C+text2%2C+[name+with+.+and+spaces]+from+searchable_view+where+%22pk%22+%3D+%3Ap0&p0=1 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Filters fail to work correctly against calculated numeric columns returned by SQL views because type affinity rules do not apply 1174655187  
1075425513 https://github.com/simonw/datasette/issues/1671#issuecomment-1075425513 https://api.github.com/repos/simonw/datasette/issues/1671 IC_kwDOBm6k_c5AGbDp simonw 9599 2022-03-22T17:31:53Z 2022-03-22T17:31:53Z OWNER The alternative to using `cast` here would be for Datasette to convert the `"1"` to a `1` in Python code before passing it as a param. This feels a bit neater to me, but I still then need to solve the problem of how to identify the "type" of a column that I want to use in a query. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Filters fail to work correctly against calculated numeric columns returned by SQL views because type affinity rules do not apply 1174655187  
1074479932 https://github.com/simonw/datasette/issues/339#issuecomment-1074479932 https://api.github.com/repos/simonw/datasette/issues/339 IC_kwDOBm6k_c5AC0M8 simonw 9599 2022-03-21T22:22:34Z 2022-03-21T22:22:34Z OWNER Closing this as obsolete since Datasette no longer uses Sanic. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Expose SANIC_RESPONSE_TIMEOUT config option in a sensible way 340396247  
1074479768 https://github.com/simonw/datasette/issues/276#issuecomment-1074479768 https://api.github.com/repos/simonw/datasette/issues/276 IC_kwDOBm6k_c5AC0KY simonw 9599 2022-03-21T22:22:20Z 2022-03-21T22:22:20Z OWNER I'm closing this issue because this is now solved by a number of neat plugins: - https://datasette.io/plugins/datasette-geojson-map shows the geometry from SpatiaLite columns on a map - https://datasette.io/plugins/datasette-leaflet-geojson can be used to display inline maps next to each column {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Handle spatialite geometry columns better 324835838  

Next page

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);