issue_comments
4 rows where "created_at" is on date 2022-07-17 sorted by reactions
This data as json, CSV (advanced)
id | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions ▼ | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1186620168 | https://github.com/simonw/datasette/issues/1770#issuecomment-1186620168 | https://api.github.com/repos/simonw/datasette/issues/1770 | IC_kwDOBm6k_c5GumMI | simonw 9599 | 2022-07-17T22:37:01Z | 2022-07-17T22:37:01Z | OWNER | I need to refactor this code so that `Forbidden` exceptions are handled separately. Reason is that those already have a plugin hook of their own: https://github.com/simonw/datasette/blob/8188f55efc0fcca1be692b0d0c875f2d1ee99f17/datasette/app.py#L1384-L1395 My first attempt at this refactored that entire `handle_exception` method to call the new plugin hook, moving its current implementation into a `datasette/handle_exception.py` default plugin implementation - but it felt weird having that plugin implementation then itself call the `pm.hook.forbidden()` hook. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `handle_exception` plugin hook for custom error handling 1306492437 | |
1186620367 | https://github.com/simonw/datasette/issues/1770#issuecomment-1186620367 | https://api.github.com/repos/simonw/datasette/issues/1770 | IC_kwDOBm6k_c5GumPP | simonw 9599 | 2022-07-17T22:38:25Z | 2022-07-17T22:38:25Z | OWNER | I think this is the right place to move the code to catch `Forbidden` exceptions (and forwards them to that plugin hook): https://github.com/simonw/datasette/blob/8188f55efc0fcca1be692b0d0c875f2d1ee99f17/datasette/app.py#L1269-L1278 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `handle_exception` plugin hook for custom error handling 1306492437 | |
1186629556 | https://github.com/simonw/datasette/issues/1770#issuecomment-1186629556 | https://api.github.com/repos/simonw/datasette/issues/1770 | IC_kwDOBm6k_c5Guoe0 | simonw 9599 | 2022-07-17T23:25:08Z | 2022-07-17T23:25:08Z | OWNER | Keeping this issue open until I've proven the new plugin hook works by releasing a plugin that uses it. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `handle_exception` plugin hook for custom error handling 1306492437 | |
1186630298 | https://github.com/simonw/datasette/issues/1770#issuecomment-1186630298 | https://api.github.com/repos/simonw/datasette/issues/1770 | IC_kwDOBm6k_c5Guoqa | simonw 9599 | 2022-07-17T23:29:37Z | 2022-07-17T23:29:37Z | OWNER | Documentation for the new hook: https://docs.datasette.io/en/latest/plugin_hooks.html#handle-exception-datasette-request-exception | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | `handle_exception` plugin hook for custom error handling 1306492437 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
updated_at (date) 1 ✖