issue_comments

Table actions

3 rows where issue = 505818256

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, author_association, created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
541495034 https://github.com/simonw/datasette/pull/590#issuecomment-541495034 https://api.github.com/repos/simonw/datasette/issues/590 MDEyOklzc3VlQ29tbWVudDU0MTQ5NTAzNA== simonw 9599 2019-10-14T03:51:32Z 2019-10-14T03:51:32Z OWNER We need some unit tests for this. I'd be fine with us renaming `extra_database.db` to `extra database.py` in these existing fixtures: https://github.com/simonw/datasette/blob/af2e6a5cf186a7200d76cb67ac30fa59cc24d84e/tests/fixtures.py#L174-L185 Then we could add an extra `test_database_name_with_spaces(...)` test in `test_api.py` which uses parametrize to exercise a bunch of URLs and check they all return a 200 - something a bit like this but covering a range of URL paths (one for database, table, row and table with filters): https://github.com/simonw/datasette/blob/90d4f497f9b3f6a5882937c91fddb496ac3e7368/tests/test_api.py#L746-L765 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Handle spaces in DB names 505818256  
541562581 https://github.com/simonw/datasette/pull/590#issuecomment-541562581 https://api.github.com/repos/simonw/datasette/issues/590 MDEyOklzc3VlQ29tbWVudDU0MTU2MjU4MQ== rixx 2657547 2019-10-14T08:57:46Z 2019-10-14T08:57:46Z CONTRIBUTOR Ah, thank you – I saw the need for unit tests but wasn't sure what the best way to add one would be. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Handle spaces in DB names 505818256  
541587823 https://github.com/simonw/datasette/pull/590#issuecomment-541587823 https://api.github.com/repos/simonw/datasette/issues/590 MDEyOklzc3VlQ29tbWVudDU0MTU4NzgyMw== rixx 2657547 2019-10-14T09:58:23Z 2019-10-14T09:58:23Z CONTRIBUTOR Added tests. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Handle spaces in DB names 505818256  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);