issue_comments
9,947 rows sorted by issue_url
This data as json, CSV (advanced)
id | html_url | issue_url ▼ | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
849311884 | https://github.com/simonw/datasette/pull/1319#issuecomment-849311884 | https://api.github.com/repos/simonw/datasette/issues/1319 | MDEyOklzc3VlQ29tbWVudDg0OTMxMTg4NA== | simonw 9599 | 2021-05-27T04:33:51Z | 2021-05-27T04:33:51Z | OWNER | This is so cool! I wonder how I can best test it? I have a Raspberry Pi I should dig out to try this. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Docker multi-arch support with Buildx 881219362 | |
849313380 | https://github.com/simonw/datasette/pull/1319#issuecomment-849313380 | https://api.github.com/repos/simonw/datasette/issues/1319 | MDEyOklzc3VlQ29tbWVudDg0OTMxMzM4MA== | codecov[bot] 22429695 | 2021-05-27T04:38:44Z | 2021-05-27T04:38:44Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1319](https://codecov.io/gh/simonw/datasette/pull/1319?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (cfca570) into [main](https://codecov.io/gh/simonw/datasette/commit/1b697539f5b53cec3fe13c0f4ada13ba655c88c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (1b69753) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1319/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1319 +/- ## ========================================== + Coverage 91.51% 91.53% +0.02% ========================================== Files 34 34 Lines 4255 4255 ========================================== + Hits 3894 3895 +1 + Misses 361 360 -1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/datasette/pull/1319/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.31% <0.00%> (+0.… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Docker multi-arch support with Buildx 881219362 | |
849778373 | https://github.com/simonw/datasette/pull/1319#issuecomment-849778373 | https://api.github.com/repos/simonw/datasette/issues/1319 | MDEyOklzc3VlQ29tbWVudDg0OTc3ODM3Mw== | simonw 9599 | 2021-05-27T16:37:50Z | 2021-05-27T16:37:50Z | OWNER | Started [a conversation](https://twitter.com/simonw/status/1397953338407223303) about this on Twitter. Ideally I'd like to push an alpha release to Docker Hub so people can start testing these out before they make it into an official non-alpha release. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Docker multi-arch support with Buildx 881219362 | |
849780481 | https://github.com/simonw/datasette/pull/1319#issuecomment-849780481 | https://api.github.com/repos/simonw/datasette/issues/1319 | MDEyOklzc3VlQ29tbWVudDg0OTc4MDQ4MQ== | simonw 9599 | 2021-05-27T16:41:03Z | 2021-05-27T16:41:03Z | OWNER | It looks like all I need to do to ship an alpha version to Docker Hub is NOT point the `latest` tag at it after it goes live: https://github.com/simonw/datasette/blob/1a8972f9c012cd22b088c6b70661a9c3d3847853/.github/workflows/publish.yml#L75-L77 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Docker multi-arch support with Buildx 881219362 | |
849785098 | https://github.com/simonw/datasette/pull/1319#issuecomment-849785098 | https://api.github.com/repos/simonw/datasette/issues/1319 | MDEyOklzc3VlQ29tbWVudDg0OTc4NTA5OA== | simonw 9599 | 2021-05-27T16:48:21Z | 2021-05-27T16:48:21Z | OWNER | OK, since I have a mechanism for deploying alpha versions now I'm going to merge this and use it to publish 0.57a1. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Docker multi-arch support with Buildx 881219362 | |
346701751 | https://github.com/simonw/datasette/issues/132#issuecomment-346701751 | https://api.github.com/repos/simonw/datasette/issues/132 | MDEyOklzc3VlQ29tbWVudDM0NjcwMTc1MQ== | simonw 9599 | 2017-11-23T21:51:51Z | 2017-11-23T21:51:51Z | OWNER | <img width="846" alt="fatal-police-shootings-data__fatal-police-shootings-data" src="https://user-images.githubusercontent.com/9599/33189202-73891af2-d055-11e7-9e79-6be7d8df36aa.png"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Row view is not currently expanding foreign keys 275175929 | |
847223853 | https://github.com/simonw/datasette/issues/1320#issuecomment-847223853 | https://api.github.com/repos/simonw/datasette/issues/1320 | MDEyOklzc3VlQ29tbWVudDg0NzIyMzg1Mw== | simonw 9599 | 2021-05-24T17:51:12Z | 2021-05-24T17:51:12Z | OWNER | This is a good catch, thank you. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Can't use apt-get in Dockerfile when using datasetteproj/datasette as base 884952179 | |
847230866 | https://github.com/simonw/datasette/issues/1320#issuecomment-847230866 | https://api.github.com/repos/simonw/datasette/issues/1320 | MDEyOklzc3VlQ29tbWVudDg0NzIzMDg2Ng== | simonw 9599 | 2021-05-24T18:03:29Z | 2021-05-24T18:03:29Z | OWNER | ``` root@33c269900821:/# du -h /var/lib/dpkg 6.3M /var/lib/dpkg/info 24K /var/lib/dpkg/triggers 4.0K /var/lib/dpkg/updates 20K /var/lib/dpkg/alternatives 4.0K /var/lib/dpkg/parts 6.7M /var/lib/dpkg ``` So `/var/lib/dpkg/info` is most of the space, I'll try just deleting that. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Can't use apt-get in Dockerfile when using datasetteproj/datasette as base 884952179 | |
847232547 | https://github.com/simonw/datasette/issues/1320#issuecomment-847232547 | https://api.github.com/repos/simonw/datasette/issues/1320 | MDEyOklzc3VlQ29tbWVudDg0NzIzMjU0Nw== | simonw 9599 | 2021-05-24T18:06:32Z | 2021-05-24T18:06:32Z | OWNER | I'm testing tweaks to the Dockerfile by editing it and running: ``` docker build . -t datasette-057a0 --build-arg VERSION=0.57a0 ``` Then running this to inspect the new image: ``` docker run -it -p 8001:8001 datasette-057a0 bash ``` After changing that line to `rm -rf /var/lib/dpkg/info/*` I can run `apt-get` successfully from inside that bash prompt: ``` # apt-get update # apt-get install ripgrep # rg --version ripgrep 12.1.1 ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Can't use apt-get in Dockerfile when using datasetteproj/datasette as base 884952179 | |
847237524 | https://github.com/simonw/datasette/issues/1320#issuecomment-847237524 | https://api.github.com/repos/simonw/datasette/issues/1320 | MDEyOklzc3VlQ29tbWVudDg0NzIzNzUyNA== | simonw 9599 | 2021-05-24T18:15:56Z | 2021-05-24T18:15:56Z | OWNER | Added some new documentation about that here: https://github.com/simonw/datasette/blob/c0a748e5c3f498fa8c139b420d07dd3dea612379/docs/installation.rst#installing-plugins | {"total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Can't use apt-get in Dockerfile when using datasetteproj/datasette as base 884952179 | |
838458014 | https://github.com/simonw/datasette/pull/1321#issuecomment-838458014 | https://api.github.com/repos/simonw/datasette/issues/1321 | MDEyOklzc3VlQ29tbWVudDgzODQ1ODAxNA== | codecov[bot] 22429695 | 2021-05-11T13:18:12Z | 2021-05-11T13:18:12Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1321?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1321](https://codecov.io/gh/simonw/datasette/pull/1321?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (966ced8) into [main](https://codecov.io/gh/simonw/datasette/commit/1b697539f5b53cec3fe13c0f4ada13ba655c88c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (1b69753) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1321/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1321 +/- ## ========================================== + Coverage 91.51% 91.53% +0.02% ========================================== Files 34 34 Lines 4255 4255 ========================================== + Hits 3894 3895 +1 + Misses 361 360 -1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/datasette/pull/1321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.31% <0.00%> (+0.… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Bump black from 21.4b2 to 21.5b1 887241681 | |
839763331 | https://github.com/simonw/datasette/pull/1323#issuecomment-839763331 | https://api.github.com/repos/simonw/datasette/issues/1323 | MDEyOklzc3VlQ29tbWVudDgzOTc2MzMzMQ== | codecov[bot] 22429695 | 2021-05-12T13:14:50Z | 2021-05-17T17:25:17Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1323](https://codecov.io/gh/simonw/datasette/pull/1323?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (cd69502) into [main](https://codecov.io/gh/simonw/datasette/commit/5e60bad40460f68122006ce704cfc163d6076f34?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (5e60bad) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1323/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1323 +/- ## ========================================== + Coverage 91.51% 91.53% +0.02% ========================================== Files 34 34 Lines 4255 4255 ========================================== + Hits 3894 3895 +1 + Misses 361 360 -1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/datasette/pull/1323/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.31% <0.00%> (+0.… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update click requirement from ~=7.1.1 to >=7.1.1,<8.1.0 890073888 | |
839763280 | https://github.com/simonw/datasette/pull/1324#issuecomment-839763280 | https://api.github.com/repos/simonw/datasette/issues/1324 | MDEyOklzc3VlQ29tbWVudDgzOTc2MzI4MA== | codecov[bot] 22429695 | 2021-05-12T13:14:44Z | 2021-05-12T13:14:44Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1324](https://codecov.io/gh/simonw/datasette/pull/1324?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (177456e) into [main](https://codecov.io/gh/simonw/datasette/commit/1b697539f5b53cec3fe13c0f4ada13ba655c88c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (1b69753) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1324/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1324 +/- ## ========================================== + Coverage 91.51% 91.53% +0.02% ========================================== Files 34 34 Lines 4255 4255 ========================================== + Hits 3894 3895 +1 + Misses 361 360 -1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/datasette/pull/1324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.31% <0.00%> (+0.… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update jinja2 requirement from <2.12.0,>=2.10.3 to >=2.10.3,<3.1.0 890073940 | |
842494844 | https://github.com/simonw/datasette/pull/1324#issuecomment-842494844 | https://api.github.com/repos/simonw/datasette/issues/1324 | MDEyOklzc3VlQ29tbWVudDg0MjQ5NDg0NA== | simonw 9599 | 2021-05-17T17:16:36Z | 2021-05-17T17:16:36Z | OWNER | Refs #1331. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update jinja2 requirement from <2.12.0,>=2.10.3 to >=2.10.3,<3.1.0 890073940 | |
839763094 | https://github.com/simonw/datasette/pull/1325#issuecomment-839763094 | https://api.github.com/repos/simonw/datasette/issues/1325 | MDEyOklzc3VlQ29tbWVudDgzOTc2MzA5NA== | codecov[bot] 22429695 | 2021-05-12T13:14:29Z | 2021-05-12T13:14:29Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1325](https://codecov.io/gh/simonw/datasette/pull/1325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (4dea180) into [main](https://codecov.io/gh/simonw/datasette/commit/1b697539f5b53cec3fe13c0f4ada13ba655c88c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (1b69753) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1325/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1325 +/- ## ========================================== + Coverage 91.51% 91.53% +0.02% ========================================== Files 34 34 Lines 4255 4255 ========================================== + Hits 3894 3895 +1 + Misses 361 360 -1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/datasette/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.31% <0.00%> (+0.… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update itsdangerous requirement from ~=1.1 to >=1.1,<3.0 890073989 | |
846138580 | https://github.com/simonw/datasette/pull/1325#issuecomment-846138580 | https://api.github.com/repos/simonw/datasette/issues/1325 | MDEyOklzc3VlQ29tbWVudDg0NjEzODU4MA== | stonebig 4312421 | 2021-05-21T18:00:10Z | 2021-05-21T18:00:10Z | NONE | would be nice to have | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update itsdangerous requirement from ~=1.1 to >=1.1,<3.0 890073989 | |
846493370 | https://github.com/simonw/datasette/issues/1326#issuecomment-846493370 | https://api.github.com/repos/simonw/datasette/issues/1326 | MDEyOklzc3VlQ29tbWVudDg0NjQ5MzM3MA== | simonw 9599 | 2021-05-23T02:55:00Z | 2021-05-23T02:55:00Z | OWNER | Currently you can do this with a custom SQL query, but as you've noticed this means you don't get automatic pagination: https://latest.datasette.io/fixtures.json?sql=select+pk%2C+created%2C+state+from+facetable+order+by+pk+limit+10&_shape=array I have an open issue to allow selecting specific columns on the table page: #615 A workaround you can use today is to define a SQL view that selects just the tables you want. View pages behave exactly like tables in that they provide pagination by default. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | How to limit fields returned from the JSON API? 891969037 | |
847240470 | https://github.com/simonw/datasette/issues/1327#issuecomment-847240470 | https://api.github.com/repos/simonw/datasette/issues/1327 | MDEyOklzc3VlQ29tbWVudDg0NzI0MDQ3MA== | simonw 9599 | 2021-05-24T18:21:44Z | 2021-05-24T18:21:44Z | OWNER | I'm having trouble replicating this - I tried the following `metadata.json` in my local environment and it displayed correctly: ```json { "title": "မြန်မာစာ (" } ``` What operating system are you using here? Is there a chance that your `metadata.json` file is saved in a text encoding other than utf-8? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Support Unicode characters in metadata.json 892457208 | |
847271122 | https://github.com/simonw/datasette/issues/1327#issuecomment-847271122 | https://api.github.com/repos/simonw/datasette/issues/1327 | MDEyOklzc3VlQ29tbWVudDg0NzI3MTEyMg== | GmGniap 20846286 | 2021-05-24T19:10:21Z | 2021-05-24T19:10:21Z | NONE | wow, thanks a lot @simonw , problem is solved. I converted my current json file into utf-8 format with Python script. It's working now. I'm using with Window 10. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Support Unicode characters in metadata.json 892457208 | |
345601870 | https://github.com/simonw/datasette/issues/133#issuecomment-345601870 | https://api.github.com/repos/simonw/datasette/issues/133 | MDEyOklzc3VlQ29tbWVudDM0NTYwMTg3MA== | simonw 9599 | 2017-11-20T06:18:53Z | 2017-11-20T06:18:53Z | OWNER | This may be tackled by the filters work happening in #86 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | If view is filtered, search should apply within those filtered rows 275176006 | |
346705879 | https://github.com/simonw/datasette/issues/133#issuecomment-346705879 | https://api.github.com/repos/simonw/datasette/issues/133 | MDEyOklzc3VlQ29tbWVudDM0NjcwNTg3OQ== | simonw 9599 | 2017-11-23T22:43:42Z | 2017-11-24T22:07:46Z | OWNER | Easiest way to do this will be to move it into the same `<form>` as the filters. Would be nice to detect `?_search=<blank>` and redirect to URL without the `_search` parameter, just for aesthetics. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | If view is filtered, search should apply within those filtered rows 275176006 | |
346902583 | https://github.com/simonw/datasette/issues/133#issuecomment-346902583 | https://api.github.com/repos/simonw/datasette/issues/133 | MDEyOklzc3VlQ29tbWVudDM0NjkwMjU4Mw== | simonw 9599 | 2017-11-24T22:30:32Z | 2017-11-24T22:30:32Z | OWNER | <img width="662" alt="sf-trees__street_tree_list__1_row_where_search_matches__ocean___qcareassistant____1__qcareassistant_is_not_blank_and_qlegalstatus___1" src="https://user-images.githubusercontent.com/9599/33224944-03bf054a-d124-11e7-8a97-58c8dee892a1.png"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | If view is filtered, search should apply within those filtered rows 275176006 | |
842312696 | https://github.com/simonw/datasette/pull/1330#issuecomment-842312696 | https://api.github.com/repos/simonw/datasette/issues/1330 | MDEyOklzc3VlQ29tbWVudDg0MjMxMjY5Ng== | codecov[bot] 22429695 | 2021-05-17T13:11:54Z | 2021-05-17T13:11:54Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1330](https://codecov.io/gh/simonw/datasette/pull/1330?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (cc1b504) into [main](https://codecov.io/gh/simonw/datasette/commit/1b697539f5b53cec3fe13c0f4ada13ba655c88c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (1b69753) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1330/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1330?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1330 +/- ## ========================================== + Coverage 91.51% 91.53% +0.02% ========================================== Files 34 34 Lines 4255 4255 ========================================== + Hits 3894 3895 +1 + Misses 361 360 -1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1330?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/datasette/pull/1330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.31% <0.00%> (+0.… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update aiofiles requirement from <0.7,>=0.4 to >=0.4,<0.8 893314402 | |
842494332 | https://github.com/simonw/datasette/issues/1331#issuecomment-842494332 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0MjQ5NDMzMg== | simonw 9599 | 2021-05-17T17:15:45Z | 2021-05-17T17:16:04Z | OWNER | Datasette uses async templates which evidently have been improved in Jinja 2 3.0. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
842495346 | https://github.com/simonw/datasette/issues/1331#issuecomment-842495346 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0MjQ5NTM0Ng== | simonw 9599 | 2021-05-17T17:17:19Z | 2021-05-17T17:17:19Z | OWNER | The tests are passing on #1324 so this may not require any code changes at all! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
842495820 | https://github.com/simonw/datasette/issues/1331#issuecomment-842495820 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0MjQ5NTgyMA== | MarkusH 475613 | 2021-05-17T17:18:05Z | 2021-05-17T17:18:05Z | NONE | Wow, you are _fast_! I didn't notice dependabot had opened a PR already. I was about to. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
842497125 | https://github.com/simonw/datasette/issues/1331#issuecomment-842497125 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0MjQ5NzEyNQ== | simonw 9599 | 2021-05-17T17:20:15Z | 2021-05-17T17:20:15Z | OWNER | I wonder if there are any new 3.0 features we should be taking advantage of here that would justify pinning to 3.0 minimum? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
842499728 | https://github.com/simonw/datasette/issues/1331#issuecomment-842499728 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0MjQ5OTcyOA== | MarkusH 475613 | 2021-05-17T17:24:30Z | 2021-05-17T17:24:30Z | NONE | > I wonder if there are any new 3.0 features we should be taking advantage of here that would justify pinning to 3.0 minimum? The changelog reads like bug fixes and removal of deprecated parts to me | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
844970776 | https://github.com/simonw/datasette/issues/1331#issuecomment-844970776 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0NDk3MDc3Ng== | MarkusH 475613 | 2021-05-20T10:40:25Z | 2021-05-20T10:40:25Z | NONE | Any chance you could push a new datasette release with the updated dependencies in the setup.py, @simonw? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
846137332 | https://github.com/simonw/datasette/issues/1331#issuecomment-846137332 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0NjEzNzMzMg== | stonebig 4312421 | 2021-05-21T17:57:53Z | 2021-05-21T17:57:53Z | NONE | I'm stuck also because datasette wants itsdangerous~=1.1 instead of allowing itsdangerous-2.0.0 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
846481937 | https://github.com/simonw/datasette/issues/1331#issuecomment-846481937 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0NjQ4MTkzNw== | simonw 9599 | 2021-05-23T00:38:28Z | 2021-05-23T00:38:28Z | OWNER | I'm going to push an alpha release with the new dependencies shortly. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
846482057 | https://github.com/simonw/datasette/issues/1331#issuecomment-846482057 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0NjQ4MjA1Nw== | simonw 9599 | 2021-05-23T00:39:55Z | 2021-05-23T00:39:55Z | OWNER | > I'm stuck also because datasette wants itsdangerous~=1.1 instead of allowing itsdangerous-2.0.0 Bumped that dependency in b64d87204612a84663616e075f542499a5d82a03 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
846483426 | https://github.com/simonw/datasette/issues/1331#issuecomment-846483426 | https://api.github.com/repos/simonw/datasette/issues/1331 | MDEyOklzc3VlQ29tbWVudDg0NjQ4MzQyNg== | simonw 9599 | 2021-05-23T00:57:30Z | 2021-05-23T00:57:30Z | OWNER | Here's an alpha release with updated dependencies: https://pypi.org/project/datasette/0.57a0/ | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Jinja2 version 3.0 893537744 | |
846479062 | https://github.com/simonw/datasette/issues/1332#issuecomment-846479062 | https://api.github.com/repos/simonw/datasette/issues/1332 | MDEyOklzc3VlQ29tbWVudDg0NjQ3OTA2Mg== | simonw 9599 | 2021-05-23T00:06:34Z | 2021-05-23T00:06:34Z | OWNER | A URL parameter to modify that facet size is a really good idea. I thought I had an issue open for "..." linking to more results but I can't find it now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_facet_size=X to increase number of facets results on the page 893890496 | |
846479212 | https://github.com/simonw/datasette/issues/1332#issuecomment-846479212 | https://api.github.com/repos/simonw/datasette/issues/1332 | MDEyOklzc3VlQ29tbWVudDg0NjQ3OTIxMg== | simonw 9599 | 2021-05-23T00:07:46Z | 2021-05-23T00:07:46Z | OWNER | `?_facet_size=50` seems like a very reasonable thing to support - I'll cap it at whatever the `max_returned_rows` setting is (which defaults to 1000). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_facet_size=X to increase number of facets results on the page 893890496 | |
846479730 | https://github.com/simonw/datasette/issues/1332#issuecomment-846479730 | https://api.github.com/repos/simonw/datasette/issues/1332 | MDEyOklzc3VlQ29tbWVudDg0NjQ3OTczMA== | simonw 9599 | 2021-05-23T00:11:31Z | 2021-05-23T00:11:31Z | OWNER | Here's the code in question: https://github.com/simonw/datasette/blob/5e9672c9bb33e41686472db4aa427168f9e67dbe/datasette/facets.py#L187-L210 It has access to the current request object as `self.request`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_facet_size=X to increase number of facets results on the page 893890496 | |
846481801 | https://github.com/simonw/datasette/issues/1332#issuecomment-846481801 | https://api.github.com/repos/simonw/datasette/issues/1332 | MDEyOklzc3VlQ29tbWVudDg0NjQ4MTgwMQ== | simonw 9599 | 2021-05-23T00:36:20Z | 2021-05-23T00:36:20Z | OWNER | Documentation: - https://docs.datasette.io/en/latest/facets.html#facets-in-query-strings at the bottom of the section - https://docs.datasette.io/en/latest/json_api.html#special-table-arguments at the bottom of the list of arguments | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_facet_size=X to increase number of facets results on the page 893890496 | |
849761894 | https://github.com/simonw/datasette/issues/1332#issuecomment-849761894 | https://api.github.com/repos/simonw/datasette/issues/1332 | MDEyOklzc3VlQ29tbWVudDg0OTc2MTg5NA== | simonw 9599 | 2021-05-27T16:13:07Z | 2021-05-27T16:13:07Z | OWNER | Added `?_facet_size=max` in #1337 and made the `...` truncated note link to that - here's a demo: https://fivethirtyeight.datasettes.com/fivethirtyeight/antiquities-act%2Factions_under_antiquities_act?_facet=states&_facet=current_agency&_facet=pres_or_congress | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_facet_size=X to increase number of facets results on the page 893890496 | |
844007155 | https://github.com/simonw/datasette/pull/1335#issuecomment-844007155 | https://api.github.com/repos/simonw/datasette/issues/1335 | MDEyOklzc3VlQ29tbWVudDg0NDAwNzE1NQ== | codecov[bot] 22429695 | 2021-05-19T11:21:45Z | 2021-05-19T11:21:45Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1335](https://codecov.io/gh/simonw/datasette/pull/1335?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (d91c18d) into [main](https://codecov.io/gh/simonw/datasette/commit/9b3b7e280ca718254b4ca15d40864297146a85b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (9b3b7e2) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1335/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1335 +/- ## ======================================= Coverage 91.53% 91.53% ======================================= Files 34 34 Lines 4255 4255 ======================================= Hits 3895 3895 Misses 360 360 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1335?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix small typo 895315478 | |
1012546924 | https://github.com/simonw/datasette/issues/1336#issuecomment-1012546924 | https://api.github.com/repos/simonw/datasette/issues/1336 | IC_kwDOBm6k_c48Wj1s | simonw 9599 | 2022-01-13T21:55:58Z | 2022-01-13T21:55:58Z | OWNER | See also: - #1412 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Document turning on WAL for live served SQLite databases 895686039 | |
846481896 | https://github.com/simonw/datasette/issues/1337#issuecomment-846481896 | https://api.github.com/repos/simonw/datasette/issues/1337 | MDEyOklzc3VlQ29tbWVudDg0NjQ4MTg5Ng== | simonw 9599 | 2021-05-23T00:37:52Z | 2021-05-23T00:37:52Z | OWNER | The tricky thing about this is that ideally I'd like this to link to a paginated set of results - but arbitrary SQL queries do not yet support pagination, see #856. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "More" link for facets that shows _facet_size=max results 898904402 | |
849695117 | https://github.com/simonw/datasette/issues/1337#issuecomment-849695117 | https://api.github.com/repos/simonw/datasette/issues/1337 | MDEyOklzc3VlQ29tbWVudDg0OTY5NTExNw== | simonw 9599 | 2021-05-27T14:44:13Z | 2021-05-27T14:44:13Z | OWNER | Here's a much easier way to implement this: implement `?_facet_size=max` (sets it to `max_returned_rows`, default 1000) and then link to that from the ellipsis. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "More" link for facets that shows _facet_size=max results 898904402 | |
849721280 | https://github.com/simonw/datasette/issues/1337#issuecomment-849721280 | https://api.github.com/repos/simonw/datasette/issues/1337 | MDEyOklzc3VlQ29tbWVudDg0OTcyMTI4MA== | simonw 9599 | 2021-05-27T15:18:08Z | 2021-05-27T15:18:08Z | OWNER | In order to cleanly implement this I need to expose the `path_with_replaced_args` utility function to Datasette's template engine. This is the first time this will become an exposed (and hence should-by-documented) API and I don't like its shape much. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "More" link for facets that shows _facet_size=max results 898904402 | |
849725291 | https://github.com/simonw/datasette/issues/1337#issuecomment-849725291 | https://api.github.com/repos/simonw/datasette/issues/1337 | MDEyOklzc3VlQ29tbWVudDg0OTcyNTI5MQ== | simonw 9599 | 2021-05-27T15:23:33Z | 2021-05-27T15:23:33Z | OWNER | Turns out `path_with_replaced_args()` is already exposed to the `table.html` template context: https://github.com/simonw/datasette/blob/f1c29fd6a184254aa68efadf096bcf21e848f921/datasette/views/table.py#L897-L900 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "More" link for facets that shows _facet_size=max results 898904402 | |
849759440 | https://github.com/simonw/datasette/issues/1337#issuecomment-849759440 | https://api.github.com/repos/simonw/datasette/issues/1337 | MDEyOklzc3VlQ29tbWVudDg0OTc1OTQ0MA== | simonw 9599 | 2021-05-27T16:09:34Z | 2021-05-27T16:09:34Z | OWNER | Demo: https://latest.datasette.io/fixtures/facetable?_facet_size=2&_facet=state&_facet=city_id ![demo-max](https://user-images.githubusercontent.com/9599/119860507-3f071780-becb-11eb-8698-64c8c6112983.gif) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "More" link for facets that shows _facet_size=max results 898904402 | |
849761508 | https://github.com/simonw/datasette/issues/1337#issuecomment-849761508 | https://api.github.com/repos/simonw/datasette/issues/1337 | MDEyOklzc3VlQ29tbWVudDg0OTc2MTUwOA== | simonw 9599 | 2021-05-27T16:12:31Z | 2021-05-27T16:12:31Z | OWNER | More exciting demo: https://fivethirtyeight.datasettes.com/fivethirtyeight/antiquities-act%2Factions_under_antiquities_act?_facet=states&_facet=current_agency&_facet=pres_or_congress | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "More" link for facets that shows _facet_size=max results 898904402 | |
849762735 | https://github.com/simonw/datasette/issues/1337#issuecomment-849762735 | https://api.github.com/repos/simonw/datasette/issues/1337 | MDEyOklzc3VlQ29tbWVudDg0OTc2MjczNQ== | simonw 9599 | 2021-05-27T16:14:14Z | 2021-05-27T16:14:14Z | OWNER | Here's a demo showing that once you get above 1,000 results you still get the "..." but it no longer links to anything: https://fivethirtyeight.datasettes.com/fivethirtyeight/births%2FUS_births_2000-2014_SSA?_facet=births&_facet_size=max | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "More" link for facets that shows _facet_size=max results 898904402 | |
847207804 | https://github.com/simonw/datasette/pull/1339#issuecomment-847207804 | https://api.github.com/repos/simonw/datasette/issues/1339 | MDEyOklzc3VlQ29tbWVudDg0NzIwNzgwNA== | codecov[bot] 22429695 | 2021-05-24T17:22:13Z | 2021-05-27T04:14:21Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1339](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (3d8598b) into [main](https://codecov.io/gh/simonw/datasette/commit/a443dba82f43c22b03402a4f86c85558ccb526b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (a443dba) will **increase** coverage by `0.01%`. > The diff coverage is `91.66%`. > :exclamation: Current head 3d8598b differs from pull request most recent head 387c837. Consider uploading reports for the commit 387c837 to get more accurate results [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1339/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1339 +/- ## ========================================== + Coverage 91.55% 91.56% +0.01% ========================================== Files 34 34 Lines 4262 4280 +18 ========================================== + Hits 3902 3919 +17 - Misses 360 361 +1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/1339/diff?src=pr&el=tree&utm_medi… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_col=/?_nocol= to show/hide columns on the table page 899851083 | |
345537268 | https://github.com/simonw/datasette/issues/134#issuecomment-345537268 | https://api.github.com/repos/simonw/datasette/issues/134 | MDEyOklzc3VlQ29tbWVudDM0NTUzNzI2OA== | simonw 9599 | 2017-11-19T18:10:48Z | 2017-11-19T18:10:48Z | OWNER | Dupe of #127 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Filtered table view should show a count 275176094 | |
847987346 | https://github.com/simonw/datasette/issues/1340#issuecomment-847987346 | https://api.github.com/repos/simonw/datasette/issues/1340 | MDEyOklzc3VlQ29tbWVudDg0Nzk4NzM0Ng== | simonw 9599 | 2021-05-25T15:49:55Z | 2021-05-25T15:49:55Z | OWNER | Usual problem with this kind of UI: what would it do on mobile where hover isn't a thing? Plenty of other questions: if it opens a menu, what options might I put in there other than "Show more like this"? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Research: Cell action menu (like column action but for individual cells) 901009787 | |
849310294 | https://github.com/simonw/datasette/issues/1341#issuecomment-849310294 | https://api.github.com/repos/simonw/datasette/issues/1341 | MDEyOklzc3VlQ29tbWVudDg0OTMxMDI5NA== | simonw 9599 | 2021-05-27T04:29:04Z | 2021-05-27T04:29:04Z | OWNER | For implementation simplicity I'm going to show the item even if all of the columns are visible because `?_col=` has selected all of them - selecting it will still reset the view to having no `?_col=` or `?_nocol=` parameters. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "Show all columns" cog menu item should show if ?_col= is used 903200328 | |
849722218 | https://github.com/simonw/datasette/issues/1342#issuecomment-849722218 | https://api.github.com/repos/simonw/datasette/issues/1342 | MDEyOklzc3VlQ29tbWVudDg0OTcyMjIxOA== | simonw 9599 | 2021-05-27T15:19:23Z | 2021-05-27T15:19:23Z | OWNER | Current implementations: https://github.com/simonw/datasette/blob/51d788114035458d8f860d9ea6d74078e6c0ea0d/datasette/utils/__init__.py#L214-L272 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improve `path_with_replaced_args()` and friends and document them 903902495 | |
849724108 | https://github.com/simonw/datasette/issues/1342#issuecomment-849724108 | https://api.github.com/repos/simonw/datasette/issues/1342 | MDEyOklzc3VlQ29tbWVudDg0OTcyNDEwOA== | simonw 9599 | 2021-05-27T15:21:54Z | 2021-05-27T15:21:54Z | OWNER | Turns out some of these are already being exposed to the template context on an ad-hoc basis. In `QueryView`: https://github.com/simonw/datasette/blob/2bd9d54b2762c991e11950c22c88c0336158d49b/datasette/views/database.py#L295-L304 In `TableView`: https://github.com/simonw/datasette/blob/f1c29fd6a184254aa68efadf096bcf21e848f921/datasette/views/table.py#L897-L900 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improve `path_with_replaced_args()` and friends and document them 903902495 | |
849724915 | https://github.com/simonw/datasette/issues/1342#issuecomment-849724915 | https://api.github.com/repos/simonw/datasette/issues/1342 | MDEyOklzc3VlQ29tbWVudDg0OTcyNDkxNQ== | simonw 9599 | 2021-05-27T15:23:01Z | 2021-05-27T15:23:01Z | OWNER | Since they are already exposed (but undocumented) this isn't actually a blocker on #1337 like I thought it was. Should still clean this up in the future though. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improve `path_with_replaced_args()` and friends and document them 903902495 | |
849781747 | https://github.com/simonw/datasette/issues/1343#issuecomment-849781747 | https://api.github.com/repos/simonw/datasette/issues/1343 | MDEyOklzc3VlQ29tbWVudDg0OTc4MTc0Nw== | simonw 9599 | 2021-05-27T16:43:04Z | 2021-05-27T16:43:04Z | OWNER | I'm going to try pushing an alpha of https://github.com/simonw/datasette/releases/tag/0.57a0 using this workflow I built a few months ago: https://github.com/simonw/datasette/blob/1a8972f9c012cd22b088c6b70661a9c3d3847853/.github/workflows/push_docker_tag.yml | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Figure out how to publish alpha/beta releases to Docker Hub 903978133 | |
849782098 | https://github.com/simonw/datasette/issues/1343#issuecomment-849782098 | https://api.github.com/repos/simonw/datasette/issues/1343 | MDEyOklzc3VlQ29tbWVudDg0OTc4MjA5OA== | simonw 9599 | 2021-05-27T16:43:40Z | 2021-05-27T16:43:55Z | OWNER | https://github.com/simonw/datasette/actions/workflows/push_docker_tag.yml <img width="944" alt="Actions_·_simonw_datasette" src="https://user-images.githubusercontent.com/9599/119864935-01f15400-bed0-11eb-8979-0a5cc1b6bcb4.png"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Figure out how to publish alpha/beta releases to Docker Hub 903978133 | |
849783398 | https://github.com/simonw/datasette/issues/1343#issuecomment-849783398 | https://api.github.com/repos/simonw/datasette/issues/1343 | MDEyOklzc3VlQ29tbWVudDg0OTc4MzM5OA== | simonw 9599 | 2021-05-27T16:45:41Z | 2021-05-27T16:45:41Z | OWNER | https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated now shows this at the top: https://hub.docker.com/layers/datasetteproject/datasette/0.57a0/images/sha256-4ab61095c1d879a91d154ed469227387356a305035da9c74542c55bd500c89db?context=explore | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Figure out how to publish alpha/beta releases to Docker Hub 903978133 | |
849784005 | https://github.com/simonw/datasette/issues/1343#issuecomment-849784005 | https://api.github.com/repos/simonw/datasette/issues/1343 | MDEyOklzc3VlQ29tbWVudDg0OTc4NDAwNQ== | simonw 9599 | 2021-05-27T16:46:37Z | 2021-05-27T16:46:37Z | OWNER | That worked: ``` % docker run -it datasetteproject/datasette:0.57a0 Unable to find image 'datasetteproject/datasette:0.57a0' locally 0.57a0: Pulling from datasetteproject/datasette 75646c2fb410: Pull complete edf8b70d3cc4: Pull complete 229daa3ebd94: Pull complete 65d21ac50a56: Pull complete e083ad7cc3ca: Pull complete ed4de1431432: Pull complete 1da5e8b27cca: Pull complete Digest: sha256:4ab61095c1d879a91d154ed469227387356a305035da9c74542c55bd500c89db Status: Downloaded newer image for datasetteproject/datasette:0.57a0 INFO: Started server process [1] INFO: Waiting for application startup. INFO: Application startup complete. INFO: Uvicorn running on http://127.0.0.1:8001 (Press CTRL+C to quit) ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Figure out how to publish alpha/beta releases to Docker Hub 903978133 | |
849788159 | https://github.com/simonw/datasette/issues/1344#issuecomment-849788159 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTc4ODE1OQ== | simonw 9599 | 2021-05-27T16:53:04Z | 2021-05-27T16:53:04Z | OWNER | I'm going to release a `0.57a1` alpha to Docker Hub using the new buildx mechanism. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849788412 | https://github.com/simonw/datasette/issues/1344#issuecomment-849788412 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTc4ODQxMg== | simonw 9599 | 2021-05-27T16:53:28Z | 2021-05-27T16:53:28Z | OWNER | (Should also update https://docs.datasette.io/en/stable/contributing.html#release-process with notes on how this works) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849793312 | https://github.com/simonw/datasette/issues/1344#issuecomment-849793312 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTc5MzMxMg== | simonw 9599 | 2021-05-27T17:01:16Z | 2021-05-27T17:01:16Z | OWNER | https://github.com/simonw/datasette/runs/2687196350 is a run of https://github.com/simonw/datasette/blob/main/.github/workflows/push_docker_tag.yml to publish the new `0.57a1` alpha to Docker Hub. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849797767 | https://github.com/simonw/datasette/issues/1344#issuecomment-849797767 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTc5Nzc2Nw== | simonw 9599 | 2021-05-27T17:08:13Z | 2021-05-27T17:08:13Z | OWNER | Related issue: #1272 - being able to run the test suite inside Docker inside GitHub Actions would be incredibly helpful here. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849801969 | https://github.com/simonw/datasette/issues/1344#issuecomment-849801969 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTgwMTk2OQ== | simonw 9599 | 2021-05-27T17:14:49Z | 2021-05-27T17:14:49Z | OWNER | Job completed in 13m38s - results are here: https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated&name=0.57a1 <img width="1286" alt="datasetteproject_datasette_Tags" src="https://user-images.githubusercontent.com/9599/119868791-5c8caf00-bed4-11eb-9e9f-ebca557621c0.png"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849804684 | https://github.com/simonw/datasette/issues/1344#issuecomment-849804684 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTgwNDY4NA== | simonw 9599 | 2021-05-27T17:19:16Z | 2021-05-27T17:19:16Z | OWNER | Having pushed that to Docker Hub the following _seems_ to work on my laptop: docker run --platform linux/s390x \ -v `pwd`:/mnt -p 8001:8001 \ datasetteproject/datasette:0.57a1 datasette -p 8001 -h 0.0.0.0 I'd like to confirm that this is correctly emulating the architecture and running the correct published image though. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849805778 | https://github.com/simonw/datasette/issues/1344#issuecomment-849805778 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTgwNTc3OA== | simonw 9599 | 2021-05-27T17:21:11Z | 2021-05-27T17:21:22Z | OWNER | This helps: ``` ~ % docker run -it --platform linux/s390x -v `pwd`:/mnt \ -p 8001:8001 datasetteproject/datasette:0.57a1 \ python -c 'import platform; print(platform.uname())' ``` `uname_result(system='Linux', node='d14916ca91df', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='s390x')` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849806581 | https://github.com/simonw/datasette/issues/1344#issuecomment-849806581 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTgwNjU4MQ== | simonw 9599 | 2021-05-27T17:22:37Z | 2021-05-27T17:34:27Z | OWNER | ``` ~ % docker run -it --platform linux/arm/v7 -v `pwd`:/mnt -p 8001:8001 datasetteproject/datasette:0.57a1 python -c 'import platform; print(platform.uname())' Unable to find image 'datasetteproject/datasette:0.57a1' locally 0.57a1: Pulling from datasetteproject/datasette ee0a2cc24f29: Pull complete ca231153300d: Pull complete 6073fc53d406: Pull complete bb2a6a6421dd: Pull complete 14c15f441034: Pull complete 28d113f72ba5: Pull complete 40516c2c3785: Pull complete Digest: sha256:8dd469efa0b34b9e946c4e91496fc7bec702efec9c0f5ec548ccd4030f3263b2 Status: Downloaded newer image for datasetteproject/datasette:0.57a1 uname_result(system='Linux', node='c2e1a05732ed', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='armv7l') ``` Shorter version: ``` ~ % docker run -it --platform linux/ppc64le datasetteproject/datasette:0.57a1 python -c 'import platform; print(platform.uname())' Unable to find image 'datasetteproject/datasette:0.57a1' locally 0.57a1: Pulling from datasetteproject/datasette c840eb5e9aed: Pull complete fc17d8b577ec: Pull complete 712a0ad995f8: Pull complete 56101149914c: Pull complete e6241dfe9d38: Pull complete 41ed85039888: Pull complete 26beeabe9213: Pull complete Digest: sha256:8dd469efa0b34b9e946c4e91496fc7bec702efec9c0f5ec548ccd4030f3263b2 Status: Downloaded newer image for datasetteproject/datasette:0.57a1 uname_result(system='Linux', node='0fe85887fa30', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='ppc64le') ~ % ``` OK! Now I need to figure out how to run the full test suite on each one, then I can call this done. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849815361 | https://github.com/simonw/datasette/issues/1344#issuecomment-849815361 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTgxNTM2MQ== | simonw 9599 | 2021-05-27T17:36:51Z | 2021-05-27T17:36:51Z | OWNER | To run the test suite... need to install a few more dependencies: https://github.com/simonw/datasette/blob/7b106e106000713bbee31b34d694b3dadbd4818c/setup.py#L71-L79 And then mount the `tests/` folder into the container and run `pytest`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
849820019 | https://github.com/simonw/datasette/issues/1344#issuecomment-849820019 | https://api.github.com/repos/simonw/datasette/issues/1344 | MDEyOklzc3VlQ29tbWVudDg0OTgyMDAxOQ== | simonw 9599 | 2021-05-27T17:44:39Z | 2021-05-27T17:52:58Z | OWNER | This pattern appears to work, executed at the root of a checkout of `datasette`: ``` docker run -it -v `pwd`:/mnt --platform linux/amd64 \ datasetteproject/datasette:0.57a1 bash -c ' pip install "pytest>=5.2.2,<6.3.0" \ "pytest-xdist>=2.2.1,<2.3" \ "pytest-asyncio>=0.10,<0.16" \ "beautifulsoup4>=4.8.1,<4.10.0" \ "black==21.5b1" \ "pytest-timeout>=1.4.2,<1.5" \ "trustme>=0.7,<0.8" \ && cd /mnt && pytest' ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test Datasette Docker images built for different architectures 903986178 | |
851113886 | https://github.com/simonw/datasette/issues/1345#issuecomment-851113886 | https://api.github.com/repos/simonw/datasette/issues/1345 | MDEyOklzc3VlQ29tbWVudDg1MTExMzg4Ng== | simonw 9599 | 2021-05-31T01:52:27Z | 2021-05-31T01:52:27Z | OWNER | Related issue: visit https://latest.datasette.io/fixtures/facetable?_facet=state and click "Hide this column" on the "state" cog menu and you get https://latest.datasette.io/fixtures/facetable?_facet=state&_nocol=state which shows an error: > ### Invalid SQL > no such column: state | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocol= does not interact well with default facets 904071938 | |
851114806 | https://github.com/simonw/datasette/issues/1345#issuecomment-851114806 | https://api.github.com/repos/simonw/datasette/issues/1345 | MDEyOklzc3VlQ29tbWVudDg1MTExNDgwNg== | simonw 9599 | 2021-05-31T01:55:56Z | 2021-05-31T01:55:56Z | OWNER | Two options here: - Don't provide users with options that will lead to this situation - so no "Hide this column" option on pages that are already faceted by that column - Ignore facet selections for columns which are no longer visible I think I like the first option more. I could partially implement that in the `table.js` JavaScript by looking at the `?_facet=` parameters... but that won't cover the case where the facet is happening because of default facets configured in `metadata.yml`. Instead the JavaScript should look for evidence in the DOM that specific facets are enabled. This could also help me cover other types of faceting, such as `?_facet_array=` or even custom facets provided by plugins. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocol= does not interact well with default facets 904071938 | |
851115805 | https://github.com/simonw/datasette/issues/1345#issuecomment-851115805 | https://api.github.com/repos/simonw/datasette/issues/1345 | MDEyOklzc3VlQ29tbWVudDg1MTExNTgwNQ== | simonw 9599 | 2021-05-31T01:59:39Z | 2021-05-31T01:59:39Z | OWNER | Maybe there's a concept here of the columns that are required by a selected facet? Those can then be included as `data-` attributes on the page, which will then impact which "Hide this column" options are available. I can also use them to provide a better error message than "no such column: state" - I can verify that `?_nocol` and `?_col` have not been used to disable the required columns. There is one other option here: I could still include the columns that are known to be needed for faceting in the faceting SQL queries, but leave them out of the query that is used to return the results! That's actually a pretty tempting (albeit more complex) option. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocol= does not interact well with default facets 904071938 | |
851116105 | https://github.com/simonw/datasette/issues/1345#issuecomment-851116105 | https://api.github.com/repos/simonw/datasette/issues/1345 | MDEyOklzc3VlQ29tbWVudDg1MTExNjEwNQ== | simonw 9599 | 2021-05-31T02:00:44Z | 2021-05-31T02:00:44Z | OWNER | Maybe there's a short-term and longer-term solution for this - where the long-term solution is to use different columns in the faceting selects, while the short-term solution is to disable "Hide this column" for certain things. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocol= does not interact well with default facets 904071938 | |
851117233 | https://github.com/simonw/datasette/issues/1345#issuecomment-851117233 | https://api.github.com/repos/simonw/datasette/issues/1345 | MDEyOklzc3VlQ29tbWVudDg1MTExNzIzMw== | simonw 9599 | 2021-05-31T02:04:35Z | 2021-05-31T02:04:35Z | OWNER | That long-term solution may not be too difficult. The facets are calculated against `sql_no_limit` which is constructed here: https://github.com/simonw/datasette/blob/7b106e106000713bbee31b34d694b3dadbd4818c/datasette/views/table.py#L659-L665 And used here: https://github.com/simonw/datasette/blob/7b106e106000713bbee31b34d694b3dadbd4818c/datasette/views/table.py#L706-L718 Crucially, `sql_no_limit` is ONLY used for faceting - nothing else uses it anywhere. So constructing it before constructing `sql` and taking `?_col=` and `?_nocol=` into account may not be a complex change. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocol= does not interact well with default facets 904071938 | |
851120306 | https://github.com/simonw/datasette/issues/1345#issuecomment-851120306 | https://api.github.com/repos/simonw/datasette/issues/1345 | MDEyOklzc3VlQ29tbWVudDg1MTEyMDMwNg== | simonw 9599 | 2021-05-31T02:14:36Z | 2021-05-31T02:14:36Z | OWNER | Yes! This was easier than I thought. I'm going with that solution - where facets are calculated against all columns, ignoring `?_col=` and `?_nocol=` entirely. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocol= does not interact well with default facets 904071938 | |
851127314 | https://github.com/simonw/datasette/issues/1345#issuecomment-851127314 | https://api.github.com/repos/simonw/datasette/issues/1345 | MDEyOklzc3VlQ29tbWVudDg1MTEyNzMxNA== | simonw 9599 | 2021-05-31T02:40:26Z | 2021-05-31T02:40:44Z | OWNER | Demo: https://latest.datasette.io/fixtures/facetable?_facet=state&_nocol=state - the state column is not selected but facet by state still works: <img width="1134" alt="fixtures__facetable__15_rows_and_Why_Russians_do_not_smile" src="https://user-images.githubusercontent.com/9599/120132273-110a2780-c198-11eb-91a5-cafb77a78c97.png"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocol= does not interact well with default facets 904071938 | |
850058851 | https://github.com/simonw/datasette/pull/1346#issuecomment-850058851 | https://api.github.com/repos/simonw/datasette/issues/1346 | MDEyOklzc3VlQ29tbWVudDg1MDA1ODg1MQ== | simonw 9599 | 2021-05-28T02:06:46Z | 2021-05-28T02:06:46Z | OWNER | The one test failure here actually illustrates a larger problem: if the user specifies `.json?_shape=array` but an error occurs, what should we do? Prior to this change we return the following JSON: ```json { "ok": false, "error": "You did not supply a value for binding 1.", "status": 500, "title": null } ``` But this comes from the `handle_500` higher level code here: https://github.com/simonw/datasette/blob/eae3084b46e2c3931db12cdef79093ad0e644bce/datasette/app.py#L1251-L1263 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Re-display user's query with an error message if an error occurs 904537568 | |
850059328 | https://github.com/simonw/datasette/pull/1346#issuecomment-850059328 | https://api.github.com/repos/simonw/datasette/issues/1346 | MDEyOklzc3VlQ29tbWVudDg1MDA1OTMyOA== | simonw 9599 | 2021-05-28T02:08:10Z | 2021-05-28T02:09:25Z | OWNER | This is the current test failure, but it actually another problem that we don't have tests in place for errors with different formats and shapes: ``` def test_magic_parameters_cannot_be_used_in_arbitrary_queries(magic_parameters_client): response = magic_parameters_client.get( "/data.json?sql=select+:_header_host&_shape=array" ) assert 400 == response.status > assert "You did not supply a value for binding 1." == response.json["error"] E TypeError: list indices must be integers or slices, not str ``` The test fails because `response.json` here is the empty list `[]`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Re-display user's query with an error message if an error occurs 904537568 | |
852693854 | https://github.com/simonw/datasette/pull/1346#issuecomment-852693854 | https://api.github.com/repos/simonw/datasette/issues/1346 | MDEyOklzc3VlQ29tbWVudDg1MjY5Mzg1NA== | codecov[bot] 22429695 | 2021-06-02T03:44:35Z | 2021-06-02T03:44:35Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1346](https://codecov.io/gh/simonw/datasette/pull/1346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (3bffc35) into [main](https://codecov.io/gh/simonw/datasette/commit/7b106e106000713bbee31b34d694b3dadbd4818c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (7b106e1) will **increase** coverage by `0.14%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1346/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1346 +/- ## ========================================== + Coverage 91.56% 91.71% +0.14% ========================================== Files 34 34 Lines 4282 4332 +50 ========================================== + Hits 3921 3973 +52 + Misses 361 359 -2 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/1346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `95.69% <ø> (-0.15%)` | :arrow_down: | | [d… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Re-display user's query with an error message if an error occurs 904537568 | |
850077261 | https://github.com/simonw/datasette/pull/1348#issuecomment-850077261 | https://api.github.com/repos/simonw/datasette/issues/1348 | MDEyOklzc3VlQ29tbWVudDg1MDA3NzI2MQ== | blairdrummond 10801138 | 2021-05-28T03:05:38Z | 2021-05-28T03:05:38Z | CONTRIBUTOR | Note, the CVEs are probably resolvable with this https://github.com/simonw/datasette/pull/1296 . My experience is that Ubuntu seems to manage these better? Though that is surprising :/ | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | DRAFT: add test and scan for docker images 904598267 | |
850077484 | https://github.com/simonw/datasette/pull/1348#issuecomment-850077484 | https://api.github.com/repos/simonw/datasette/issues/1348 | MDEyOklzc3VlQ29tbWVudDg1MDA3NzQ4NA== | codecov[bot] 22429695 | 2021-05-28T03:06:16Z | 2021-05-28T03:06:16Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1348?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1348](https://codecov.io/gh/simonw/datasette/pull/1348?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (56cba8f) into [main](https://codecov.io/gh/simonw/datasette/commit/7b106e106000713bbee31b34d694b3dadbd4818c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (7b106e1) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1348/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1348 +/- ## ======================================= Coverage 91.56% 91.56% ======================================= Files 34 34 Lines 4282 4282 ======================================= Hits 3921 3921 Misses 361 361 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1348?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | DRAFT: add test and scan for docker images 904598267 | |
850778230 | https://github.com/simonw/datasette/issues/1349#issuecomment-850778230 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MDc3ODIzMA== | simonw 9599 | 2021-05-29T06:11:28Z | 2021-05-29T06:11:28Z | OWNER | Relevant code: https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/datasette/views/base.py#L263-L315 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
850778273 | https://github.com/simonw/datasette/issues/1349#issuecomment-850778273 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MDc3ODI3Mw== | simonw 9599 | 2021-05-29T06:11:59Z | 2021-05-29T06:11:59Z | OWNER | Related issue: https://github.com/simonw/datasette/issues/263 - "Facets should not execute for ?shape=array|object" | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
850778311 | https://github.com/simonw/datasette/issues/1349#issuecomment-850778311 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MDc3ODMxMQ== | simonw 9599 | 2021-05-29T06:12:21Z | 2021-05-29T06:12:21Z | OWNER | It's not just facets, I think it's trying to execute suggested facets too! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
851128524 | https://github.com/simonw/datasette/issues/1349#issuecomment-851128524 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MTEyODUyNA== | simonw 9599 | 2021-05-31T02:44:44Z | 2021-05-31T02:44:44Z | OWNER | Now that I have `?_nofacets=1` I can use that to fix this. The challenge is that in this block of code I need to modify the incoming request's query string arguments, which isn't something I've done before: https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/datasette/views/base.py#L263-L270 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
851129019 | https://github.com/simonw/datasette/issues/1349#issuecomment-851129019 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MTEyOTAxOQ== | simonw 9599 | 2021-05-31T02:46:38Z | 2021-05-31T02:46:38Z | OWNER | I think the right way to do this is to construct a new `Request` with a modified ASGI scope: https://github.com/simonw/datasette/blob/c5ae1197a208e1b034c88882e3ac865813a40980/datasette/utils/asgi.py#L88-L99 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
851129464 | https://github.com/simonw/datasette/issues/1349#issuecomment-851129464 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MTEyOTQ2NA== | simonw 9599 | 2021-05-31T02:48:06Z | 2021-05-31T02:48:06Z | OWNER | Actually there is precedent for swapping out `request.scope` for a new scope, as seen here in the routing code: https://github.com/simonw/datasette/blob/c5ae1197a208e1b034c88882e3ac865813a40980/datasette/app.py#L1117-L1122 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
851131999 | https://github.com/simonw/datasette/issues/1349#issuecomment-851131999 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MTEzMTk5OQ== | simonw 9599 | 2021-05-31T02:57:25Z | 2021-05-31T02:57:25Z | OWNER | I'm having a really hard time figuring out how to unit test this - ideally I'd monitor which SQL queries are executed using the tracing mechanism, but that's not set up to work with anything other than HTML or JSON outputs: https://github.com/simonw/datasette/blob/c5ae1197a208e1b034c88882e3ac865813a40980/datasette/tracer.py#L125-L134 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
851133125 | https://github.com/simonw/datasette/issues/1349#issuecomment-851133125 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MTEzMzEyNQ== | simonw 9599 | 2021-05-31T03:01:48Z | 2021-05-31T03:01:48Z | OWNER | I think it's worth getting `?_trace=1` to work with streaming CSV - this would have helped me spot this issue a long time ago. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
852237347 | https://github.com/simonw/datasette/issues/1349#issuecomment-852237347 | https://api.github.com/repos/simonw/datasette/issues/1349 | MDEyOklzc3VlQ29tbWVudDg1MjIzNzM0Nw== | simonw 9599 | 2021-06-01T15:52:50Z | 2021-06-01T15:52:50Z | OWNER | Fixed in https://github.com/simonw/datasette/commit/d1d06ace49606da790a765689b4fbffa4c6deecb | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | CSV ?_stream=on redundantly calculates facets for every page 906385991 | |
349047335 | https://github.com/simonw/datasette/issues/135#issuecomment-349047335 | https://api.github.com/repos/simonw/datasette/issues/135 | MDEyOklzc3VlQ29tbWVudDM0OTA0NzMzNQ== | simonw 9599 | 2017-12-04T17:57:08Z | 2017-12-04T17:57:08Z | OWNER | Turns out there's a bug in this: https://timezones-now-hrjgkinozh.now.sh/timezones-0d61a90/ElementaryGeometries should not be showing the search box. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_search=x should work if used directly against a FTS virtual table 275179724 | |
349860851 | https://github.com/simonw/datasette/issues/135#issuecomment-349860851 | https://api.github.com/repos/simonw/datasette/issues/135 | MDEyOklzc3VlQ29tbWVudDM0OTg2MDg1MQ== | simonw 9599 | 2017-12-07T04:37:59Z | 2017-12-07T04:37:59Z | OWNER | I'm testing this like so: datasette ~/Dropbox/Development/timezones-api/timezones.db --reload --load-extension /usr/local/lib/mod_spatialite.dylib | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_search=x should work if used directly against a FTS virtual table 275179724 | |
349861461 | https://github.com/simonw/datasette/issues/135#issuecomment-349861461 | https://api.github.com/repos/simonw/datasette/issues/135 | MDEyOklzc3VlQ29tbWVudDM0OTg2MTQ2MQ== | simonw 9599 | 2017-12-07T04:43:12Z | 2017-12-07T04:43:12Z | OWNER | This query looks like it does the right thing: select * from sqlite_master where rootpage = 0 and ( sql like '%VIRTUAL TABLE%USING FTS%content="ElementaryGeometries"%' or ( tbl_name = "ElementaryGeometries" and sql like '%VIRTUAL TABLE%USING FTS%' ) ) Against a table that should not be shown as FTS: https://timezones-now-hrjgkinozh.now.sh/timezones-0d61a90?sql=++++++++select+*+from+sqlite_master%0D%0A++++++++++++where+rootpage+%3D+0%0D%0A++++++++++++and+%28%0D%0A++++++++++++++++sql+like+%27%25VIRTUAL+TABLE%25USING+FTS%25content%3D%22ElementaryGeometries%22%25%27%0D%0A++++++++++++++++or+%28%0D%0A++++++++++++++++++tbl_name+%3D+%22ElementaryGeometries%22%0D%0A++++++++++++++++++and+sql+like+%27%25VIRTUAL+TABLE%25USING+FTS%25%27%0D%0A++++++++++++++++%29%0D%0A++++++++++++%29+ Against a table that SHOULD match: https://sf-trees.now.sh/sf-trees-ebc2ad9?sql=++++++++select+*+from+sqlite_master%0D%0A++++++++++++where+rootpage+%3D+0%0D%0A++++++++++++and+%28%0D%0A++++++++++++++++sql+like+%27%25VIRTUAL+TABLE%25USING+FTS%25content%3D%22Street_Tree_List_fts%22%25%27%0D%0A++++++++++++++++or+%28%0D%0A++++++++++++++++++tbl_name+%3D+%22Street_Tree_List_fts%22%0D%0A++++++++++++++++++and+sql+like+%27%25VIRTUAL+TABLE%25USING+FTS%25%27%0D%0A++++++++++++++++%29%0D%0A++++++++++++%29+ | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_search=x should work if used directly against a FTS virtual table 275179724 | |
851122934 | https://github.com/simonw/datasette/issues/1350#issuecomment-851122934 | https://api.github.com/repos/simonw/datasette/issues/1350 | MDEyOklzc3VlQ29tbWVudDg1MTEyMjkzNA== | simonw 9599 | 2021-05-31T02:23:47Z | 2021-05-31T02:23:47Z | OWNER | I think `?_facets_off=1` is a good design for this. I considered `?_facet=` with an empty string but that's a bit weird, and it's not clear what that would do if used like `?_facet=state&_facet=`. So it definitely needs to be a separate named option. Actually, since I have `?_nocol=` I'm going to call this `?_nofacets=1` instead as that's a little more consistent. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nofacets=1 query string argument for disabling facets and suggested facets 906977719 | |
852256454 | https://github.com/simonw/datasette/issues/1350#issuecomment-852256454 | https://api.github.com/repos/simonw/datasette/issues/1350 | MDEyOklzc3VlQ29tbWVudDg1MjI1NjQ1NA== | simonw 9599 | 2021-06-01T16:19:38Z | 2021-06-01T16:19:38Z | OWNER | I renamed this to `?_nofacet=1` in #1353. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nofacets=1 query string argument for disabling facets and suggested facets 906977719 | |
851133471 | https://github.com/simonw/datasette/issues/1351#issuecomment-851133471 | https://api.github.com/repos/simonw/datasette/issues/1351 | MDEyOklzc3VlQ29tbWVudDg1MTEzMzQ3MQ== | simonw 9599 | 2021-05-31T03:02:59Z | 2021-05-31T03:02:59Z | OWNER | Since traces only work with `text/html` and JSON at the moment, the easiest way to do this will be to wrap generated CSV in a HTML page in a textarea if the user specified `?_trace=1`: https://github.com/simonw/datasette/blob/c5ae1197a208e1b034c88882e3ac865813a40980/datasette/tracer.py#L125-L134 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Get `?_trace=1` working with CSV and streaming CSVs 906993731 | |
852673695 | https://github.com/simonw/datasette/pull/1352#issuecomment-852673695 | https://api.github.com/repos/simonw/datasette/issues/1352 | MDEyOklzc3VlQ29tbWVudDg1MjY3MzY5NQ== | simonw 9599 | 2021-06-02T02:52:26Z | 2021-06-02T02:52:26Z | OWNER | @dependabot recreate | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Bump black from 21.5b1 to 21.5b2 908276134 | |
852238201 | https://github.com/simonw/datasette/issues/1353#issuecomment-852238201 | https://api.github.com/repos/simonw/datasette/issues/1353 | MDEyOklzc3VlQ29tbWVudDg1MjIzODIwMQ== | simonw 9599 | 2021-06-01T15:53:57Z | 2021-06-01T15:53:57Z | OWNER | I'm going to rename `?_nofacets=1` to `?_nofacet=1` to keep it consistent with the new `?_nocount=1` option (and because I don't like `?_nocounts=1`). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocount=1 for opting out of table counts 908446997 | |
852255951 | https://github.com/simonw/datasette/issues/1353#issuecomment-852255951 | https://api.github.com/repos/simonw/datasette/issues/1353 | MDEyOklzc3VlQ29tbWVudDg1MjI1NTk1MQ== | simonw 9599 | 2021-06-01T16:18:54Z | 2021-06-01T16:18:54Z | OWNER | Documented here: https://docs.datasette.io/en/latest/json_api.html#special-table-arguments | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ?_nocount=1 for opting out of table counts 908446997 | |
852254298 | https://github.com/simonw/datasette/issues/1354#issuecomment-852254298 | https://api.github.com/repos/simonw/datasette/issues/1354 | MDEyOklzc3VlQ29tbWVudDg1MjI1NDI5OA== | simonw 9599 | 2021-06-01T16:16:32Z | 2021-06-01T16:16:32Z | OWNER | Running `python update-docs-help.py` helps fix this. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update help in tests for latest Click 908465747 | |
853557439 | https://github.com/simonw/datasette/issues/1355#issuecomment-853557439 | https://api.github.com/repos/simonw/datasette/issues/1355 | MDEyOklzc3VlQ29tbWVudDg1MzU1NzQzOQ== | simonw 9599 | 2021-06-03T04:43:14Z | 2021-06-03T04:43:14Z | OWNER | It's using `TestClient` at the moment which is a wrapper around `httpx` (as of ) that uses the `@async_to_sync` decorator to hide the async nature. https://github.com/simonw/datasette/blob/f78ebdc04537a6102316d6dbbf6c887565806078/datasette/utils/testing.py#L102-L156 Maybe the fix here is to switch the `--get` implementation to using `httpx` directly with https://www.python-httpx.org/async/#streaming-responses | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | datasette --get should efficiently handle streaming CSV 910088936 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
created_at (date) >30 ✖